On 2013/01/22 15:46:27, arobison wrote:
Removed the new cell table builder and reworked to make the change in
AbstractCellTable instead. Removed the isKeyboardSelectable stuff.
Can you update the description to match the actual changes? (I must say
I'm a bit lost).
If it indeed is a fix for
Please also follow tbroyer's suggestion for the change description.
Basically idea is to put following as your CL description:
... A one liner description of the change ...
... Add additional longer description in multiple lines(if needed) ...
... Add 'Fixes issue ' as last line (if
(my comments didn't go through before)
http://gwt-code-reviews.appspot.com/1879803/diff/5001/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
(right):
http://gwt-code-reviews.appspot.com/1879803/diff/6004/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
(right):
LGTM
And thanks for the patch. Let's give little bit more time for other
reviewers to comment then we can submit it internally.
On 2013/01/22 23:05:27, arobison wrote:
I originally thought the cell parent way was a little cleaner, but
after another
look I don't really have any preference
On 2013/01/18 20:17:50, arobison wrote:
I like the idea of making the change in
AbstractCellTable#onBrowserEvent2 - it
cuts out a lot of unnecessary stuff and everyone who uses an HTML
table
implementation will get the benefit immediately (without having to
extend a new
table builder).
