[gwt-contrib] Re: XMLElement owns parsing

2009-11-04 Thread rjrjr
And releases/2...@6654 http://gwt-code-reviews.appspot.com/92805 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: XMLElement owns parsing

2009-11-04 Thread rjrjr
And releases/2...@6654 http://gwt-code-reviews.appspot.com/92805 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: XMLElement owns parsing

2009-11-04 Thread rjrjr
Committed tr...@r6653 http://gwt-code-reviews.appspot.com/92805 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: XMLElement owns parsing

2009-11-04 Thread rjrjr
Responded to the feedback, will commit soon. Trunk has shifted in the course of the review and Rietveld and git are confusing each other as a result, I'll keep an eye on that before submitting. http://gwt-code-reviews.appspot.com/92805/diff/28/1042 File user/src/com/google/gwt/uibinder/rebind/XM

[gwt-contrib] Re: XMLElement owns parsing

2009-11-04 Thread bobv
LGTM. The comments that I have are general in nature. http://gwt-code-reviews.appspot.com/92805/diff/28/1042 File user/src/com/google/gwt/uibinder/rebind/XMLElement.java (right): http://gwt-code-reviews.appspot.com/92805/diff/28/1042#newcode149 Line 149: // type matches the given type CssResou

[gwt-contrib] Re: XMLElement owns parsing

2009-11-04 Thread rjrjr
Bob V has graciously taken custody. http://gwt-code-reviews.appspot.com/92805 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---