Re: [gwt-contrib] Remove long-deprecated event listeners and EventPreview. (issue1822803)

2012-09-04 Thread Thomas Broyer
On Tue, Sep 4, 2012 at 11:53 PM, Ray Cromwell wrote: > Thomas, thanks for all of the work on this, but we will have to delay > this until after we get the open-source git/gerrit repo up and > running. No problem (no, really!) Someone had to do it and I was in the mood for it; and the patch shoul

Re: [gwt-contrib] Remove long-deprecated event listeners and EventPreview. (issue1822803)

2012-09-04 Thread Ray Cromwell
In ordinary cases where there is no API change, I don't think the problem is so severe. But removing APIs, even deprecated ones, is always hard, just look at the Web and the debates over vendor prefixes. At Google we do have tools that help with 'company wide refactoring', the EventListener issue

Re: [gwt-contrib] Remove long-deprecated event listeners and EventPreview. (issue1822803)

2012-09-04 Thread John A. Tamplin
On Tue, Sep 4, 2012 at 6:48 PM, Stephen Haberman wrote: > > > give internal teams a lead time to fix their usages first > > Haven't these been deprecated since ~2008? How much more lead time is > necessary? Is there a "@NoSeriouslyWeReallyMeanItDeprecated" annotation > we should use instead? > Ac

Re: [gwt-contrib] Remove long-deprecated event listeners and EventPreview. (issue1822803)

2012-09-04 Thread Stephen Haberman
> give internal teams a lead time to fix their usages first Haven't these been deprecated since ~2008? How much more lead time is necessary? Is there a "@NoSeriouslyWeReallyMeanItDeprecated" annotation we should use instead? Even with the new process, if google-vendor is going to diverge from tr

Re: [gwt-contrib] Remove long-deprecated event listeners and EventPreview. (issue1822803)

2012-09-04 Thread Ray Cromwell
Thomas, thanks for all of the work on this, but we will have to delay this until after we get the open-source git/gerrit repo up and running. A preliminary investigation of internal Google apps shows a bunch of them still relying on EventListener, so we'll have to create an uber-patch to fix all of

Re: [gwt-contrib] Remove long-deprecated event listeners and EventPreview. (issue1822803)

2012-09-03 Thread Stephen Haberman
Awesome work, Thomas! - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Remove long-deprecated event listeners and EventPreview. (issue1822803)

2012-09-02 Thread t . broyer
Reviewers: cromwellian, rdayal, Description: Remove long-deprecated event listeners and EventPreview. Please review this at https://gwt-code-reviews.appspot.com/1822803/ Affected files: M reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java D reference/code-