Re: [gwt-contrib] Working on a patch to fix Exception wrapping/unwrapping in compiler

2013-07-09 Thread Ray Cromwell
What I mean is, uncaught native JS exceptions should still be caught by a catch(Throwable) being somewhere on the stack frame. Techncially, the stack trace wasn't lost, as it was available on JavaScriptException.getException().stack, but I get the point, I implemented a similar unwrap for gwt-expor

Re: [gwt-contrib] Working on a patch to fix Exception wrapping/unwrapping in compiler

2013-07-09 Thread Goktug Gokdogan
On Tue, Jul 9, 2013 at 2:30 PM, Ray Cromwell wrote: > To me clear, if I put catch(Exception), catch(Throwable), or > catch(RuntimeException), I would expect to catch JavaScriptExceptions. > Yes, that's correct. We are not changing that. > I would only expect a JS exception to escape if and on

Re: [gwt-contrib] Working on a patch to fix Exception wrapping/unwrapping in compiler

2013-07-09 Thread Ray Cromwell
To me clear, if I put catch(Exception), catch(Throwable), or catch(RuntimeException), I would expect to catch JavaScriptExceptions. I would only expect a JS exception to escape if and only if, there are no catch blocks for it, or any of it's supertypes, and no uncaught exception handler is installe

[gwt-contrib] Working on a patch to fix Exception wrapping/unwrapping in compiler

2013-06-14 Thread Goktug Gokdogan
I just wanted to give you a heads up that Roberto and I are working on a compiler patch so that catch statement will not break js originated exceptions. To give you some background, if you put any try/catch statement in Java, js originated exceptions will be converted into JavaScriptException even