Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-02 Thread Martin Landa
Reminder for all Windows users, please note that winGRASS 7.1 no.>981 will be broken (calling python script from python script issue - eg. wxGUI Extension manager) again. 2014-06-03 7:24 GMT+02:00 : > Author: glynn > Date: 2014-06-02 22:24:32 -0700 (Mon, 02 Jun 2014) > New Revision: 60679 > > Mod

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-03 Thread Pietro
Hi Glynn, On Tue, Jun 3, 2014 at 8:55 AM, Martin Landa wrote: > Reminder for all Windows users, please note that winGRASS 7.1 no.>981 > will be broken (calling python script from python script issue - eg. > wxGUI Extension manager) again. > > 2014-06-03 7:24 GMT+02:00 : >> Author: glynn >> Date:

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-04 Thread Martin Landa
2014-06-03 9:10 GMT+02:00 Pietro : >>> Remove Popen() "magic" on Windows; it creates more problems than it solves > > Please, could you explain which problems creates? I am waiting for reasonable/acceptable explanation for long time, I do not assume that it will ever come. Anyway, dear all, this c

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-04 Thread Helmut Kudrnovsky
Martin Landa wrote > 2014-06-03 9:10 GMT+02:00 Pietro < > peter.zamb@ > >: Remove Popen() "magic" on Windows; it creates more problems than it solves >> >> Please, could you explain which problems creates? > > I am waiting for reasonable/acceptable explanation for long time, I do > not

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-04 Thread Glynn Clements
Pietro wrote: > > Reminder for all Windows users, please note that winGRASS 7.1 no.>981 > > will be broken (calling python script from python script issue - eg. > > wxGUI Extension manager) again. > > > > 2014-06-03 7:24 GMT+02:00 : > >> Author: glynn > >> Date: 2014-06-02 22:24:32 -0700 (Mon, 0

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-04 Thread Markus Neteler
On Wed, Jun 4, 2014 at 7:56 PM, Glynn Clements wrote: ... > So either: > > 1. GRASS 7 will need .bat wrappers for Python scripts on Windows. That > has the same issues as using shell=True, but at least it only applies > in the case where we're executing a script. ... this would follow the apparen

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-04 Thread Martin Landa
2014-06-04 22:35 GMT+02:00 Markus Neteler : >> 2. If we know that the "program" is a script, the interpreter can be >> specified explicitly (i.e. "python path/to/script.py"). This keeps the >> shell out of the picture. > > ... how much effort is the latter? Check file type and path to file? this

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-05 Thread Moritz Lennert
On 04/06/14 22:35, Markus Neteler wrote: On Wed, Jun 4, 2014 at 7:56 PM, Glynn Clements wrote: ... So either: 1. GRASS 7 will need .bat wrappers for Python scripts on Windows. That has the same issues as using shell=True, but at least it only applies in the case where we're executing a script.

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-05 Thread Martin Landa
Hi, 2014-06-05 17:36 GMT+02:00 Moritz Lennert : >> ... this would follow the apparently working method in GRASS 6. >> Maybe worth a try also in GRASS 7 at this point. > > > I had the feeling that this was the "consensus" (or at least with lack of > clear dissension) we had reached: "consensus" is

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-05 Thread Moritz Lennert
On 05/06/14 21:14, Martin Landa wrote: Hi, 2014-06-05 17:36 GMT+02:00 Moritz Lennert : ... this would follow the apparently working method in GRASS 6. Maybe worth a try also in GRASS 7 at this point. I had the feeling that this was the "consensus" (or at least with lack of clear dissension)

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-05 Thread Glynn Clements
Markus Neteler wrote: > > 1. GRASS 7 will need .bat wrappers for Python scripts on Windows. That > > has the same issues as using shell=True, but at least it only applies > > in the case where we're executing a script. > > ... this would follow the apparently working method in GRASS 6. > Maybe w

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-06 Thread Glynn Clements
Martin Landa wrote: > >> ... this would follow the apparently working method in GRASS 6. > >> Maybe worth a try also in GRASS 7 at this point. > > > > > > I had the feeling that this was the "consensus" (or at least with lack of > > clear dissension) we had reached: > > "consensus" is somehow co

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-06 Thread Anna Petrášová
On Fri, Jun 6, 2014 at 3:08 AM, Glynn Clements wrote: > > Martin Landa wrote: > > > >> ... this would follow the apparently working method in GRASS 6. > > >> Maybe worth a try also in GRASS 7 at this point. > > > > > > > > > I had the feeling that this was the "consensus" (or at least with lack >

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-07 Thread Martin Landa
Hi, 2014-06-06 15:49 GMT+02:00 Anna Petrášová : [...] > I would suggest to remove the link to GRASS 71 on GRASS website unless > someone is going to fix this soon. I have commented out 7.1 [1,2]. I do not believe than someone will fix it soon. The person who introduced the complete break [3] si

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-07 Thread Glynn Clements
Martin Landa wrote: > > I would suggest to remove the link to GRASS 71 on GRASS website unless > > someone is going to fix this soon. > > I have commented out 7.1 [1,2]. I do not believe than someone will fix > it soon. Even if they don't, everything except scripts should still work. There are

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-07 Thread Helmut Kudrnovsky
>On Unix, you'd expect developers to just build from source. But on >Windows, getting a development environment set up is a lot more >effort, so having access to binaries is still useful for developers. [...] >However, my Windows system is still rather >inadequate as a development platform (it doe

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-08 Thread Martin Landa
2014-06-07 18:28 GMT+02:00 Glynn Clements : [...] Right, anyway it's not the first time you broken Windows builds without any attempt to fix (or even attempt to understand what you broke - it requires that you at least install GRASS on your Windows machine). The last example which I can mention i

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-06-09 Thread Glynn Clements
Martin Landa wrote: > Cool, if you are reverting other attempts you could probably find some > time to implement it even it's not "exactly rocket science". The > discussion about this topic has probably tens of e-mails with > guessable result. You were proposed bat-files at the beginning, no > c

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-01 Thread Martin Landa
2014-06-09 11:01 GMT+02:00 Glynn Clements : beside remaining compilation errors [1], wingrass 71 still (after weeks!!!) even doesn't start... Traceback (most recent call last): File "C:\OSGEO4~1\apps\grass\grass-7.1.svn\gui\wxpython\gis_set.py", line 31, in from core import globalvar Fil

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-01 Thread Luca Delucchi
On 1 July 2014 14:00, Martin Landa wrote: > 2014-06-09 11:01 GMT+02:00 Glynn Clements : > > beside remaining compilation errors [1], wingrass 71 still (after > weeks!!!) even doesn't start... > > Traceback (most recent call last): > File "C:\OSGEO4~1\apps\grass\grass-7.1.svn\gui\wxpython\gis_set

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-01 Thread Glynn Clements
Martin Landa wrote: > beside remaining compilation errors [1], wingrass 71 still (after > weeks!!!) even doesn't start... Does anyone want to test the attached patch? In particular, it needs to be tested with a Python script invoking an exe with arguments containing characters which are likely

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-02 Thread Martin Landa
2014-07-02 1:10 GMT+02:00 Glynn Clements : > Does anyone want to test the attached patch? I have locally applied the patch on the build server, result is `r61114M-1010` [1], GRASS starts (welcome screen), unfortunately wxGUI fails with File "C:\OSGEO4~1\apps\grass\grass-7.1.svn\gui\wxpython\wxg

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-02 Thread Vaclav Petras
On Wed, Jul 2, 2014 at 10:39 AM, Martin Landa wrote: > The reason is empty XML wxGUI menu file (menudata.xml) produced by > building system, see [2]. > > Traceback (most recent call last): > File "core/toolboxes.py", line 759, in > sys.exit(main()) > File "core/toolboxes.py", line 745, i

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-02 Thread Anna Petrášová
On Wed, Jul 2, 2014 at 10:59 AM, Vaclav Petras wrote: > > On Wed, Jul 2, 2014 at 10:39 AM, Martin Landa > wrote: > >> The reason is empty XML wxGUI menu file (menudata.xml) produced by >> building system, see [2]. >> >> Traceback (most recent call last): >> File "core/toolboxes.py", line 759,

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-02 Thread Anna Petrášová
On Wed, Jul 2, 2014 at 11:19 AM, Anna Petrášová wrote: > > > > On Wed, Jul 2, 2014 at 10:59 AM, Vaclav Petras > wrote: > >> >> On Wed, Jul 2, 2014 at 10:39 AM, Martin Landa >> wrote: >> >>> The reason is empty XML wxGUI menu file (menudata.xml) produced by >>> building system, see [2]. >>> >>>

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-02 Thread Martin Landa
Hi, 2014-07-02 17:19 GMT+02:00 Anna Petrášová : > It's because it can't find v.in.gps. I suggest to add to the patch something > like this: thanks, I included modified patch to the next build n1011. Martin ___ grass-dev mailing list grass-dev@lists.os

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-02 Thread Glynn Clements
Anna Petrášová wrote: > > It's because it can't find v.in.gps. I suggest to add to the patch > something like this: > > +def __init__(self, args, **kwargs): > +if ( sys.platform == 'win32' > + and isinstance(args, list) > + and not kwargs.get('shell', False) >

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-02 Thread Glynn Clements
Anna Petrášová wrote: > Running this command in gui console works but r.info gives incorrect result: > r.support map=scanned title="|@#$%^&*()" > and r.info gives ^^^|@#$%^^^&*() That implies that the GUI is escaping for the shell but then either not using the shell or overdoing the escaping

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-02 Thread Vaclav Petras
On Wed, Jul 2, 2014 at 7:35 PM, Glynn Clements wrote: > kwargs['shell'] = True > args = [self._escape_for_shell(arg) for arg in args] > Considering security issues connected to shell=True* and uncertainty of escaping for MS Windows**, wouldn't be better to avoid shell=True and try to use the rig

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-03 Thread Martin Landa
Hi, 2014-07-02 20:54 GMT+02:00 Martin Landa : >> It's because it can't find v.in.gps. I suggest to add to the patch something >> like this: > > thanks, I included modified patch to the next build n1011. Martin seems to be set forward, committed as r61135, feel free to improve. Martin -- Martin

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-05 Thread Glynn Clements
Vaclav Petras wrote: > > kwargs['shell'] = True > > args = [self._escape_for_shell(arg) for arg in args] > > Considering security issues connected to shell=True* and uncertainty of > escaping for MS Windows**, wouldn't be better to avoid shell=True and try > to use the right interpreter? This ca

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-06 Thread Helmut Kudrnovsky
Martin Landa wrote > Hi, > > 2014-07-02 20:54 GMT+02:00 Martin Landa < > landa.martin@ > >: >>> It's because it can't find v.in.gps. I suggest to add to the patch >>> something like this: >> >> thanks, I included modified patch to the next build n1011. Martin > > seems to be set forward, commit

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-07 Thread Anna Petrášová
On Sun, Jul 6, 2014 at 3:59 AM, Helmut Kudrnovsky wrote: > Martin Landa wrote > > Hi, > > > > 2014-07-02 20:54 GMT+02:00 Martin Landa < > > > landa.martin@ > > > >: > >>> It's because it can't find v.in.gps. I suggest to add to the patch > >>> something like this: > >> > >> thanks, I included mod

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-07 Thread Martin Landa
Hi, 2014-07-07 21:58 GMT+02:00 Anna Petrášová : > It's because gui doesn't reflect recent changes by Martin. I temporarily > fixed it in r61171 but I don't really understand current status, is it still > work in progress? By the way the Popen class should be changed according two > Glynn's sugges

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-08 Thread Helmut Kudrnovsky
Anna Petrášová wrote > On Sun, Jul 6, 2014 at 3:59 AM, Helmut Kudrnovsky < > hellik@ > > wrote: > >> "C:\OSGeo4W\apps\grass\grass-7.1.svn\etc\python\grass\script\core.py", li >> ne 58, in __init__ >> raise OSError >> OSError >> >> >> > > It's because gui doesn't reflect recent changes by Ma

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-09 Thread Anna Petrášová
On Tue, Jul 8, 2014 at 4:13 AM, Helmut Kudrnovsky wrote: > Anna Petrášová wrote > > On Sun, Jul 6, 2014 at 3:59 AM, Helmut Kudrnovsky < > > > hellik@ > > > > wrote: > > > >> "C:\OSGeo4W\apps\grass\grass-7.1.svn\etc\python\grass\script\core.py", > li > >> ne 58, in __init__ > >> raise OSError

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-09 Thread Helmut Kudrnovsky
Anna Petrášová wrote >> >> the GUI starts now, thanks. >> > > g.gui.* modules are not found, there is no bat file created for them. > Could > something similar to this be used for them as well? Otherwise everything > seems to be working. > http://trac.osgeo.org/grass/changeset/61136 > > Anna g.g

Re: [GRASS-dev] [GRASS-SVN] r60679 - grass/trunk/lib/python/script

2014-07-09 Thread Martin Landa
Hi, 2014-07-09 17:32 GMT+02:00 Helmut Kudrnovsky : > also again, python addon scripts needs again bat-files in windows. also user-defined script will need bat files... Martin -- Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa ___ grass-dev mailing l