Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

Hello Vaclav. otrd., 2020. g. 4. febr., plkst. 19:51 — lietotājs Vaclav Petras () rakstīja: > > Hi Maris and Markus, > > On Tue, Feb 4, 2020 at 3:39 AM Maris Nartiss wrote: >> >> Hello Markus, >> as most of errors reported are legit, some of them are useless at the >> current philosophy of GRASS

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

Hi Maris and Markus, On Tue, Feb 4, 2020 at 3:39 AM Maris Nartiss wrote: > Hello Markus, > as most of errors reported are legit, some of them are useless at the > current philosophy of GRASS GIS. We are OK with small memory leaks, as > modules are intended to be short running and then memory is

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

Hello Markus, as most of errors reported are legit, some of them are useless at the current philosophy of GRASS GIS. We are OK with small memory leaks, as modules are intended to be short running and then memory is reclaimed by the OS (this is faster than freeing it before exit). Of course, this

[GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

Hi devs, I have re-run the coverity scan on master, results below. There is also the option of Travis integration which might be a good idea. Anyone to support this? Markus -- Forwarded message - From: Date: Mon, Feb 3, 2020 at 6:58 PM Subject: New Defects reported by

[GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

FYI - from a yesterday's run. BTW: we should connect it to Travis: https://scan.coverity.com/travis_ci -- Forwarded message -- From: Date: Thu, Dec 10, 2015 at 4:47 PM Subject: New Defects reported by Coverity Scan for grass Hi, Please find the

[GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

FYI, a scan of r64128 done today: -- Forwarded message -- From: scan-ad...@coverity.com Date: Tue, Jan 13, 2015 at 3:39 PM Subject: New Defects reported by Coverity Scan for grass Hi, Please find the latest report on new defect(s) introduced to grass found with Coverity Scan.

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

Markus Neteler wrote: /vector/v.net/connect.c: 145 in connect_arcs() CID 1256093: Resource leak (RESOURCE_LEAK) Variable exclude_list going out of scope leaks the storage it points to. This is probably as simple as adding Vect_destroy_list(exclude_list) to the end of

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

Markus Neteler wrote: I have submitted r62566 from today to Coverity Scan, results below. Calling Rast_read_colors without checking return value (as is done elsewhere 50 out of 61 times). I'd suggest fixing this by removing the redundant checks and making the needed check mostly redundant.

[GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

Hi, I have submitted r62566 from today to Coverity Scan, results below. Markus -- Forwarded message -- From: scan-ad...@coverity.com Date: Mon, Nov 3, 2014 at 9:57 AM Subject: New Defects reported by Coverity Scan for grass To: nete...@osgeo.org Hi, Please find the latest

[GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

Hi, I have uploaded the current trunk (r62476), some improvements achieved! Analysis Summary: New defects found: 4 Defects eliminated: 19 Below the 4 newly introduced issues, hoping for comments/fixes. Markus The results are available at http://scan.coverity.com/projects/1038

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

On Wed, Oct 29, 2014 at 9:31 AM, Markus Neteler nete...@osgeo.org wrote: Hi, I have uploaded the current trunk (r62476), some improvements achieved! Analysis Summary: New defects found: 4 Defects eliminated: 19 Below the 4 newly introduced issues, hoping for

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

On Mon, Oct 27, 2014 at 9:22 AM, Markus Neteler nete...@osgeo.org wrote: On Tue, Oct 21, 2014 at 4:48 AM, Glynn Clements ... ** CID 1248540: Uninitialized scalar variable (UNINIT) /imagery/i.eb.hsebal01/main.c: 200 in main() ... This needs the correct logic for option dependencies. I have

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

On Tue, Oct 21, 2014 at 4:48 AM, Glynn Clements gl...@gclements.plus.com wrote: Markus Neteler wrote: ** CID 1248526: Result is not floating-point (UNINTENDED_INTEGER_DIVISION) /imagery/i.atcorr/aerosolmodel.cpp: 388 in ... ** CID 1248523: Result is not floating-point

[GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

FYI - from the latest coverity scan. Markus -- Forwarded message -- From: scan-ad...@coverity.com Date: Mon, Oct 20, 2014 at 5:11 PM Subject: New Defects reported by Coverity Scan for grass To: neteler@ Hi, Please find the latest report on new defect(s) introduced to grass

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

2014-10-20 17:51 GMT+02:00 Markus Neteler nete...@osgeo.org: ** CID 1248541: Untrusted loop bound (TAINTED_SCALAR) /lib/vector/Vlib/read_pg.c: 1073 in polygon_from_wkb() hopefully fixed in r62308. Martin -- Martin Landa * http://geo.fsv.cvut.cz/gwiki/Landa

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

On Mon, Oct 20, 2014 at 12:13 PM, Martin Landa landa.mar...@gmail.com wrote: 2014-10-20 17:51 GMT+02:00 Markus Neteler nete...@osgeo.org: ** CID 1248541: Untrusted loop bound (TAINTED_SCALAR) /lib/vector/Vlib/read_pg.c: 1073 in polygon_from_wkb() hopefully fixed in r62308. Martin

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

2014-10-20 20:02 GMT+02:00 Vaclav Petras wenzesl...@gmail.com: num_of_rings = *nrings; I'm not sure what tainted scalar means but isn't this just hiding the issue, so that the checking tool cannot find it? AFAIU, the problem is dynamically computed value in loop condition. It could be

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

To: Vaclav Petras Cc: GRASS developers list Subject: Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass 2014-10-20 20:02 GMT+02:00 Vaclav Petras wenzesl...@gmail.com: num_of_rings = *nrings; I'm not sure what tainted scalar means but isn't this just hiding the issue, so

Re: [GRASS-dev] Fwd: New Defects reported by Coverity Scan for grass

Markus Neteler wrote: ** CID 1248526: Result is not floating-point (UNINTENDED_INTEGER_DIVISION) /imagery/i.atcorr/aerosolmodel.cpp: 388 in for(int k = 1; k = mu; k++) { double co_n = (2 * k + 1) / k / (k + 1); co_n will be 1.0 if k==1 and 0.0 otherwise. I