Re: [GRASS-dev] Submitting module to addons - r.sundenoise - mentor required

2009-07-03 Thread Martin Landa
Hi, 2009/7/2 John A Stevenson john.steven...@manchester.ac.uk: My module is a shell script that works as a wrapper to the algorithm so that it can be run from within GRASS, in much the same way as r.surf.nnbathy too much work to rewrite it to Python? (If I can suggest please write new modules

Re: [GRASS-dev] Submitting module to addons - r.sundenoise - mentor required

2009-07-03 Thread John A Stevenson
Hi Martin, Martin Landa wrote: too much work to rewrite it to Python? I have in my mind to write a python version at some stage, as it isn't a complicated script. But first I need to learn python... I uploaded a shell script first as I have had a paper accepted about the denoising

Re: [GRASS-dev] Submitting module to addons - r.sundenoise - mentor required

2009-07-03 Thread Hamish
Martin wrote: In GRASS7 there is no extra support for shell scripts. This is IMO a huge, huge mistake. I am fine that all future run-time scripts shipped with GRASS 7+ be written in python, but I think it is a serious strategic error to force users to learn python and rewrite all their private

Re: [GRASS-dev] Submitting module to addons - r.sundenoise - mentor required

2009-07-03 Thread Martin Landa
Hi, 2009/7/3 Hamish hamis...@yahoo.com: In GRASS7 there is no extra support for shell scripts. This is IMO a huge, huge mistake. I do not claim that it shouldn't be possible to run shell scripts in GRASS7. Most of the restrictions in our lives are bad at the end;-) Anyway I highly suggest to

Re: [GRASS-dev] Submitting module to addons - r.sundenoise - mentor required

2009-07-03 Thread Helena Mitasova
Martin, the discussion here is not about whether to write NEW scripts as shell scripts but whether anybody who has many shell scripts will have to rewrite them into Python to be able to run them in GRASS7. Imagine you have 20 old, stable, well tested scripts doing complex workflows and a

Re: [GRASS-dev] Submitting module to addons - r.sundenoise - mentor required

2009-07-03 Thread Markus Neteler
On Fri, Jul 3, 2009 at 6:26 PM, Martin Landalanda.mar...@gmail.com wrote: 2009/7/3 Hamish hamis...@yahoo.com: In GRASS7 there is no extra support for shell scripts. This is IMO a huge, huge mistake. I do not claim that it shouldn't be possible to run shell scripts in GRASS7. Hi (just

Re: [GRASS-dev] Submitting module to addons - r.sundenoise - mentor required

2009-07-03 Thread Glynn Clements
Hamish wrote: So (IIU this C*), why should the removal of shell script support not be reverted? What does it cost us to keep shell script support?** [*] I suspect I may not. The support which has been removed is limited to the build system. If you include Script.make, the directory must

Re: [GRASS-dev] Submitting module to addons - r.sundenoise - mentor required

2009-07-03 Thread Hamish
Martin wrote: Anyway I highly suggest to write new scripts in Python, see [1]. Probably it's personal point of view, but writing shell scripts was always pain for me and I can hardly imagine person (without previous scripting experience) who prefers to learn how to write shell scripts rather

Re: [GRASS-dev] Submitting module to addons - r.sundenoise - mentor required

2009-07-03 Thread Hamish
Hamish: So (IIU this C*), why should the removal of shell script support not be reverted?  What does it cost us to keep shell script support?** [*] I suspect I may not. Glynn: The support which has been removed is limited to the build system. Thank you for the clarification; sorry

[GRASS-dev] Submitting module to addons - r.sundenoise - mentor required

2009-07-02 Thread John A Stevenson
Hi, I have written an add-on module. It is called r.sundenoise and it is for denoising/despeckling DEMs to improve the quality of slope maps and other geomorphic products derived from them. The denoising is carried out by Sun's denoising algorithm, a GPL'd mesh filtering algorithm that I