Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-14 Thread Paul Kelly
On Thu, 14 Aug 2008, Glynn Clements wrote: Do it. If a C++ header uses strcpy(), it *should* be including . What happens thereafter is a separate issue. Done now for ami_stream.h (thanks Martin) and mem_stream.h in both trunk and develbranch_6. Paul _

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-14 Thread Maciej Sieczka
Paul Kelly pisze: adding #include I have just tried it in current develbranch6. Does the trick (at leat the code compiles). Maciek -- Maciej Sieczka www.sieczka.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailm

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-13 Thread Glynn Clements
Paul Kelly wrote: > > Unfortunately I cannot reproduce the compile errors, so I cannot be of much > > help. > > I wondered if you might be able to help with advice on the C++ headers. > >From the compile errors it seems to me that the problem is a lack of a > definition for the strcpy() funct

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-13 Thread Laura Toma
I added r.viewshed to grass-addons, and deleted it from the trunk. -Laura On Aug 13, 2008, at 4:47 PM, Paul Kelly wrote: On Wed, 13 Aug 2008, Laura Toma wrote: Unfortunately I cannot reproduce the compile errors, so I cannot be of much help. I wondered if you might be able to help with

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-13 Thread Laura Toma
I added r.viewshed in grass_trunk/raster/. It compiles and works for me. Looking forward to comments. Should it maybe go in grass-addons rather than trunk for now? I could not get it to compile in the add-ons (probably i need to set up some grass parameters, etc).My understanding i

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-13 Thread Paul Kelly
On Wed, 13 Aug 2008, Laura Toma wrote: Unfortunately I cannot reproduce the compile errors, so I cannot be of much help. I wondered if you might be able to help with advice on the C++ headers. From the compile errors it seems to me that the problem is a lack of a definition for the strcpy()

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-13 Thread Laura Toma
Unfortunately I cannot reproduce the compile errors, so I cannot be of much help. I added r.viewshed in grass_trunk/raster/. It compiles and works for me. Looking forward to comments. -Laura On Aug 10, 2008, at 3:29 PM, Martin Landa wrote: Hi, 2008/8/10 Paul Kelly <[EMAIL PROTECTED]>:

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-10 Thread Martin Landa
Hi, 2008/8/10 Paul Kelly <[EMAIL PROTECTED]>: [...] > Can you explain for my benefit why you made the change to > lib/iostream/ami_stream.cc, and not to include/iostream/ami_stream.h which > is where the problem calls to strcpy seemed to be? Is it something to do > with namespaces? well, I shou

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-10 Thread Paul Kelly
Hi Martin On Sun, 10 Aug 2008, Martin Landa wrote: Hi, 2008/8/10 Paul Kelly <[EMAIL PROTECTED]>: [...] Well I know very little about C++, but a very random guess: does adding #include to include/iostream/ami_stream.h help? Obviously I can't reproduce the problem myself (gcc 4.1.2 on Slackw

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-10 Thread Martin Landa
Hi, 2008/8/10 Paul Kelly <[EMAIL PROTECTED]>: [...] > Well I know very little about C++, but a very random guess: does adding > #include > to include/iostream/ami_stream.h help? > Obviously I can't reproduce the problem myself (gcc 4.1.2 on Slackware 12.0) > or I wouldn't have committed the cha

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-10 Thread Paul Kelly
On Sat, 9 Aug 2008, Maciej Sieczka wrote: Paul Kelly pisze: r.terraflow still compiles fine so I hope there will be no unforeseen consequences. In the current develbranch6 (r32655) there are 2 errors at the build time: in lib/iostream: $ make c++ -I/home/shoofi/src/straight/grass64/dist.x8

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-09 Thread Maciej Sieczka
Paul Kelly pisze: r.terraflow still compiles fine so I hope there will be no unforeseen consequences. In the current develbranch6 (r32655) there are 2 errors at the build time: in lib/iostream: $ make c++ -I/home/shoofi/src/straight/grass64/dist.x86_64-unknown-linux-gnu/include -pipe -mar

Re: [GRASS-dev] iostream lib and r.terraflow/r.viewshed

2008-08-04 Thread Paul Kelly
On Thu, 10 Jul 2008, Glynn Clements wrote: Paul Kelly wrote: it before Will moves r.terraflow into the iostream directory as suggested by Paul. Can you provide details? Will is working on a new r.viewshed module which uses the same iostream C++ library as r.terraflow. To avoid code duplic