Re: [GRASS-dev] lib/gis/*.c: Extra calls to sprintf () just before G_warning ()

2009-03-23 Thread Glynn Clements
Ivan Shmakov wrote: > There's no need to use sprintf () along with G_warning (), since > the latter is already capable of the printf ()-style formatting. > > Also, the following are /not/ equivalent fragments of code: > >G_warning (FMT, ); > >sprintf (s, FMT, ); >

Re: [GRASS-dev] lib/gis/*.c: Extra calls to sprintf () just before G_warning ()

2009-03-23 Thread Maris Nartiss
Hello Ivan, It's good to see Your internationalisation efforts, still I spotted one huge NO-NO in Your patch - one should NEVER split strings marked for translation. Some languages may require opposite word order in sentence or even different sentence for each case. Also if translating such sentenc

[GRASS-dev] lib/gis/*.c: Extra calls to sprintf () just before G_warning ()

2009-03-22 Thread Ivan Shmakov
There's no need to use sprintf () along with G_warning (), since the latter is already capable of the printf ()-style formatting. Also, the following are /not/ equivalent fragments of code: G_warning (FMT, ); sprintf (s, FMT, ); G_warning (s); Instead, t