Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Tony Li
On Apr 16, 2012, at 5:24 PM, Christopher Morrow wrote: > If the concern is, this peer keeps sending me an update that is > unparsable, ignoring it (and logging a note/alert/etc) seems ok. If > the problem is that the neighbor did something quite wrong on the > session as a whole more immediate ac

Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Christopher Morrow
On Mon, Apr 16, 2012 at 6:01 PM, Robert Raszuk wrote: > Nope. > > This is about recognizing duplicate update which good implementation should > be able to do regardless. I think 'good implementations' don't then exist, since ... as shane/danny have presented a few times, a large percentage of upd

Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Robert Raszuk
Nope. This is about recognizing duplicate update which good implementation should be able to do regardless. Nothing to do with error itself. Regards, R. So you're going to _remember what error occurred_ Complexity++ No thanks, Tony On Apr 16, 2012, at 12:43 PM, Robert Raszuk wrote:

Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Tony Li
So you're going to _remember what error occurred_ Complexity++ No thanks, Tony On Apr 16, 2012, at 12:43 PM, Robert Raszuk wrote: > Ilya, > > I meant to say that you would increment the counter only for unique updates. > So duplicate updates with the same NLRIs would not be counted N ti

Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Robert Raszuk
Ilya, I meant to say that you would increment the counter only for unique updates. So duplicate updates with the same NLRIs would not be counted N times. > On the other hand, if a session is reset (due to errors per other > rules) there's chance that problems will occur again. Rather than > b

Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Noel Chiappa
> From: Jakob Heitz > 1. Error handling must be simple, lest we have to handle errors of the > error handling, ad infinitum... > 2. Error handling should be restricted to error isolation and > reporting. It should refrain from attempting error recovery. I'm going to agree wi

Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Jared Mauch
On Apr 16, 2012, at 7:50 AM, Jakob Heitz wrote: > This should not overwhelm a router. > However, a more serious consequence is a lot of flapping routes. > Serious enough to consider. We could dust off some dampening code for it. > > Note the previous discussion was about repeated "treat as withd

Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Jakob Heitz
This should not overwhelm a router. However, a more serious consequence is a lot of flapping routes. Serious enough to consider. We could dust off some dampening code for it. Note the previous discussion was about repeated "treat as withdraw" errors. I support the use of an operational message for

Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Rob Shakir
On 16 Apr 2012, at 04:22, Jakob Heitz wrote: > IMO > 1. Error handling must be simple, lest we have to handle errors > of the error handling, ad infinitum... > > 2. Error handling should be restricted to error isolation > and reporting. It should refrain from attempting error recovery. > > If a

Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Rob Shakir
Hi, Thanks for the feedback. On 13 Apr 2012, at 21:24, Tony Li wrote: > This may be a nit, but I think it's important to recall that UPDATE messages > include withdrawn routes. These MUST NOT be ignored by the receiver. Doing > so will simply result in forwarding loops or black holes. > > P

Re: [GROW] Repeated Errors in BGP - draft-ietf-grow-ops-reqs-for-bgp-error-handling

2012-04-16 Thread Ilya Varlashkin
Robert, > -Original Message- > Algorithm: > -- > > If such counter get's exceeded session get's reset. > > There is tracking (counter++ operation) and one additional conditional if > statement. There is no analysis what so ever. > Let's consider following scenario: a router in