[grpc-io] Re: gRFC L21: GPR API review

2018-01-25 Thread 'Vijay Pai' via grpc.io
I view the following as an interesting one. host_port.h provides two utility functions for name management: gpr_join_host_port and gpr_split_host_port . Both are used in several places inside core. They are also used in the core and C++ tests. So those are still fine with privatizing. However,

[grpc-io] Re: gRFC L21: GPR API review

2018-01-25 Thread 'Vijay Pai' via grpc.io
Thanks for the feedback! Yes, everything in alloc.h definitely stays since those are used in multiple language implementations. Same with time and logging -- all the language bindings use them heavily. I think our sync and atm also stay since they are certainly used in some of our language bind

[grpc-io] Re: gRFC L22: Change name of directory `include/grpc++` to `include/grpcxx`

2018-01-25 Thread 'Srini Polavarapu' via grpc.io
Is the reason for choosing grpcxx (vs grpc_cpp or grpc_plusplus) is so that it is inline with #ifndef GRPCXX_AAA_BBB_H usage in header files? On Thursday, January 25, 2018 at 4:44:05 PM UTC-8, Muxi Yan wrote: > > grpc.io members, > > Please review gRFC proposal L22 >

Re: [grpc-io] Is gRPC golang server able to catch the client disconnecting event and do something accordingly?

2018-01-25 Thread 'yz' via grpc.io
Thanks Eric. I get your point that the gRPC client could make multiple connections during a session. But if we use a local cache on the server, the tricky problem then becomes when the cache item should expire? On Friday, January 26, 2018 at 5:57:36 AM UTC+8, Eric Anderson wrote: > > On Tue,

[grpc-io] Re: gRFC L21: GPR API review

2018-01-25 Thread 'Christopher Warrington - MSFT' via grpc.io
> This is a proposal to curate the contents of the include/grpc/support > directory, which is the public surface of the GPR API, as many of the > entries in that API are not actually publicly needed or used. The result > will be a smaller installation and fewer API surface points. Seems reason

[grpc-io] gRFC L22: Change name of directory `include/grpc++` to `include/grpcxx`

2018-01-25 Thread 'Muxi Yan' via grpc.io
grpc.io members, Please review gRFC proposal L22 which proposes changing the header directory of gRPC C++ library from `include/grpc++` to `include/grpcxx` for compatibility issue. Let me know any q

[grpc-io] gRFC L21: GPR API review

2018-01-25 Thread 'Vijay Pai' via grpc.io
Hello grpc-io members, If you don't use gpr_ functions, you can skip this message. I have posted a new gRFC at https://github.com/grpc/proposal/pull/56/files . This is a proposal to curate the contents of the include/grpc/support directory, which is the public surface of the GPR API, as many of

Re: [grpc-io] Discarding an cancelled request

2018-01-25 Thread 'Eric Anderson' via grpc.io
Just handle the ServerCall directly. Since you don't actually need the listener, you can give a no-op one. If you need to provide additional error information, you can provide it in the Metadata. if (isCancelled) { call.close(Status.SOME_STATUS.withDescription("some description"), new Metadata()

Re: [grpc-io] What would be the steps to add Mutual TLS to this HelloWorldTLS example?

2018-01-25 Thread 'Eric Anderson' via grpc.io
This discussion was completed in https://github.com/grpc/grpc-java/issues/4004 -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+unsubscr...@googlegroups.com. T

Re: [grpc-io] Re: Is there a way for gRPC server - Go server specifically, to close the the client stream/connection?

2018-01-25 Thread 'Eric Anderson' via grpc.io
On Wed, Jan 24, 2018 at 6:49 PM, 'yz' via grpc.io wrote: > Thanks Menghan for the suggestion, but seems it does not fit our scenario > well. I noticed that and the cred config is server-wise. What we want to > achieve is to do the auth in an interceptor, so that it is configurable per > endpoint

Re: [grpc-io] Is gRPC golang server able to catch the client disconnecting event and do something accordingly?

2018-01-25 Thread 'Eric Anderson' via grpc.io
On Tue, Jan 23, 2018 at 3:44 AM, 'yz' via grpc.io wrote: > We are implementing authentication on gRPC Golang server. When a client > connect to the server, it needs to send the token to the server to > authenticate itself, and the server will save the auth info. When the > client disconnect, the

Re: [grpc-io] (golang) Detecting a dead client

2018-01-25 Thread 'Eric Anderson' via grpc.io
On Tue, Jan 23, 2018 at 3:32 AM, 'yz' via grpc.io wrote: > My concern is that if the client connection is closed, no matter > gracefully or not, the application layer might need to do some cleaning > according to the event, e.g., to remove authentication information from the > server. Haven't fin

[grpc-io] Re: How to fix client-side error: "Endpoint read failed"?

2018-01-25 Thread rkabhi1984
This part of the error log seems most relevant. It states that the socket closed and the connection is no longer valid. I don't understand why this is the case as the grpc::ClientReaderWriter object is still active after the Read/Write requests are done? D0124 16:03:06.760391000 140735208460288

[grpc-io] Discarding an cancelled request

2018-01-25 Thread vicvandamne
Hi Guys, I have a grpc service which does some cpu intensive work. Before starting the work, I want to ensure that the client hasn't cancelled this aforementioned work. Rather than checking in every service, I would like to write an interceptor which would check and drop the request if it has b

Re: [grpc-io] What would be the steps to add Mutual TLS to this HelloWorldTLS example?

2018-01-25 Thread 'Spencer Fang' via grpc.io
This should work in theory but I have not tried it myself: https://github.com/grpc/grpc-java/issues/3887#issuecomment-358415785 The post discusses the okhttp channel builder targetting android, but the netty channel builder has a similar setter for the SslContext. On Thu, Jan 25, 2018 at 7:46 AM,

[grpc-io] What would be the steps to add Mutual TLS to this HelloWorldTLS example?

2018-01-25 Thread nicholas . dipiazza
I created a new HelloWorld with TLS enabled example here: https://github.com/grpc/grpc-java/pull/3992 So far I have only configured TLS. Not mutual TLS. What would be the steps to enable Mutual Auth in this example? The script added to https://github.com/grpc/grpc-java/pull/3992/files#diff-1c

[grpc-io] Unary Stream from Python server -> C# Client, StatusCode=Unknown, Detail="Stream removed"

2018-01-25 Thread MNS
I have a unary streaming service from a Python server (1.8.4) to C# client (1.8.3). When I signal the Python to shutdown (TERM15) the shutdown method in the code listing below is called, the intention of which is to terminate the rRPCs gracefully, and shut the server down. This works when I'm

[grpc-io] Re: frequently the symbol lookup error is coming

2018-01-25 Thread subhayu . mustafi
problem with upgrading to v1.8.4 my application always crashes for whihc you have sighted to use Poll instead of epoll... On Thursday, January 25, 2018 at 12:07:58 AM UTC+5:30, Ken Payson wrote: > > Can you try upgrading to the latest gRPC (1.8.4 I believe) > > There have been significant changes