Re: bug-grub

2008-08-04 Thread Vesa Jääskeläinen
Robert Millan wrote: On Mon, Aug 04, 2008 at 10:54:19PM +0200, Marco Gerards wrote: Hi, Robert Millan <[EMAIL PROTECTED]> writes: [s/bug-grub/grub-devel/] What does everyone think? IIRC Okuji wants to remain using bug-grub for our bugs. If not, we should change this IMO. I'd like to rema

Re: [PATCH] PXE support for grub2

2008-08-04 Thread Bean
On Tue, Aug 5, 2008 at 5:08 AM, Marco Gerards <[EMAIL PROTECTED]> wrote: > Actually, I would prefer: > > pxe --info > > pxe --blksize=size > > pxe --unload > > You kinda reimplemented an argument parser. The advantage of the > build in argument parser is that it supports generation of --help > doc

Re: [PATCH] Drivemap module

2008-08-04 Thread Javier Martín
Hi there and thanks for playing The Game! El lun, 04-08-2008 a las 20:50 -0400, Isaac Dupree escribió: > Javier Martín wrote: > > You understand my concern, but seemingly do not understand that in order > > to conform to the Holy Coding Style you are asking me to write code that > > can become bug

Re: [PATCH] Drivemap module

2008-08-04 Thread Isaac Dupree
Javier Martín wrote: You understand my concern, but seemingly do not understand that in order to conform to the Holy Coding Style you are asking me to write code that can become buggy (and with a very hard to trace bug) with a simple deltion! (point: did you notice that last word _without_ a spel

Re: RFC: conf/i386.rmk

2008-08-04 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Sun, Aug 03, 2008 at 09:28:39PM +0200, Robert Millan wrote: >> >> Hi, >> >> I'm thinking that we have quite a bit of duplicate stuff in each of the 4 >> i386 ports (cpuid, pci, serial, etc) that could well live in a >> firmware-agnostic conf/i386.rm

Re: [PATCH] update-grub for Cygwin

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 10:40:02PM +0200, Christian Franke wrote: > Robert Millan wrote: > >On Mon, Aug 04, 2008 at 09:46:03PM +0200, Christian Franke wrote: > > > >>Here a more generic version which allows to specifiy windows system dirs > >>by /etc/default/grub:GRUB_WINDOWS_DIRS. > >> > >>Defa

Re: bug-grub

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 10:54:19PM +0200, Marco Gerards wrote: > Hi, > > Robert Millan <[EMAIL PROTECTED]> writes: > > [s/bug-grub/grub-devel/] > > > What does everyone think? > > IIRC Okuji wants to remain using bug-grub for our bugs. If not, we > should change this IMO. I'd like to remain u

Re: [PATCH] PXE support for grub2

2008-08-04 Thread Marco Gerards
Hi, Bean <[EMAIL PROTECTED]> writes: > This patch add the (pxe) device that can be used to load files using > the pxe service. It also add a user land command pxe that can be used > to show pxe information as well as set some parameter. Great! :-) > To create a pxe boot image: > > ./grub-mkimag

Re: bug-grub

2008-08-04 Thread Marco Gerards
Hi, Robert Millan <[EMAIL PROTECTED]> writes: [s/bug-grub/grub-devel/] > What does everyone think? IIRC Okuji wants to remain using bug-grub for our bugs. If not, we should change this IMO. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [PATCH] Drivemap module

2008-08-04 Thread Marco Gerards
Javier Martín <[EMAIL PROTECTED]> writes: > After your latest replay, I "reevaluated" my stubbornness WRT some of > your advices, and I've changed a few things: > > - Variables are now declared (and, if possible, initialized) before > precondition checks, even simple ones. The install_int13_handle

Re: [PATCH] update-grub for Cygwin

2008-08-04 Thread Christian Franke
Robert Millan wrote: On Mon, Aug 04, 2008 at 09:46:03PM +0200, Christian Franke wrote: Here a more generic version which allows to specifiy windows system dirs by /etc/default/grub:GRUB_WINDOWS_DIRS. Defaults to current SYSTEMDRIVE on Cygwin, and nothing on other OS. Christian 2008-08-04

Re: TSC on coreboot (Re: [PATCH] High resolution time/TSC patch v3)

2008-08-04 Thread Marco Gerards
Hi Robert, Robert Millan <[EMAIL PROTECTED]> writes: You forgot the changelog entry :-) > On Sun, Aug 03, 2008 at 09:48:16PM +0200, Robert Millan wrote: >> On Mon, Jul 28, 2008 at 10:05:33AM -0700, Colin D Bennett wrote: >> > +/* Calibrate the TSC based on the RTC. */ >> > +static void >> > +ca

Re: [PATCH] update-grub for Cygwin

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 09:46:03PM +0200, Christian Franke wrote: > > Here a more generic version which allows to specifiy windows system dirs > by /etc/default/grub:GRUB_WINDOWS_DIRS. > > Defaults to current SYSTEMDRIVE on Cygwin, and nothing on other OS. > > Christian > > 2008-08-04 Christi

Re: [PATCH] update-grub for Cygwin

2008-08-04 Thread Christian Franke
Christian Franke wrote: Robert Millan wrote: On Thu, Jul 24, 2008 at 10:39:04PM +0200, Christian Franke wrote: + +d="`${grub_probe} -t drive "$p" 2>/dev/null`" || exit 0 Please avoid reliing on '-t drive'. It's based on device.map which just contains guesswork. prepare_grub_to_access

Re: Current SVN is broken on x86_64

2008-08-04 Thread Pavel Roskin
On Mon, 2008-08-04 at 17:11 +0200, Robert Millan wrote: > Ok, but I think the i386->x86 rename would be overkill. We're already using > i386/ headers on x86_64 (for example, when building util/ stuff in grub-pc). > It > doesn't hurt if we continue doing that IMHO. Fine with me. -- Regards, Pa

Re: bug-grub

2008-08-04 Thread Felix Zielcke
Hello grub-devels, Am Samstag, den 19.07.2008, 16:06 +0200 schrieb Robert Millan: > Hi, > > Marco and I had an interesting discussion about bug-grub today: > > 15:54 < marco_g> nyu: Actually, I rarely look at the BTS > 15:54 < marco_g> The list is a better way to process patches, IMO. > 15:55 <

Re: [PATCH] power management on coreboot

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 01:48:33PM +0200, Robert Millan wrote: > + /* Bochs, QEMU, etc. */ > + for (p = bochs_shutdown; *p || *(p-1); p++) > +grub_outb (*p, 0x8900); Ah, mistake here. This would continue if there's a \0 after the string terminator. I guess I'll have to add an explicit cal

Re: Current SVN is broken on x86_64

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 08:51:25AM -0400, Pavel Roskin wrote: > On Mon, 2008-08-04 at 11:16 +0200, Robert Millan wrote: > > > Furthermore, I had a look and some of the x86_64 versions are just stubs > > that > > include the i386 one. > > > > Why don't we handle this like Linux? They ship a sing

Re: Current SVN is broken on x86_64

2008-08-04 Thread Pavel Roskin
On Mon, 2008-08-04 at 11:16 +0200, Robert Millan wrote: > Furthermore, I had a look and some of the x86_64 versions are just stubs that > include the i386 one. > > Why don't we handle this like Linux? They ship a single directory and use > #ifdefs where appropiate. That enforces consistency in

[PATCH] power management on coreboot

2008-08-04 Thread Robert Millan
This implements power management on coreboot. reboot is (AFAIK) fairly generic, but halt is hardware-specific (currently it only supports bochs and friends). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobod

Re: Current SVN is broken on x86_64

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 01:02:41AM -0400, Pavel Roskin wrote: > > I confirm it. And the i386-pc platform grew new warnings: > > kern/main.c: In function 'grub_set_root_dev': > kern/main.c:108: warning: implicit declaration of function 'grub_free' > loader/i386/pc/multiboot.c: In function 'grub_m

Re: Current SVN is broken on x86_64

2008-08-04 Thread Robert Millan
On Mon, Aug 04, 2008 at 02:31:28AM +0200, Felix Zielcke wrote: > I just tried to compile the Debian packages with the currently SVN > version and it failed: > > cc -Iloader/i386/efi -I/home/fz/grub/grub2-1.96+20080804/loader/i386/efi -I. > -Iinclude -I/home/fz/grub/grub2-1.96+2

Re: TSC on coreboot (Re: [PATCH] High resolution time/TSC patch v3)

2008-08-04 Thread Robert Millan
On Sun, Aug 03, 2008 at 07:14:29PM -0700, Colin D Bennett wrote: > > > > Note: AFAICT we can't calculate the epoch without RTC. But then > > again, this epoch is just as defined by the time BIOS enables RTC > > interrupts, so why not define it ourselves? I propose that we define > > epoch as th