Re: grub-install crash on GNU/Hurd

2009-11-28 Thread Samuel Thibault
Here is the patch agains, with -w Samuel === modified file 'util/grub-probe.c' --- util/grub-probe.c 2009-11-25 23:10:02 + +++ util/grub-probe.c 2009-11-29 03:30:50 + @@ -238,6 +238,8 @@ if (print == PRINT_FS) { + if (path) +{ struct stat st; stat

Re: savannah Browse Sources Repository

2009-11-28 Thread Robert Millan
On Sun, Nov 29, 2009 at 01:49:02AM +, Carles Pina i Estany wrote: > > Hello, > > >From this webpage: > https://savannah.gnu.org/projects/grub/ > > Clicking on "Browse Sources Repository" (Bazaar one) appears: > http://bzr.savannah.gnu.org/lh/grub > > I remember that last Sunday worked fine

Re: gettext.c patch: reuse memory

2009-11-28 Thread Robert Millan
On Sun, Nov 29, 2009 at 12:49:50AM +, Carles Pina i Estany wrote: > > Hello, > > This week I realised of a quite big mistake in the gettext module. Every > time that the user of this module was asking for string translation, > gettext module was allocating new memory and returning it. So if t

savannah Browse Sources Repository

2009-11-28 Thread Carles Pina i Estany
Hello, >From this webpage: https://savannah.gnu.org/projects/grub/ Clicking on "Browse Sources Repository" (Bazaar one) appears: http://bzr.savannah.gnu.org/lh/grub I remember that last Sunday worked fine but not during the week. Maybe restoring the backup on Sunday after the incorrect merge so

Re: gettext: normal_menu.c

2009-11-28 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Carles Pina i Estany wrote: > Hello, > > On Nov/28/2009, Robert Millan wrote: > >> Please remember about spaces in our coding style: >> >> On Sat, Nov 28, 2009 at 12:21:28PM +, Carles Pina i Estany wrote: >> >>> + next_new_line = (grub_uint32_t*)last_position; >>> >>

Re: gettext: normal_menu.c

2009-11-28 Thread Carles Pina i Estany
Hello, On Nov/28/2009, Robert Millan wrote: > > Please remember about spaces in our coding style: > > On Sat, Nov 28, 2009 at 12:21:28PM +, Carles Pina i Estany wrote: > > + next_new_line = (grub_uint32_t*)last_position; >^ ^ > > + while (ge

grub-install crash on GNU/Hurd

2009-11-28 Thread Samuel Thibault
Hello, grub-install crashes on GNU/Hurd on the stat call in probe(): if (print == PRINT_FS) { struct stat st; stat (path, &st); if (S_ISREG (st.st_mode)) because when grub-probe is passed --device /dev/hd0, path is NULL. This doesn't get noticed on Linux because it retu

gettext.c patch: reuse memory

2009-11-28 Thread Carles Pina i Estany
Hello, This week I realised of a quite big mistake in the gettext module. Every time that the user of this module was asking for string translation, gettext module was allocating new memory and returning it. So if the user was asking 10 times for the same string, gettext was creating 10 new strin

Re: fonts for gfxmenu, help needed

2009-11-28 Thread Qianqian Fang
Michal Suchanek wrote: Given the 1-bit bitmap limitation most glyphs look pretty good but the 灱 glyph just above the UmingCN title in the taskbar is particularly ugly. Is this an expected limitation of this rendering method that some glyphs simply turn out ugly or is this a bug in the font? o

Re: fonts for gfxmenu, help needed

2009-11-28 Thread Qianqian Fang
Michal Suchanek wrote: Am I missing something? For me fontconfig was always a commandline tool. I do use some charmap tools but onen of them comes with fontconfig. I am sorry, I meant "fontforge", not fontconfig. Those are the steps to prepare a bitmap font (in bdf format, then you can convert

Re: fonts for gfxmenu, help needed

2009-11-28 Thread Michal Suchanek
2009/11/28 Qianqian Fang : > Michal Suchanek wrote: >> >> Thanks for these tips. I guess wider by one px is acceptable for an >> alternate font, the fonts need not be displayed both at the same time. >> I am not sure if lower quality glyphs of correct shape are preferred >> over higher quality Chin

Re: Can't boot Linux on Non-Macintosh EFI laptop

2009-11-28 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Alexander Brüning wrote: > Hi, > > I've got a Clevo M860TU Notebook that comes with a Phoenix SecureCore > NB BIOS which has a legacy and an EFI mode. Windows 7 (64 Bit) boots > fine in EFI mode but I can't get GRUB2 (I tried 1.97.1 with target=efi > and arch=amd64) to work properly. Here's what I

Can't boot Linux on Non-Macintosh EFI laptop

2009-11-28 Thread Alexander Brüning
Hi, I've got a Clevo M860TU Notebook that comes with a Phoenix SecureCore NB BIOS which has a legacy and an EFI mode. Windows 7 (64 Bit) boots fine in EFI mode but I can't get GRUB2 (I tried 1.97.1 with target=efi and arch=amd64) to work properly. Here's what I did: 1.) Install Windows in EF

Re: gettext: normal_menu.c

2009-11-28 Thread Robert Millan
Please remember about spaces in our coding style: On Sat, Nov 28, 2009 at 12:21:28PM +, Carles Pina i Estany wrote: > + next_new_line = (grub_uint32_t*)last_position; ^ ^ > + while (getstringwidth(current_position,next_new_line) > line_len

Re: new function: grub_printfnl

2009-11-28 Thread Robert Millan
On Sat, Nov 28, 2009 at 11:14:09AM +, Carles Pina i Estany wrote: > > Hello, > > Gettextizzing files I have a very common situation: > grub_printf ("Bla bla bla\n"); > > That I have to change to: > grub_printf (_("Bla bla bla")); > grub_putchar ('\n'); Uhm I wonder what's the common approac

Re: gettext: --no-hash in msgmft

2009-11-28 Thread Robert Millan
On Thu, Nov 26, 2009 at 01:52:38PM +0100, Jordi Mallach wrote: > On Thu, Nov 26, 2009 at 12:31:45PM +, Colin Watson wrote: > > If nothing else, one could use something like 'msgunfmt - | msgfmt > > --no-hash -'; but I'd expect that we'd want to generate separate .mo > > files for /boot/grub any

Re: grub_halt()

2009-11-28 Thread Robert Millan
On Fri, Nov 27, 2009 at 10:24:39PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Felix Zielcke wrote: > > grub_halt is on i386-pc defined as `void grub_halt (int no_apm)' but > > everywhere else as `grub_halt (void)' > > util/grub-emu.c has a #ifdef for these 2 > > > > Shouldn't we just ad

Re: Just a cosmetic question about grub_vprintf()?

2009-11-28 Thread rubisher
Robert Millan wrote: On Sun, Nov 22, 2009 at 01:10:11PM +, rubisher wrote: But as far as the 1st parameter of grub_vsprintf is a pointer, wouldn't it be better to write: --- kern/misc.c.orig2009-11-22 13:07:22.0 + +++ kern/misc.c 2009-11-22 13:07:51.0 + @@ -160,7

Re: gettext: normal_menu.c

2009-11-28 Thread Carles Pina i Estany
Hi, I've added some easy changes for normal/menu_entry.c So better review this patch. Thanks! -- Carles Pina i Estany http://pinux.info 2009-11-28 Carles Pina i Estany * normal/menu_text.c (grub_color_menu_high): Gettexttize string. (print_spaces): New function.

new function: grub_printfnl

2009-11-28 Thread Carles Pina i Estany
Hello, Gettextizzing files I have a very common situation: grub_printf ("Bla bla bla\n"); That I have to change to: grub_printf (_("Bla bla bla")); grub_putchar ('\n'); Any problem to apply the attached patch with the export where needed (I haven't compiled, just written the idea). So I could c