[PATCH 1/1] Fix PCIe LER when GRUB2 accesses non-enabled MMIO data from VGA

2018-03-28 Thread mike.travis
A GPU inserted into a PCIe I/O slot disappears during system startup. The problem centers around GRUB and a specific VGA init function in efi_uga.c. This causes an LER (link error recorvery) because the MMIO memory has not been enabled before attempting access. The fix is to add the same coding

Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Hans de Goede
Hi, On 28-03-18 17:11, Lennart Sorensen wrote: On Wed, Mar 28, 2018 at 05:06:53PM +0200, Hans de Goede wrote: Hmm, well people will still be able to use ESC to get the grub boot menu, rather then the firmware boot-menu on those. The problem is that our current check for ESC only approach is

[GRUB PARTUUID PATCH V8 3/4] Add PARTUUID detection support to grub-probe

2018-03-28 Thread Nicholas Vinson
Add PARTUUID detection support grub-probe for MBR and GPT partition schemes. Signed-off-by: Nicholas Vinson --- util/grub-probe.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/util/grub-probe.c b/util/grub-probe.c index

[GRUB PARTUUID PATCH V8 2/4] Update grub_gpt_partentry

2018-03-28 Thread Nicholas Vinson
Rename grub_gpt_part_type to grub_gpt_part_guid and update grub_gpt_partentry to use this type for both the partition type GUID string and the partition GUID string entries. This change ensures that the two GUID fields are handled more consistently and helps to simplify the changes needed to add

[GRUB PARTUUID PATCH V8 4/4] Update grub script template files

2018-03-28 Thread Nicholas Vinson
Update grub-mkconfig.in and 10_linux.in to support grub-probe's new partuuid target. Update grub.texi documenation. Signed-off-by: Nicholas Vinson --- docs/grub.texi | 9 + util/grub-mkconfig.in | 3 +++ util/grub.d/10_linux.in | 12 +--- 3

[GRUB PARTUUID PATCH V8 0/4] Add PARTUUID detection support

2018-03-28 Thread Nicholas Vinson
Changes from Patch v7: - Changed checks in probe_partuuid() to use the variable 'p' instead of disk->partition - Moved 'disk->partition = p;' assignment to inside the 'p & p->parent == NULL' statement - Moved 'disk->partition = p->parent;' assignment to before partmap

[GRUB PARTUUID PATCH V8 1/4] Centralize guid prints

2018-03-28 Thread Nicholas Vinson
Define print_gpt_guid(), so there is a central function for printing GUID strings. This change is a precursor for later patches which rely on this logic. Signed-off-by: Nicholas Vinson Reviewed-by: Daniel Kiper --- util/grub-probe.c | 30

Re: [PATCH 0/4] Make hidden menu really hidden

2018-03-28 Thread Daniel Kiper
Hi Hans, On Wed, Mar 28, 2018 at 04:50:24PM +0200, Hans de Goede wrote: > Hi All, > > Let me start with a quick self-intro: > > I'm a FOSS enthusiast / developer working for Red Hat, my latest project > at Red Hat is chasing what has over the years become the magical unicorn > of desktop Linux

Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Lennart Sorensen
On Wed, Mar 28, 2018 at 05:06:53PM +0200, Hans de Goede wrote: > Hmm, well people will still be able to use ESC to get the grub boot > menu, rather then the firmware boot-menu on those. > > The problem is that our current check for ESC only approach is problematic > because it conflicts with the

Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Hans de Goede
Hi, On 28-03-18 16:56, Lennart Sorensen wrote: On Wed, Mar 28, 2018 at 04:50:26PM +0200, Hans de Goede wrote: On most Bay Trail, Cherry Trail and Apollo Lake devices the ESC key is the hotkey to enter the BIOS/EFI setup screen. This makes it hard for the user to show the grub-menu when it is

Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Lennart Sorensen
On Wed, Mar 28, 2018 at 04:50:26PM +0200, Hans de Goede wrote: > On most Bay Trail, Cherry Trail and Apollo Lake devices the ESC key is > the hotkey to enter the BIOS/EFI setup screen. > > This makes it hard for the user to show the grub-menu when it is hidden > and a short timeout is used,

[PATCH 3/4] Optionally print less messages at boot

2018-03-28 Thread Hans de Goede
The patch optionally makes grub not show any text (be fully quiet) when timeout_style=hidden is set and the user does not interrupt the boot. Combined with a later patch in this series which makes grub not touch the EFI console unless it actually has some text to print, this will keep the vendor

[PATCH 4/4] EFI: Do not set text-mode until we actually need it

2018-03-28 Thread Hans de Goede
If we're running with a hidden menu we may never need text mode, so do not change the video-mode to text until we actually need it. Signed-off-by: Hans de Goede --- grub-core/term/efi/console.c | 72 +++- 1 file changed, 47 insertions(+), 25

[PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Hans de Goede
On most Bay Trail, Cherry Trail and Apollo Lake devices the ESC key is the hotkey to enter the BIOS/EFI setup screen. This makes it hard for the user to show the grub-menu when it is hidden and a short timeout is used, because pressing ESC too early leads to the user entering the BIOS/EFI setup

[PATCH 1/4] Add new "version" command

2018-03-28 Thread Hans de Goede
Add a new "version" command which prints the grub PACKAGE_STRING + build time and date. This is useful to check if the expected version is running, for e.g. trouble-shooting purposes. Signed-off-by: Hans de Goede --- grub-core/kern/corecmd.c | 11 +++ 1 file

[PATCH 0/4] Make hidden menu really hidden

2018-03-28 Thread Hans de Goede
Hi All, Let me start with a quick self-intro: I'm a FOSS enthusiast / developer working for Red Hat, my latest project at Red Hat is chasing what has over the years become the magical unicorn of desktop Linux distros: a smooth graphical boot where the machine goes from the BIOS screen to the

stale comment in diskboot.S ?

2018-03-28 Thread Cao jin
Hi, I was reading the code, and I want to confirm is following comment is stale? /* * _start is loaded at 0x2000 and is jumped to with * CS:IP 0:0x2000 in kernel. */ As I understand, it is loaded at 0x8000 and is jumped to with 0:0x8000. -- Sincerely, Cao jin

Re: [PATCH] F2FS support

2018-03-28 Thread Daniel Kiper
On Thu, Mar 22, 2018 at 04:47:47PM +, Pete Batard wrote: > From 40030514e682191281e8ddba8d1e0835e6b685dc Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Thu, 4 May 2017 19:12:00 +0100 > Subject: [PATCH] F2FS support > > "F2FS (Flash-Friendly File System) is

Re: [GRUB PARTUUID PATCH V7 3/4] Add PARTUUID detection support to grub-probe

2018-03-28 Thread Daniel Kiper
On Tue, Mar 27, 2018 at 09:30:10PM -0700, Nick Vinson wrote: > On 03/27/2018 01:52 PM, Daniel Kiper wrote: > > On Mon, Mar 26, 2018 at 11:07:58PM -0700, Nicholas Vinson wrote: > >> Add PARTUUID detection support grub-probe for MBR and GPT partition > >> schemes. > >> > >> Signed-off-by: Nicholas