Hi Adrian,
you are correct, a patch fixing this issue was pending revision:
https://lists.gnu.org/archive/html/grub-devel/2019-03/msg00113.html
https://lists.gnu.org/archive/html/grub-devel/2019-03/msg00154.html
Daniel sent today a patch that fixes this.
Sorry for the inconveniences,
LGTM.
Just a note: it's a correct usage of extern, just not consistent with
rest of codebase and not supported by old gcc
On Sat, Apr 13, 2019 at 12:02 AM Daniel Kiper wrote:
>
> Some older GCC versions produce following error when x86 MSR modules are
> build:
>
> In file included from
Some older GCC versions produce following error when x86 MSR modules are build:
In file included from commands/i386/rdmsr.c:29:0:
../include/grub/i386/rdmsr.h:27:29: error: no previous prototype for
‘grub_msr_read’ [-Werror=missing-prototypes]
extern inline grub_uint64_t grub_msr_read
On Fri, Apr 12, 2019 at 07:37:47AM +0200, adrian15 wrote:
> I was able to build 2.02 back in the day in my Debian Jessie chroot.
> Now I am unable to build 2.04 RC01.
>
> So basically what I do is:
>
> git clone git://git.savannah.gnu.org/grub.git mydir
> cd mydir
>
> git reset --hard
> git
On 4/12/19 7:37 AM, adrian15 wrote:
> ./configure \
> --enable-grub-mkfont \
> --with-platform="pc" \
> --target="i386-pe" \
> --prefix \
> "/path/to/sg2d_grub_installations/hybrid/"
Try passing "--disable-werror" here.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer -
El 12/04/19 a las 07:52, Christian Hesse escribió:
> adrian15 on Fri, 2019/04/12 07:37:
>> --target="i386-pe" \
>
> No idea if it make a difference, but I guess this should read "i386-pc"?
I am building like this since 2017 and I had no problem.
Is i386-pe no longer an accepted target when