Re: [PATCH 1/3] configure: Enforce gnu99 C language standard

2020-04-02 Thread Mike Gilbert
On Thu, Apr 2, 2020 at 1:38 PM Leif Lindholm wrote: > > On Thu, Apr 02, 2020 at 19:08:21 +0200, Daniel Kiper wrote: > > > > -# Optimization flag. Allow user to override. > > > > +if test "x$BUILD_CFLAGS" = x; then > > > > + BUILD_CFLAGS='-std=gnu99' > > > > +fi > > > > + > > > > +if test

Re: does grub2 support proxy dhcp?

2020-04-02 Thread Olaf Hering
Am Thu, 2 Apr 2020 19:39:49 +0200 schrieb Daniel Kiper : > I use such configuration an UEFI platform and it works without any > issue. However, pxelinux.0 above suggests that you are playing with > legacy BIOS PC platform. This may depend on the firmware. With two BIOS systems grub does not load

Re: does grub2 support proxy dhcp?

2020-04-02 Thread Daniel Kiper
On Wed, Apr 01, 2020 at 11:08:07PM +0200, Thomas Frauendorfer wrote: > Hi Olaf, > > Current Grub does not handle proxy DHCP correctly. > There is a patch to add support for proxy DHCP in the mailing list > archives, but it was never merged. > I did some adjustments to make it apply to 2.04 for

Re: [PATCH 1/3] configure: Enforce gnu99 C language standard

2020-04-02 Thread Leif Lindholm
On Thu, Apr 02, 2020 at 19:08:21 +0200, Daniel Kiper wrote: > > > -# Optimization flag. Allow user to override. > > > +if test "x$BUILD_CFLAGS" = x; then > > > + BUILD_CFLAGS='-std=gnu99' > > > +fi > > > + > > > +if test "x$HOST_CFLAGS" = x; then > > > + HOST_CFLAGS='-std=gnu99' > > > +fi > > >

Re: NVMe support

2020-04-02 Thread Daniel Kiper
On Tue, Mar 31, 2020 at 12:40:23AM +0200, Christian E. Jørgensen wrote: > Am I correct in assuming that GRUB relies on something like a BIOS for > support of NVMe devices? I'm running coreboot with GRUB as the payload > (on amd64 hardware) and GRUB does not seem to detect my NVMe device. > > If I

Re: [PATCH 1/3] configure: Enforce gnu99 C language standard

2020-04-02 Thread Eli Schwartz
On 4/2/20 1:08 PM, Daniel Kiper wrote: >> Would we not want to override these always? >> >> For example, Debian/Ubuntu override HOST_CFLAGS when building grub. > > I was not sure about it. So, after some thinking I decided to give > a user a chance to override C language type using *_CFLAGS.

Re: [PATCH 1/3] configure: Enforce gnu99 C language standard

2020-04-02 Thread Daniel Kiper
On Thu, Apr 02, 2020 at 05:28:33PM +0100, Leif Lindholm wrote: > On Thu, Apr 02, 2020 at 17:07:48 +0200, Daniel Kiper wrote: > > Commit d5a32255d (misc: Make grub_strtol() "end" pointers have safer > > const qualifiers) introduced "restrict" keyword into some functions > > definitions. This

Re: [PATCH 1/3] configure: Enforce gnu99 C language standard

2020-04-02 Thread Leif Lindholm
On Thu, Apr 02, 2020 at 17:07:48 +0200, Daniel Kiper wrote: > Commit d5a32255d (misc: Make grub_strtol() "end" pointers have safer > const qualifiers) introduced "restrict" keyword into some functions > definitions. This keyword was introduced in C99 standard. However, some > compilers by default

[PATCH 3/3] autogen: Replace -iname with -ipath in find command

2020-04-02 Thread Daniel Kiper
..because -iname cannot be used to match paths. Signed-off-by: Daniel Kiper --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index ef43270fc..31b0ced7e 100755 --- a/autogen.sh +++ b/autogen.sh @@ -13,7 +13,7 @@ fi export LC_COLLATE=C

[PATCH 2/3] INSTALL/configure: Update install doc and configure comment

2020-04-02 Thread Daniel Kiper
..to reflect the GRUB build reality in them. Additionally, fix ./configure command example formatting in INSTALL file. Signed-off-by: Daniel Kiper --- INSTALL | 51 +++ configure.ac | 10 ++ 2 files changed, 33 insertions(+), 28

[PATCH 1/3] configure: Enforce gnu99 C language standard

2020-04-02 Thread Daniel Kiper
Commit d5a32255d (misc: Make grub_strtol() "end" pointers have safer const qualifiers) introduced "restrict" keyword into some functions definitions. This keyword was introduced in C99 standard. However, some compilers by default may use C89 or something different. This behavior leads to the

[PATCH 0/3] Various build and doc fixes

2020-04-02 Thread Daniel Kiper
Hey, As in subject... Please review... Daniel INSTALL | 51 +++ autogen.sh | 2 +- configure.ac | 21 +++-- 3 files changed, 43 insertions(+), 31 deletions(-) Daniel Kiper (3): configure: Enforce gnu99 C language

Re: [PATCH] multiboot2: enable quirk-modules-after-kernel

2020-04-02 Thread Paul Menzel
Dear Zide, Thank you very much for your patch. Am 26.03.20 um 23:46 schrieb Zide Chen: In multiboot2, currently there is no way to control where to load the modules. In case of user wants to reserve low address for specific usage, this quirk is useful. It’d be great if you elaborated, where