Re: [PATCH v4 1/2] cryptodisk: add OS provided secret support

2022-02-25 Thread Glenn Washburn
Finally getting back to this... On Thu, 17 Feb 2022 17:18:47 -0500 James Bottomley wrote: > On Mon, 2022-02-14 at 16:18 -0600, Glenn Washburn wrote: > > On Mon, 7 Feb 2022 10:29:43 -0500 > > James Bottomley wrote: > > > > > Make use of the new OS provided secrets API so that if the new '-s'

GRUB PXE not requesting formatted configs automatically

2022-02-25 Thread Robert LeBlanc
I've been struggling with getting GRUB PXE to request the automatic list of config files, but nothing is working (I'm sniffing the network traffic). I can get GRUB to load the config just fine if I specify ``` configfile (tftp,192.168.100.10)/grub.cfg/$net_pxe_mac ``` in an embedded config file.

[PATCH v2] misc: Fix whitespace formatting

2022-02-25 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 246 +-- 1 file changed, 123 insertions(+), 123 deletions(-) diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in index a1f3f299b4..65633c7f81 100644 ---

Re: [PATCH] misc: Fix whitespace formatting

2022-02-25 Thread Daniel Kiper
On Fri, Feb 25, 2022 at 02:56:11PM -0600, Glenn Washburn wrote: > On Tue, 22 Feb 2022 14:49:39 +0100 > Daniel Kiper wrote: > > > On Tue, Feb 15, 2022 at 12:44:44PM -0600, Glenn Washburn wrote: > > > Signed-off-by: Glenn Washburn > > > --- > > > Daniel, > > > > > > I think I recall you saying you

Re: [PATCH 2/3] mm: Export grub_mm_dump and grub_mm_dump_free

2022-02-25 Thread Glenn Washburn
On Tue, 22 Feb 2022 19:03:39 +0100 Daniel Kiper wrote: > On Tue, Feb 15, 2022 at 12:36:42PM -0600, Glenn Washburn wrote: > > These functions may be useful within modules as well. Export them so that > > modules can use them. > > Though there are no users for these functions today. So, I am not

Re: [PATCH] misc: Fix whitespace formatting

2022-02-25 Thread Glenn Washburn
On Tue, 22 Feb 2022 14:49:39 +0100 Daniel Kiper wrote: > On Tue, Feb 15, 2022 at 12:44:44PM -0600, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > --- > > Daniel, > > > > I think I recall you saying you accumulate whitespace fixes. So here's a > > Yeah... Sadly it looks it will not

Re: [PATCH] Retire ChangeLog-2015

2022-02-25 Thread Peter Jones
On Fri, Feb 25, 2022 at 01:03:48PM +0100, Daniel Kiper wrote: > On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote: > > Hello Peter, > > > > Thanks a lot for your patch. > > > > On 2/24/22 22:55, Peter Jones wrote: > > > ChangeLog-2015 has been untouched for over 7 years now,

Re: [PATCH] Retire ChangeLog-2015

2022-02-25 Thread Javier Martinez Canillas
Hello Daniel, On 2/25/22 13:03, Daniel Kiper wrote: > On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote: >> Hello Peter, >> >> Thanks a lot for your patch. >> >> On 2/24/22 22:55, Peter Jones wrote: >>> ChangeLog-2015 has been untouched for over 7 years now, and any >>>

Re: [PATCH v3 1/2] lsefi: fixed memory leaks

2022-02-25 Thread Renaud Métrich
Right, sorry for that! The patch was brought in RH grub (g...@github.com:rhboot/grub2.git) by pjones in 2017: commit c925abf2462e30ac76cba760e727fb953daf1aeb Author: Peter Jones Date:   Thu Jun 1 09:59:56 2017 -0400     Add grub_efi_allocate_pool() and grub_efi_free_pool() wrappers.    

[PATCH v4 3/3] search: new --efidisk-only option on EFI systems

2022-02-25 Thread Renaud Métrich
When using 'search' on EFI systems, we sometimes want to exclude devices that are not EFI disks (e.g. md, lvm). This is typically used when wanting to chainload when having a software raid (md) for EFI partition: with no option, 'search --file /EFI/redhat/shimx64.efi' sets root envvar to

[PATCH v4 1/3] search: fixed bug stopping iteration when --no-floppy is used

2022-02-25 Thread Renaud Métrich
When using --no-floppy and a floppy was encountered, iterate_device() was returning 1, causing the iteration to stop instead of continuing. Signed-off-by: Renaud Métrich --- grub-core/commands/search.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 2/3] search: refactor --no-floppy option to have something generic

2022-02-25 Thread Renaud Métrich
Signed-off-by: Renaud Métrich --- grub-core/commands/search.c | 8 grub-core/commands/search_wrap.c | 13 +++-- include/grub/search.h| 14 +++--- 3 files changed, 22 insertions(+), 13 deletions(-) diff --git a/grub-core/commands/search.c

Re: [PATCH] Retire ChangeLog-2015

2022-02-25 Thread Daniel Kiper
On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote: > Hello Peter, > > Thanks a lot for your patch. > > On 2/24/22 22:55, Peter Jones wrote: > > ChangeLog-2015 has been untouched for over 7 years now, and any > > information in it is purely for historical purposes. At the

Re: [PATCH] Retire ChangeLog-2015

2022-02-25 Thread Javier Martinez Canillas
Hello Peter, Thanks a lot for your patch. On 2/24/22 22:55, Peter Jones wrote: > ChangeLog-2015 has been untouched for over 7 years now, and any > information in it is purely for historical purposes. At the same time, > grepping for code winds up matching this file quite a bit, almost never >