Re: [PATCH v14 20/20] tests: Add tpm2_test

2024-05-08 Thread Gary Lin via Grub-devel
On Wed, May 08, 2024 at 03:25:29PM -0500, Glenn Washburn wrote: > On Tue, 7 May 2024 16:19:19 +0800 > Gary Lin wrote: > > > On Mon, May 06, 2024 at 02:09:12PM -0500, Glenn Washburn wrote: > > > On Fri, 3 May 2024 14:48:56 +0800 > > > Gary Lin wrote: > > > > > > > For the tpm2 module, the TCG2

Re: [PATCH v14 20/20] tests: Add tpm2_test

2024-05-08 Thread Glenn Washburn
On Tue, 7 May 2024 16:19:19 +0800 Gary Lin wrote: > On Mon, May 06, 2024 at 02:09:12PM -0500, Glenn Washburn wrote: > > On Fri, 3 May 2024 14:48:56 +0800 > > Gary Lin wrote: > > > > > For the tpm2 module, the TCG2 command submission function is the only > > > difference between the a QEMU inst

Rotation WIP status

2024-05-08 Thread Kyle Bader
Good afternoon grub devs, I see phcoder has a branch for the framebuffer rotation, with latest commit labeled WIP. The branch is quite dated now so I'm willing to assume work has stalled on this branch? I'm just wondering if there are any plans to implement this feature into future releases? I had

[PATCH v2] util/grub.d/30_os-prober.in: Fix GRUB_OS_PROBER_SKIP_LIST for non-EFI

2024-05-08 Thread Pascal Hambourg
GRUB documentation states: ‘GRUB_OS_PROBER_SKIP_LIST’ List of space-separated FS UUIDs of filesystems to be ignored from os-prober output. For efi chainloaders it’s @ But the actual behaviour does not match this description. GRUB_OS_PROBER_SKIP_LIST="" does nothing. In order to skip non-E

Re: Release signing key still uses SHA1

2024-05-08 Thread Daniel Kiper
On Fri, Apr 26, 2024 at 12:13:21AM +0200, Marek Marczykowski-Górecki wrote: > On Thu, Apr 25, 2024 at 11:27:53PM +0200, Daniel Kiper wrote: > > Hey, > > > > On Tue, Mar 12, 2024 at 05:13:24AM +0100, Marek Marczykowski-Górecki wrote: > > > Hi, > > > > > > The key used to sign release tarballs and gi

Re: [PATCH] efi: mm: Fix incorrect free size

2024-05-08 Thread Daniel Kiper via Grub-devel
Your patch makes sens but the commit message is wrong. In general we will be leaking memory for short time. Not big deal here but worth fixing. The memory will not be freed twice as you say in the commit message. May I ask you to fix the commit message? On Tue, Apr 23, 2024 at 09:04:34AM +0800, Zh

Re: [PATCH v5] efi: Fix stack protector issues

2024-05-08 Thread Daniel Kiper
On Mon, Apr 29, 2024 at 03:03:50PM +0200, Ard Biesheuvel wrote: > On Sat, 27 Apr 2024 at 15:08, Glenn Washburn > wrote: > > > > From: Ard Biesheuvel > > > > The 'ground truth' stack protector cookie value is kept in a global > > variable, and loaded in every function prologue and epilogue to stor

Re: [PATCH] lvm: Grub2 fails to detect LVM volumes due to an incorrect computation of mda_end

2024-05-08 Thread Daniel Kiper via Grub-devel
Adding Marta... On Mon, May 06, 2024 at 03:18:45PM -0500, Glenn Washburn wrote: > From: Rogier > > When handling a regular LVM volume, Grub can fail with the message: > error: disk `lvmid/**------ > /**------**' not found. > > If the conditi

Re: [PATCH v5] cryptodisk: allow user to retry failed passphrase

2024-05-08 Thread Daniel Kiper via Grub-devel
On Mon, May 06, 2024 at 05:07:30PM -0700, Forest wrote: > Give the user a chance to re-enter their cryptodisk passphrase after a typo, > rather than immediately failing (and likely dumping them into a grub shell). > > By default, we allow 3 tries before giving up. A value in the > cryptodisk_passph