Re: [PATCH v11 1/2] fs/erofs: Add support for EROFS

Hi Daniel, On 2024/5/17 08:34, Gao Xiang wrote: Hi Daniel, On 2024/5/17 05:33, Daniel Kiper wrote: On Fri, May 10, 2024 at 08:52:55AM +0800, Gao Xiang wrote: ... In general patch LGTM except some nits... Thanks for the comments.  Let me address them. I've addressed your comments as a

[PATCH v12 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

From: Yifan Zhao In this patch, three tests of EROFS are introduced and they cover compact, extended and chunk-based inodes, respectively. Signed-off-by: Yifan Zhao Reviewed-by: Glenn Washburn Reviewed-by: Daniel Kiper Signed-off-by: Gao Xiang --- .gitignore | 1 + Makefi

[PATCH v12 1/2] fs/erofs: Add support for EROFS

From: Yifan Zhao EROFS [1] is a lightweight read-only filesystem designed for performance which has already been shipped in most Linux distributions as well as widely used in several scenarios, such as Android system partitions, container images, and rootfs for embedded devices. This patch bring

[PATCH v12 0/2] Introduce EROFS support

Hi folks, EROFS [1] is a lightweight read-only filesystem designed for performance which has already been shipped in most Linux distributions as well as widely used in several scenarios, such as Android system partitions, container images, and rootfs for embedded devices. This patch brings EROFS

Re: [PATCH v11 1/2] fs/erofs: Add support for EROFS

Hi Daniel, On 2024/5/17 05:33, Daniel Kiper wrote: On Fri, May 10, 2024 at 08:52:55AM +0800, Gao Xiang wrote: ... In general patch LGTM except some nits... Thanks for the comments. Let me address them. --- Tested-by Link: https://lists.gnu.org/archive/html/grub-devel/2024-05/msg

Re: [PATCH v11 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

On 2024/5/17 05:37, Daniel Kiper wrote: On Fri, May 10, 2024 at 08:52:56AM +0800, Gao Xiang wrote: From: Yifan Zhao In this patch, three tests of EROFS are introduced and they cover compact, extended and chunk-based inodes, respectively. Signed-off-by: Yifan Zhao Reviewed-by: Glenn Washbur

[PATCH] Add commands for reading and writing raw bytes to CMOS

With some coreboot configs setting a byte to a magic value changes behaviour on next boot. Setting bit-by-bit is possible but not convenient. Add cmosread and cmoswrite for convenience. Signed-off-by: Vladimir Serbinenko --- grub-core/commands/i386/cmostest.c | 72 +-

Re: [PATCH 2/2 v2] LVM Cachevol and Integrity volumes break entire LVM VG

Patrick, On Thu, May 16, 2024 at 03:38:17PM -0400, Patrick Plenefisch wrote: > Daniel, > > I haven't heard any update about my patch from you since early February. Is > there anything I need to do or is this good to go? I'm not too familiar with > actually submitting patches to mailing-list based

Re: [PATCH v11 2/2] fs/erofs: Add tests for EROFS in grub-fs-tester

On Fri, May 10, 2024 at 08:52:56AM +0800, Gao Xiang wrote: > From: Yifan Zhao > > In this patch, three tests of EROFS are introduced and they cover > compact, extended and chunk-based inodes, respectively. > > Signed-off-by: Yifan Zhao > Reviewed-by: Glenn Washburn > Signed-off-by: Gao Xiang R

Re: [PATCH v11 1/2] fs/erofs: Add support for EROFS

On Fri, May 10, 2024 at 08:52:55AM +0800, Gao Xiang wrote: > From: Yifan Zhao > > EROFS [1] is a lightweight read-only filesystem designed for performance > which has already been shipped in most Linux distributions as well as widely > used in several scenarios, such as Android system partitions,

[PATCH] Implement fmap support as used by coreboot

This patch limits itself to fmap coming from booted coreboot, not as used in images. Signed-off-by: Vladimir Serbinenko --- grub-core/Makefile.core.def | 7 ++ grub-core/partmap/fmap.c| 172 2 files changed, 179 insertions(+) create mode 100644 grub-co

[PATCH 2/2] Add test for zfs zstd

Signed-off-by: Vladimir Serbinenko --- tests/util/grub-fs-tester.in | 2 +- tests/zfs_test.in| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in index ea8b2d1f6..f0451ecd9 100644 --- a/tests/util/grub-fs-test

[PATCH 1/2] zfs: Support zstd compression

Signed-off-by: Vladimir Serbinenko --- grub-core/Makefile.core.def | 1 + grub-core/fs/zfs/zfs.c | 32 include/grub/zfs/zio.h | 1 + 3 files changed, 34 insertions(+) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 8e1b1d9

Re: [PATCH 2/2 v2] LVM Cachevol and Integrity volumes break entire LVM VG

Daniel, I haven't heard any update about my patch from you since early February. Is there anything I need to do or is this good to go? I'm not too familiar with actually submitting patches to mailing-list based development, so let me know if everything is all set or I need to do something else. T

[PATCH 3/3] grub_unicode_destroy_glyph: Don't destroy NULL glyph

This is more in-line with free() behaviour. Signed-off-by: Vladimir Serbinenko --- include/grub/unicode.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/grub/unicode.h b/include/grub/unicode.h index 9360b0b97..9a3a1d02a 100644 --- a/include/grub/unicode.h +++ b/include/grub/unicod

[PATCH 2/3] Don't attempt to do terminal functions on non-functional gfxterm

Attempting to do anything easily leads to a crash Signed-off-by: Vladimir Serbinenko --- grub-core/term/gfxterm.c | 12 1 file changed, 12 insertions(+) diff --git a/grub-core/term/gfxterm.c b/grub-core/term/gfxterm.c index e8734a388..6513a529b 100644 --- a/grub-core/term/gfxterm.c

[PATCH 1/3] Decrease minimal gfxterm size to 10x6

10x6 is still marginally usable. Erroring out may leave user without any console Signed-off-by: Vladimir Serbinenko --- grub-core/term/gfxterm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/grub-core/term/gfxterm.c b/grub-core/term/gfxterm.c index addad5ee2..e8734a3

[PATCH 3/3] Improve font fallback scanning and validation for gfxterm

Choosing a font which is too large breaks gfxterm. Be more diligent in font choice. This being said it's better to specify the correct font explicitly in config when several fonts are loaded. Signed-off-by: Vladimir Serbinenko --- grub-core/gfxmenu/view.c | 7 + grub-core/term/gfxterm.c | 5

[PATCH 2/3] gfxmenu: Add missing error handling

We don't currently handle errors from gfxterm Signed-off-by: Vladimir Serbinenko --- grub-core/gfxmenu/view.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/grub-core/gfxmenu/view.c b/grub-core/gfxmenu/view.c index e02eba8b0..19d3f2f14 100644 --- a/grub-core/gfxmenu/view

[PATCH 1/3] Add grub_font_get_no_fallback

This allows the caller to handle the fallback Signed-off-by: Vladimir Serbinenko --- grub-core/font/font.c | 21 - include/grub/font.h | 2 ++ 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/grub-core/font/font.c b/grub-core/font/font.c index 18de52562..ea0

[PATCH] Mark vdev_zaps_v2 and head_errlog as supported

We don't need any actual adjustments as we don't use the affected structures Signed-off-by: Vladimir Serbinenko --- grub-core/fs/zfs/zfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/fs/zfs/zfs.c b/grub-core/fs/zfs/zfs.c index b5453e006..dbe4ea503 100644 --- a/grub-core/fs/zf

[PATCH] Add missing cast in compile-time byteswaps

Without them 0x80LL is 32-bit byte-swapped to 0x8000 instead of correct 0x8000 Signed-off-by: Vladimir Serbinenko --- include/grub/types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/grub/types.h b/include/grub/types.h index 064066e2e..45079bf6

[PATCH] Add convenience TARGET_CROSS

This allows to set up cross environment with just 3 parameters: target, platform and TARGET_CROSS Signed-off-by: Vladimir Serbinenko --- configure.ac | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 84a202c6e..cacbdb6ef 100644 --- a

[PATCH] Add Fedora-specific font paths

Signed-off-by: Vladimir Serbinenko --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 84a202c6e..c76a29af4 100644 --- a/configure.ac +++ b/configure.ac @@ -1847,7 +1847,7 @@ if test "x$with_dejavufont" = x; then # search i

[PATCH 2/2] Support qcow in grub-fstest

Signed-off-by: Vladimir Serbinenko --- util/grub-fstest.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/util/grub-fstest.c b/util/grub-fstest.c index 7ff9037b8..3c4fa26c6 100644 --- a/util/grub-fstest.c +++ b/util/grub-fstest.c @@ -383,12 +383,14 @@ static int cm

[PATCH 1/2] Support qcow disks in GRUB

Signed-off-by: Vladimir Serbinenko --- Makefile.util.def | 1 + grub-core/Makefile.core.def | 6 + grub-core/commands/nativedisk.c | 1 + grub-core/disk/qcow.c | 464 include/grub/disk.h | 1 + 5 files changed, 473 i

[PATCH] Implement NVMe native disk support

This is useful 2-fold: 1) On coreboot port it allows to boot from NVMe devices 2) On older systems you can install NVMe via PCIe adapter and boot from it Signed-off-by: Vladimir Serbinenko --- grub-core/Makefile.core.def | 6 + grub-core/commands/nativedisk.c | 3 +- grub-core/disk/nv

[PATCH] Add --noefistub option for linux

In some cases like loading kernel from native disk (e.g. nvme) not supported by EFI in question efi stub is not an option. Allow user to disable efi stub and fallback to older protocol --- grub-core/loader/efi/linux.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gr

[PATCH] bfs: Fix improper free() on non-existing files

Signed-off-by: Vladimir Serbinenko --- grub-core/fs/bfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/fs/bfs.c b/grub-core/fs/bfs.c index 07cb3e3ac..9bc478ce8 100644 --- a/grub-core/fs/bfs.c +++ b/grub-core/fs/bfs.c @@ -808,7 +808,7 @@ find_file (const char *path

[PATCH 0/3] Upgrade to libgcrypt 1.10.3

This series of patches upgrades to libgcrypt 1.10.3 First one just imports libgcrypt tarball as-is Second one updates import script Third one add a small adjustments to make it work with GRUB x64 -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel

[PATCH 2/3] Adjust import script, definitions and API users for libgcrypt 1.10

--- autogen.sh | 1 + conf/Makefile.common | 4 +- grub-core/Makefile.core.def| 36 +- grub-core/commands/hashsum.c | 2 +- grub-core/commands/legacycfg.c | 6 +- grub-core/commands/pgp.c

[PATCH 3/3] keccak: Disable acceleration with SSE asm

--- grub-core/lib/libgcrypt/cipher/keccak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/lib/libgcrypt/cipher/keccak.c b/grub-core/lib/libgcrypt/cipher/keccak.c index 11e64b3e7..8b570263b 100644 --- a/grub-core/lib/libgcrypt/cipher/keccak.c +++ b/grub-core/lib/lib

Re: [REGRESSION] Re: [PATCH v4 5/5] efi: Use generic EFI loader for x86_64 and i386

On Thu, 16 May 2024 at 14:24, Jan Čermák wrote: > > Hi Ard, everyone, > > On 23. 05. 23 17:31, Ard Biesheuvel wrote: > > Switch the x86 based EFI platform builds to the generic EFI loader, > > ... > > We use GRUB as the loader for the Home Assistant Operating System (based > on Buildroot, using

[REGRESSION] Re: [PATCH v4 5/5] efi: Use generic EFI loader for x86_64 and i386

Hi Ard, everyone, On 23. 05. 23 17:31, Ard Biesheuvel wrote: > Switch the x86 based EFI platform builds to the generic EFI loader, > ... We use GRUB as the loader for the Home Assistant Operating System (based on Buildroot, using mostly unpatched GRUB 2 build [1]) and after updating to the lat