Re: Fwd: Your contributions to grub.enbug.org

ould you agree to consider that your > contributor agreement covers wiki as well? > > -- > Regards > Vladimir '??-coder/phcoder' Serbinenko > > > > > > _______ > Grub-devel mailing li

Re: New translation template for grub?

heers, On Dec/19/2010, Aron Xu wrote: > Hello, > > I recently read there are ~270 new strings appear in grub's template, > so will there be a new template for translators? or it is too early > because the strings is still unstable? > > -- > Regards, > Aron Xu

Re: Plans on 1.99 release

g after that, I'll try to catchup and make the required changes. Probably more news soon. -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: gnulib argp

Hi, On Jul/28/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > On 07/24/2010 12:59 AM, Carles Pina i Estany wrote: > > Hello, > > > > Some time ago we talked about importing argp (to make it easier to add > > gettext support for the --help strings): >

Re: gnulib argp

but I cannot find it. Cheers, -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: escape strings in grub.cfg

tch based on this to trunk, and I'll > backport it to Ubuntu Lucid shortly as well. Testing welcome! thanks Colin, I'll do some tests as well. -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

escape strings in grub.cfg

l fail if the path has spaces. I'll address it in the future. PS2: I haven't checked the patch yet, let's comment on the idea. Before committing I would write the changelog and check it. -- Carles Pina i Estany http://pinux.info === modified file 'util/g

Re: gettext util

Hello, On Mar/28/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > Carles Pina i Estany wrote: > > b) Makes the alignment more difficult > > > Why not just do like > > " -h, --help%s\n" > " -V, --version

Re: gettext util

Hi, On Mar/27/2010, Colin Watson wrote: > On Sat, Mar 27, 2010 at 09:42:37PM +0000, Carles Pina i Estany wrote: > > I have not seen any program (again, yet, maybe Grub will be the first > > one) to split the messages in this way. > > man-db does this, and it's fantast

Re: gettext util

Hi, On Mar/27/2010, Jordi Mallach wrote: > On Sat, Mar 27, 2010 at 12:54:16AM +0000, Carles Pina i Estany wrote: > > > According to gettext manual usage messages must be internationalised on > > > per-option basis to allow reuse of e.g. --help desciption and to avoid > &

Re: gettext util

Hi, On Mar/27/2010, Carles Pina i Estany wrote: > > According to gettext manual usage messages must be internationalised on > > per-option basis to allow reuse of e.g. --help desciption and to avoid > > the whole big message to be marked as fuzzy if only one option changes.

Re: gettext util

Hello, On Mar/26/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > Carles Pina i Estany wrote: > > Hello, > > > > Last January I asked for ok to commit this to trunk: > > http://lists.gnu.org/archive/html/grub-devel/2010-01/msg00373.html > > > &g

gettext util

ached patch. Do I commit? I cannot remember if with this patch was absolutely everything gettextizzed in utils, I'll review when it's done. I have the feeling that I left something that may require some discussion. Thanks, -- Carles Pina i Estany http://pinux.info === modified

keyboard layouts

r reason :-/ I'll do the changes when we will agree. Cheers, -- Carles Pina i Estany http://pinux.info === added file 'ChangeLog.keyboard_layouts' --- ChangeLog.keyboard_layouts 1970-01-01 00:00:00 + +++ ChangeLog.keyboard_layouts 2010-02-13 23:49:34 +0000 @@ -0,0 +1

Re: [PATCH] Fix locale installation

Hello, On Mar/19/2010, Colin Watson wrote: > On Fri, Mar 19, 2010 at 08:35:23PM +0000, Carles Pina i Estany wrote: > > On Mar/19/2010, Colin Watson wrote: > > > # Copy gettext files > > > mkdir -p ${grubdir}/locale/ > > > -for file in ${grubdir}/loca

Re: [PATCH] Fix locale installation

/grub.mo. What am I missing? It has been a while that I have not done these things, so sorry to be more an "askwer" than "answerer". -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Broken build

:-) Thanks for the report, -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Add missing dependencies to INSTALL

erywhere. -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Lead-up message 'Welcome to GRUB!' inverted text printed lowlevel via BIOS ?!?

Hi, On Feb/23/2010, edgar.sol...@web.de wrote: > He never stated why he wanted it exactly. Maybe he just want's not to > confuse an everyday user. or just for fun :-) -- Carles Pina i Estany http://pinux.info ___ Grub-devel m

avoid possible overflow?

not happen. Thanks, -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2010-02-13 15:48:22 + +++ ChangeLog 2010-02-14 00:02:48 + @@ -1,3 +1,8 @@ +2010-02-13 Carles Pina i Estany + + * gettext/gettext.c (grub_gettext_translate): Avoids p

keyboard_layouts AT and USB

a bit but splitted with keyboard_layouts.c, at_keyboard_layouts.c and usb_keyboard_layouts.c plus the changes needed in term/usb_keyboard.c (not lot of changes). -- Carles Pina i Estany http://pinux.info === added file 'ChangeLog.keyboard_layouts' --- ChangeLog.keyboard_layouts

keyboard layouts

you again. Cheers, -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Simplified Chinese screenshots

Hi, On Feb/01/2010, Chris Jones wrote: > On Mon, Feb 01, 2010 at 04:32:14PM EST, Carles Pina i Estany wrote: > > > > Hi, > > > > Aron Xu sent me some screenshots of Grub booting time in Chinese: > > > > http://carles.lastdot.org/Screenshot-QEMU.png &

Simplified Chinese screenshots

usual for me :-) (Yes, I know that Russian is there too) As Aron said: the font size is not constant, so we should fix it in some point. Cheers, -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http

Re: The next TestGettext step?

worked fine, but of course, but it was with another Ubuntu or Debian. Thanks! -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: The next TestGettext step?

don't need to umount it. could you try everything under "Steps", not using sudo, not installing Grub? Which distribution do you use? Have you used qemu for something else? (that you would have some special qemu configuration). The iso file should be generated

at_keyboard_layout

Hello, I've modified a bit the patch keyboard_layout.patch. Should apply to last trunk, plus it's called at_keyboard_layout. And the exported variable is in at_keyboard and not in kernel. Comments? Thanks, -- Carles Pina i Estany http://pinux.info ===

Re: gettext util/*

On Jan/27/2010, Carles Pina i Estany wrote: > > Hi, > > Here is the first patch to gettextizze strings in util/* (well, before > some things has been done). Now with the patch attached. -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog'

gettext util/*

width %d\n"), I'm fine to leave it out. It gettexts mainly everything but not grub_util_error / grub_util_info calls, waiting how we handle it (to be discussed later in another thread). Any feedback? Thanks, -- Carles Pina i Estany http://pinux.info

Re: macrofy fontcontants

Hi, On Jan/26/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > Evgeny Kolesnikov wrote: > > On Mon, 2010-01-25 at 23:07 +0000, Carles Pina i Estany wrote: > > > > > >> Find attached a way to macrofy the constants from font files between > >&g

Re: Antialiased fonts patch.

y > 1024x768 which is stretched to 1280x800, it won't have any effect. > Hence you need to port native drivers to grub. I understand and agree. -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

macrofy fontcontants

Hello, Find attached a way to macrofy the constants from font files between util and grub kernel. Comments, name changes, etc. are welcomed. -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2010-01-25 17:04:22 + +++ ChangeLog 2010-0

Re: comment about grub_error, capitalisation and one commit

Hi, On Jan/24/2010, Robert Millan wrote: > On Wed, Jan 20, 2010 at 11:37:38PM +0000, Carles Pina i Estany wrote: > > a) if someone has a better idea to avoid this mistake again than paying > > attention I can implement. > > b) Robert: I reverse it, fine? > > I jus

comment about grub_error, capitalisation and one commit

ion I can implement. b) Robert: I reverse it, fine? Cheers, -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

handling "/"

gs that has been patching and unpatching today. Just asking/commenting to know. -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: keyboard layout patches

Hi, On Jan/20/2010, Robert Millan wrote: > On Mon, Jan 18, 2010 at 07:25:37PM +0000, Carles Pina i Estany wrote: > > > Also keyboard_layouts is pretty small. Perhaps we can just make > > > *_keyboard depend on it and put US keyboard into it as default and shave > >

Re: keyboard layout patches

Hi, On Jan/18/2010, Carles Pina i Estany wrote: > I've done a first version of keyboard_layout. Find a patch attached, or Thanks to the comments from different people in the thread, I send a new version. It does, on from my head: a) Constants used in util/ and Grub are in a common hea

Re: keyboard layout patches

Hi, On Jan/18/2010, Colin Watson wrote: > On Mon, Jan 18, 2010 at 07:25:37PM +0000, Carles Pina i Estany wrote: > > a) very short term: what about to register a command to "something" > > (like "1234", numbers doesn't usually change between keyboard, ri

Re: keyboard layout patches

; static const char pff2_magic[4] = { 'P', 'F', 'F', '2' }; ? If should be in a macro (as I think so) I will fix after finishing other things. Cheers, -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: keyboard layout patches

Hi, On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > Carles Pina i Estany wrote: > > Actually if prefix (that it's a variable) is "/" then args[0] acts as a > > filename. Would be like "///test/filename" and it's a valid

Re: keyboard layout patches

prefix (that it's a variable) is "/" then args[0] acts as a filename. Would be like "///test/filename" and it's a valid directory. > Can you think of a way to restoring keyboard map to English? unloading the module restores the original keyboard (so, English o

keyboard layout patches

gs, I'll do. I'm not happy with the name of some variables/functions but I cannot think about it today :-) Cheers, -- Carles Pina i Estany http://pinux.info === modified file 'conf/common.rmk' --- conf/common.rmk 2010-01-14 14:04:44 + +++ conf/common.rmk 2010-01-17

keyboard_layouts proof of concept

Now (only for some time) and tomorrow I'll be on the IRC, so feel free to comment here (better for archiving) or there (better for questions and answers). Thanks, -- Carles Pina i Estany http://pinux.info === modified file 'conf/common.rmk' --- conf/common.rmk 2010-01-14 14:0

Re: keyboard layouts

Hi, On Jan/12/2010, Colin Watson wrote: > On Tue, Jan 12, 2010 at 09:47:43PM +0000, Carles Pina i Estany wrote: > > Plan: > > * Approach 2 > > Small program (I guess that you prefer C, Python would be nice too) that > > when Grub is installed would process the

keyboard layouts

ill consider it, now I'm mainly thinking about the basic layout. -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

error message

uld have some more information. (any problem to use the gcc macros to know the filename/line number? I remember something and I cannot find it now) Any other ideas? The goals are two, and a bit contradictory at first glance: a) Have less strings b) Have more precise error messages -- Car

change strings main window

ch that re-words it a bit and makes more accurate. -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2010-01-02 15:19:57 + +++ ChangeLog 2010-01-02 23:08:06 + @@ -1,3 +1,7 @@ +2010-01-03 Carles Pina i Estany + + * normal/menu_text

Re: [PATCH] spaces (label, UUID)

Hi, On Jan/01/2010, Isaac Dupree wrote: > Carles Pina i Estany wrote: > >>>+grub_putchar (' '); > >>>+grub_printf_ (N_("- Label \"%s\""), label); > >>>... > >Avoiding to have trailing spac

Re: [PATCH] help command fix (II)

Hi, On Jan/01/2010, Carles Pina i Estany wrote: > Find attached a new version, measuring the width of the strings. I have After some comments from Vladimir on IRC, committed. -- Carles Pina i Estany http://pinux.info ___ Grub-de

[PATCH] help command fix (II)

tested it adding some long summary in some commands and works fine (apparently at least). Thank you, -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2010-01-01 12:33:45 + +++ ChangeLog 2010-01-01 17:08:20 + @@ -1,3 +1,14 @@ +2010-01-

Re: [PATCH] spaces (label, UUID)

Hi, On Jan/01/2010, Robert Millan wrote: > On Mon, Dec 28, 2009 at 02:17:37AM +0100, Carles Pina i Estany wrote: > > === modified file 'normal/misc.c' > > --- normal/misc.c 2009-12-20 23:32:15 + > > +++ normal/misc.c 2009-12-28 01:

[PATCH] macrofy (multiterm branch)

Hi, Find an attached patch to macrofy pos >> 8 and pos & 0xff in multiter. In my opinion should be macrofied, it's more clear. -- Carles Pina i Estany http://pinux.info === modified file 'include/grub/term.h' --- include/grub/term.h 2009-12-25 02:37:20 +000

Re: [PATCH] macrofying

Hi, On Dec/28/2009, Carles Pina i Estany wrote: > Attached a patch that macrofies some values. I don't see any reason that > was not macrofied. I forgot to mention: multiterm branch improved it in a different way. -- Carles Pina i Estany http:/

Re: [PATCH] spaces (label, UUID)

Hi, On Dec/28/2009, Carles Pina i Estany wrote: > This patch should fix a small problem that Vladimir spotted and Committed. -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.

[PATCH] spaces (label, UUID)

Hi, This patch should fix a small problem that Vladimir spotted and commented on IRC, plus adds a quotes on the label (looks nicer) and clearer in my opinion. Cheers, -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-27 21:3

[PATCH] macrofying

Hi, Attached a patch that macrofies some values. I don't see any reason that was not macrofied. -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-27 21:32:52 + +++ ChangeLog 2009-12-28 00:10:40 + @@ -1,3 +1,9 @@ +200

Re: help command

Hi, On Dec/27/2009, Carles Pina i Estany wrote: > I'll fix soon (tonight / tomorrow). a patch idea is attached. Before all summaries was: COMMAND_NAME COMMAND_SUMMARY r1992 removed COMMAND_NAME from the COMMAND_SUMMARY (smaller, not redundant, etc.). But help without arguments was

help command

Hi, help command (without any argument) is broken since r1992. I'll fix soon (tonight / tomorrow). -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: lib/arg.c: dynamic newline in help

Hi, Following a suggestion of Vladimir, now it uses GRUB_TERMINAL_WIDTH if it's not compiling in util way. -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-26 23:43:21 + +++ ChangeLog 2009-12-27 17:06:29 + @@ -1,5 +1

Re: lib/arg.c: dynamic newline in help

Hi, On Dec/27/2009, Carles Pina i Estany wrote: > Until now the options for the commands has been splitted (using a \n) by > the developer. if you want to test the patch, check the output of: insmod acpi help acpi before and after the patch. Before (at least with the standard termina

lib/arg.c: dynamic newline in help

problem or things that you would improve. My limited tests has been fine. I think that after comitting it I will be able to gettext all options strings. Thanks, -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-26 23:43:21 + +++ Change

Re: regression fix

Hi, On Dec/26/2009, Robert Millan wrote: > On Sat, Dec 26, 2009 at 01:35:53AM +0100, Carles Pina i Estany wrote: > > > > Hi, > > > > Commit 1949 introduced a bug using TAB due a miss-understanding that I > > had with the code. > > Oh, good to know. I wa

Re: user messages

Hi, On Dec/26/2009, Robert Millan wrote: > On Sat, Dec 26, 2009 at 11:20:27AM +0100, Carles Pina i Estany wrote: > >cmd_linux = grub_register_command ("linux", grub_cmd_linux, > > -0, "Load linux."); > > +

Re: patch to compile video/readers/* with test

Hi, On Dec/26/2009, Carles Pina i Estany wrote: > Find an attached patch that fix the compilation of video/readers/* when > DEBUG is enabled. validated in IRC, pushing now -- Carles Pina i Estany http://pinux.info ___ Grub-devel m

Re: patch to compile video/readers/* with debug

Correct Subject: is "with debug" (not with test) -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

patch to compile video/readers/* with test

Hi, Find an attached patch that fix the compilation of video/readers/* when DEBUG is enabled. If ok I would commit. Thanks, -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-26 10:01:33 + +++ ChangeLog 2009-12-26 10:42:57 +00

user messages

Hello, Find an attached patch. Linux should be always capitalized. All Linux loaders should have the same message: consistency, better LZMA and less work for translators. If you prefer another string tell me and I'll change. -- Carles Pina i Estany http://pinux.info === mod

regression fix

Hi, Commit 1949 introduced a bug using TAB due a miss-understanding that I had with the code. Find an attached patch that fix it. Brief ok from someone? -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-25 23:50:59 + +++ Chan

Re: gettext: help commands

.c and was fine. Thanks Vladimir, -- Carles Pina i Estany http://pinux.info === modified file 'commands/help.c' --- commands/help.c 2009-06-10 21:04:23 + +++ commands/help.c 2009-12-25 12:36:54 + @@ -21,6 +21,7 @@ #include #include #include +#include static

gettext: lib/arg.c

ls bigger than 80 characters. How it sounds? Other approach would be to use grub_print_message_indented, dependencies will affect mainly fstest (it use lib/arg.c). Or have a dummy grub_print_message_indented for fstest. -- Carles Pina i Estany http://pinux.info __

Re: gettext: help commands

, (cnt++) % 2 ? "\n" : " "); > >+ grub_printf ("%s%s", _(description), (cnt++) % 2 ? "\n" : " "); > At this point description is already cut at half of terminal width. > You have to first translate and then cut the message and not th

Re: gettext: help commands

Hi, On Dec/25/2009, Carles Pina i Estany wrote: > Find attached a patch that gettextizze the output of: The patch that I wanted to send is the attached one. It's the same one but without normal/menu_text.c changed as is not needed (will maybe be in the future). -- Carles Pina

gettext: help commands

patch to gettextizze the help of all commands. I would commit it in this way when someone reviews it. It's quite straightforward. Thanks, -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-25 00:04:51 + +++ ChangeLog 2009-12-25

Re: gettext: print_timeout

Hi, On Dec/24/2009, Robert Millan wrote: > On Sun, Dec 13, 2009 at 01:31:55AM +0000, Carles Pina i Estany wrote: > > > > If ok I would commit. > > Was this checked in? ISTR having OKed it on IRC, but I don't see it > in ChangeLog. it's already applied but no

Re: grub_error messages

Hi, On Dec/22/2009, Vladimir '??-coder/phcoder' Serbinenko wrote: > Jordi Mallach wrote: > > On Mon, Dec 21, 2009 at 10:19:16PM +0000, Carles Pina i Estany wrote: > > > >> b) At beginning I thought that we would not gettext error messages, but > >>

grub_error messages

t these strings? I'll do a patch, but I prefer to agree before b) At beginning I thought that we would not gettext error messages, but I see that lot of these messages appears to the end user. Do we gettext using N_(" ") and then where it's printed I use _(" ") ? I woul

Re: gettext: commands/*

{"file", 'f', 0, "specify filename", 0, ARG_TYPE_PATHNAME}, > +{"file", 'f', 0, "Specify filename.", 0, ARG_TYPE_PATHNAME}, > Filename for what? I'll add a comment when I will gettextizze it. -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: gettext: commands/*

Hi, On Dec/21/2009, Carles Pina i Estany wrote: > Because gettextizze and fix old strings is a bit confusing (for review > and tracking the changes, etc.) I've prepared a patch that should fix better writing: "Because gettextize and fix old strings at the same time and in the s

Re: gettext: commands/*

ething in some messages. -- Carles Pina i Estany http://pinux.info === modified file 'commands/acpi.c' --- commands/acpi.c 2009-11-23 15:31:54 + +++ commands/acpi.c 2009-12-20 23:51:49 + @@ -36,23 +36,23 @@ static const struct grub_arg_option options[] = { {"

Re: gettext: normal/*

Hi, On Dec/20/2009, Carles Pina i Estany wrote: > Can someone take a look in the patch again? Done in IRC. Thanks, -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mail

Re: gettext: normal/*

Hi, Same patch moving STANDARD_MARGIN to an include file and using it in normal/main.c. -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-19 23:00:30 + +++ ChangeLog 2009-12-20 12:10:46 + @@ -1,3 +1,33 @@ +2009-12-20 Car

Re: gettext: normal/*

Hi, On Dec/07/2009, Carles Pina i Estany wrote: > > IME, if it's not difficult to get rid of it, it better to do it for > > safety, because it's a common translator mistake. > > I will remove the spaces. Only in one place is not straight but it's > not di

Re: gettext: version string in normal/main.c

Hi, On Dec/19/2009, Carles Pina i Estany wrote: > > Hi, > > On Dec/19/2009, Carles Pina i Estany wrote: > > > Something to improve before committing? > > New patch with a missing grub_free. reviewed in IRC and committed. -- Carles Pina i Estan

Re: gettext: version string in normal/main.c

Hi, On Dec/19/2009, Carles Pina i Estany wrote: > On Dec/19/2009, Carles Pina i Estany wrote: > > > Something to improve before committing? when this will be reviewed and committed I will adapt (some things has changed) the last part of normal/* files . I sent a week ago aprox. bu

Re: gettext: version string in normal/main.c

Hi, On Dec/19/2009, Carles Pina i Estany wrote: > Something to improve before committing? New patch with a missing grub_free. -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-19 00:05:41 + +++ ChangeLog 2009-12-19 0

gettext: version string in normal/main.c

Hi, I've gettextitzzed the version string. Something to improve before committing? It's all right? Thanks, -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-19 00:05:41 + +++ ChangeLog 2009-12-19 01:27:34 + @@ -1

Re: Unittests

s/during holidays...) Thanks, -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Unittests

Hi, On Dec/16/2009, BVK Chaitanya wrote: > On Tue, Dec 15, 2009 at 5:18 AM, Carles Pina i Estany wrote: > > > > Writing a unittest for gettext it's very easy: it just needs a couple of > > .mo and a script executing gettext "string" and checking that the res

Unittests

y easy: it just needs a couple of .mo and a script executing gettext "string" and checking that the result is "string translated". Will get more interesting when ngettext will come too :-) So, BVK, once you have the infrastructure if you ping me gettext could be your guinea pig.

Re: var=foo should be valid?

Hi, On Dec/12/2009, Carles Pina i Estany wrote: > We should fix it. We have three options (maintaining the current > behaviour for the user): > > > a) simple_patch (just swapping that two lines) After talking with Robert last night and for the time being I've committed t

gettext: print_timeout

If ok I would commit. -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2009-12-12 00:43:32 + +++ ChangeLog 2009-12-13 00:44:09 + @@ -1,3 +1,10 @@ +2009-12-13 Carles Pina i Estany + + * normal/menu_text.c (utf8

Re: var=foo should be valid?

Hi, On Dec/04/2009, Carles Pina i Estany wrote: > > Hi, > > On Dec/04/2009, Robert Millan wrote: > > On Sun, Nov 29, 2009 at 06:39:36PM +0000, Carles Pina i Estany wrote: > > > (first one has a bug but very easy to fix, even thought I would maybe > > > refa

gettext: print_timeout

Hi, print_timeout is not working fine when the translated string contains multi-byte characters, because it's locating where to write the seconds when second_stage == 1 (so the seconds when second_stage == 1 are miss-placed). Tomorrow evening or Sunday I will fix it. -- Carles Pina i E

Re: [PATCH] Backup old boot sectors before installation

a patch for this inside grub-setup > See here and also for the discussion of it: > http://lists.gnu.org/archive/html/grub-devel/2009-09/msg00242.html I like the idea, and I think that as Colin pointed it out it can be useful. I haven't watched to any o

Re: Build failures on Ubuntu due to gettext

we review? Colin: for me you can commit your patch some way or another so you could compile in Ubuntu and I can commit soon more things. Thanks, -- Carles Pina i Estany http://pinux.info ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Build failures on Ubuntu due to gettext

Hi, On Dec/10/2009, Carles Pina i Estany wrote: As Richard commented (thanks): > #define grub_put_(str) grub_printf(N_ ("%s"), (str)) #define grub_put_(str) grub_printf("%s", N (str)) I should not be sending patches when too tired / without pr

Re: Build failures on Ubuntu due to gettext

Hi, As Vladimir spotted: On Dec/09/2009, Carles Pina i Estany wrote: This...: > +#define grub_put_(str) grub_printf("%s", (str)) should be: #define grub_put_(str) grub_printf(N_ ("%s"), (str)) If you Colin commit it don't propagate my mistak

Re: Build failures on Ubuntu due to gettext

dimir, Colin: see the attached patch with the Colin changes but macrofied. Should compile fine in Ubuntu, but I have not tried. Are we happy with grub_put_ function name? Colin: could you apply this patch or similar? I don't want to push more gettext strings before setting up the basic

Re: Build failures on Ubuntu due to gettext

Hi, On Dec/08/2009, Colin Watson wrote: > On Mon, Dec 07, 2009 at 10:46:30PM +0000, Carles Pina i Estany wrote: > > Your patch conflicts with my one (Subject: gettext: grub_printf_ and N_) > > but it's not a big problem. If you commit before I would adapt > > my one, e

Re: gettext: grub_printf_ and N_

Hi, On Dec/07/2009, Colin Watson wrote: > On Mon, Dec 07, 2009 at 09:11:00PM +0000, Carles Pina i Estany wrote: > > +int > > +grub_printf_ (const char *fmt, ...) > > +{ > > + va_list ap; > > + int ret; > > + > > + va_start (ap, fmt); > > +

  1   2   3   >