Re: [PATCH] Generalize MD_MAX_DISKS to GRUB_MDRAID_MAX_DISKS

2023-06-13 Thread Kees Cook
> Cc: Daniel Axtens > Cc: Kees Cook Yup, looks good to me. Thanks! Reviewed-by: Kees Cook -Kees > --- > grub-core/disk/diskfilter.c | 4 ++-- > grub-core/osdep/linux/getroot.c | 12 ++-- > include/grub/disk.h | 10 ++ > 3 files changed, 14

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-07 Thread Kees Cook
On Wed, Jun 07, 2023 at 03:39:24PM +0200, Daniel Kiper wrote: > On Tue, Jun 06, 2023 at 11:02:31AM -0700, Kees Cook wrote: > > On Tue, Jun 6, 2023 at 10:27 AM Julian Andres Klode > > wrote: > > > > > > On Tue, Jun 06, 2023 at 07:09:26PM +0200, Daniel Kiper wrote

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Kees Cook
mmit 2a5e3c1f2 (disk/diskfilter: Don't make a RAID array with more > > than 1024 disks). I think we should sync both numbers down to 1024... > > +1 Yeah, seems reasonable, though as I hinted in the original patch, this number appeared to have been arbitrarily chosen by mdadm at th

Re: [PATCH v2] osdep/linux: Fix md array device enumeration

2021-10-13 Thread Kees Cook
On October 11, 2021 8:02:18 AM PDT, Daniel Kiper wrote: >On Thu, Oct 07, 2021 at 04:33:16PM -0700, Kees Cook wrote: >> GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's >> disk.number, which is an internal kernel index. If an array has had drives >>

Re: [PATCH] osdep/linux: Fix md array device enumeration

2021-10-07 Thread Kees Cook
Hi Petr, On Wed, Oct 06, 2021 at 09:28:32AM +0200, Petr Vorel wrote: > Hi Kees, Daniel, > > > On Sat, Sep 25, 2021 at 07:03:35PM -0700, k...@ubuntu.com wrote: > > > From: Kees Cook > > > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO

Re: [PATCH] osdep/linux: Fix md array device enumeration

2021-10-07 Thread Kees Cook
Hi Daniel, On Tue, Oct 05, 2021 at 06:38:13PM +0200, Daniel Kiper wrote: > On Sat, Sep 25, 2021 at 07:03:35PM -0700, k...@ubuntu.com wrote: > > From: Kees Cook > > > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > > disk.number, which is

[PATCH v2] osdep/linux: Fix md array device enumeration

2021-10-07 Thread Kees Cook
the devicelist index (j). Fixes: 49de079bbe1c ("... (grub_util_raid_getmembers): Handle "removed" disks") Fixes: 2b00217369ac ("... Added support for RAID and LVM") Fixes: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1912043 Fixes: https://savannah.gnu.org/b

[PATCH] osdep/linux: Fix md array device enumeration

2021-01-17 Thread Kees Cook
s: 49de079bbe1c ("... (grub_util_raid_getmembers): Handle "removed" disks") Fixes: 2b00217369ac ("... Added support for RAID and LVM") Fixes: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1912043 Fixes: https://savannah.gnu.org/bugs/index.php?59887 Signed-off-by: K

[PATCH] Fix md RAID enumeration

2021-01-16 Thread Kees Cook
s://savannah.gnu.org/bugs/index.php?59887 Signed-off-by: Kees Cook (This is intended to be applied on top of the earlier patch sent in https://lists.gnu.org/archive/html/grub-devel/2021-01/msg00027.html) Index: grub2-2.04/grub-c

[PATCH] Fix potential truncation of mdraid device list

2021-01-16 Thread Kees Cook
("... (grub_util_raid_getmembers): Handle "removed" disks") Fixes: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1912043 Fixes: https://savannah.gnu.org/bugs/index.php?59887 Signed-off-by: Kees Cook Index: grub2-2.04/grub-core/o