Re: [PATCH] LVM cachevol support

After, I'm > able to boot with grub's root on an LV with cachevol. > > I'd like to acknowledge Patrick Plenefisch, who submitted a similar patch > with a broader scope, and Yay! I hope that one of our patches makes it in sooner rather than later, so that the next version o

Re: [PATCH 0/3 v8] LVM Cachevol and Integrity volumes break entire LVM VG

Hello, I'd love to get this latest version reviewed at some point Thanks, Patrick On Tue, Aug 13, 2024 at 8:50 PM Patrick Plenefisch wrote: > > In an effort to solve > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061168 for myself, > I implemented basic support for cache

[PATCH 0/3 v8] LVM Cachevol and Integrity volumes break entire LVM VG

lumes will fail to boot These patches are also available attached and at https://github.com/byteit101/grub2/commits/grub-lvmintegrity/ Please ignore the ones not labeled "v8", as I had a cherry picking error. How do you edit patches sanely? Patrick Plenefisch (3): disk/lvm: Make cach

[PATCH 3/3 v8] lvm: Add support for cachevol and integrity lv

not have pv data applied yet This patch contains a change requested by Daniel Kiper to use a null character instead of an integer zero to terminate strings Signed-off-by: Patrick Plenefisch --- grub-core/disk/diskfilter.c | 6 ++- grub-core/disk/lvm.c

[PATCH 1/3 v8] disk/lvm: Make cache_lv more generic as ignored_feature_lv

This patch isn't necessary by itself, but when combined with the next two patchs it enhances readability as ignored_features_lv is then used for multiple types of extra LV's, not just cache LV's Signed-off-by: Patrick Plenefisch --- grub-core/d

[PATCH 2/3 v8] disk/lvm: Remove unused cache_poo

cache_pool is never read or used, remove it Signed-off-by: Patrick Plenefisch --- grub-core/disk/lvm.c | 25 - 1 file changed, 25 deletions(-) diff --git a/grub-core/disk/lvm.c b/grub-core/disk/lvm.c index 442a9fc96..10bc965a4 100644 --- a/grub-core/disk/lvm.c +++ b

[PATCH 2/3] disk/lvm: Remove unused cache_pool

cache_pool is never read or used, remove it Signed-off-by: Patrick Plenefisch --- grub-core/disk/lvm.c | 25 - 1 file changed, 25 deletions(-) diff --git a/grub-core/disk/lvm.c b/grub-core/disk/lvm.c index 3d226fad5..17e225596 100644 --- a/grub-core/disk/lvm.c +++ b

[PATCH 1/3] disk/lvm: Make cache_lv more generic as ignored_feature_lv

This patch isn't necessary by itself, but when combined with the next patch it enhances readability as ignored_features_lv is then used for multiple types of extra LV's, not just cache LV's Signed-off-by: Patrick Plenefisch --- grub-core/d

[PATCH 0/3] LVM Cachevol and Integrity volumes break entire LVM VG

lumes will fail to boot These patches are also available attached and at https://github.com/byteit101/grub2/commits/grub-lvmintegrity/ Patrick Plenefisch (3): disk/lvm: Make cache_lv more generic as ignored_feature_lv disk/lvm: Remove unused cache_pool lvm: Add support for cachevol and integrity

Re: [PATCH 2/2] lvm: Add support for cachevol and integrity lv

On Wed, Jun 26, 2024 at 7:58 AM Daniel Kiper wrote: > > On Sun, Jun 09, 2024 at 03:35:06PM -0400, Patrick Plenefisch wrote: > > lv matching must be done after processing the ignored feature > > indirections, as integrity volumes & caches may have several levels >

[PATCH 0/2] LVM Cachevol and Integrity volumes break entire LVM VG

lumes will fail to boot These patches are also available attached and at https://github.com/byteit101/grub2/commits/grub-lvmintegrity/ Patrick Plenefisch (2): disk/lvm: Make cache_lv more generic as ignored_feature_lv lvm: Add support for cachevol and integrity lv grub-core/disk/diskfilt

[PATCH 2/2] lvm: Add support for cachevol and integrity lv

not have pv data applied yet Signed-off-by: Patrick Plenefisch --- grub-core/disk/diskfilter.c | 6 ++- grub-core/disk/lvm.c| 85 +++-- 2 files changed, 57 insertions(+), 34 deletions(-) diff --git a/grub-core/disk/diskfilter.c b/grub-core/disk/diskfilt

[PATCH 1/2] disk/lvm: Make cache_lv more generic as ignored_feature_lv

This patch isn't necessary by itself, but when combined with the next patch it enhances readability as ignored_features_lv is then used for multiple types of extra LV's, not just cache LV's Signed-off-by: Patrick Plenefisch --- grub-core/d

Re: [PATCH 2/2 v2] LVM Cachevol and Integrity volumes break entire LVM VG

thing else. Thanks, Patrick On Fri, Apr 26, 2024 at 9:00 PM Patrick Plenefisch wrote: > From 8cfb6dbb011d3773b90a3cbb8561616a2fb5955f Mon Sep 17 00:00:00 2001 > From: Patrick Plenefisch > Date: Sun, 18 Feb 2024 18:36:05 -0500 > Subject: [PATCH 2/2] lvm: Add support for cachevol a

Re: [PATCH] LVM Cachevol and Integrity volumes break entire LVM VG

On Sat, Apr 27, 2024 at 5:25 AM Glenn Washburn wrote: > > On Fri, 26 Apr 2024 21:02:03 -0400 > Patrick Plenefisch wrote: > > > Ah thanks, I sent them in two separate emails with git format-patch, > > hopefully correctly? > > I'm confused git format-patch does n

Re: [PATCH] LVM Cachevol and Integrity volumes break entire LVM VG

Ah thanks, I sent them in two separate emails with git format-patch, hopefully correctly? Patrick On Fri, Apr 26, 2024 at 7:13 PM Glenn Washburn wrote: > > On Fri, 26 Apr 2024 18:10:16 -0500 > Glenn Washburn wrote: > > > On Sun, 18 Feb 2024 21:00:19 -0500 > > P

[PATCH 2/2 v2] LVM Cachevol and Integrity volumes break entire LVM VG

From 8cfb6dbb011d3773b90a3cbb8561616a2fb5955f Mon Sep 17 00:00:00 2001 From: Patrick Plenefisch Date: Sun, 18 Feb 2024 18:36:05 -0500 Subject: [PATCH 2/2] lvm: Add support for cachevol and integrity lv lv matching must be done after processing, as integrity volumes may have several levels that

[PATCH 1/2 v2] LVM Cachevol and Integrity volumes break entire LVM VG

From 42252f253ac685bbc7cea1f5c89146eeeaa364f0 Mon Sep 17 00:00:00 2001 From: Patrick Plenefisch Date: Sun, 18 Feb 2024 18:29:43 -0500 Subject: [PATCH 1/2] disk/lvm: Make cache_lv more generic as ignored_feature_lv Signed-off-by: Patrick Plenefisch --- grub-core/disk/lvm.c | 179

Re: [PATCH v2] cryptodisk: allow the user to retry failed passphrases

On Mon, Apr 22, 2024 at 1:48 PM Forest wrote: > On Sun, 07 Apr 2024 14:52:32 -0700, Forest wrote: > > >Changes since last rev: > >- replace some spaces with tabs > >- better explain the clearing of grub_errno > >- let an environment variable override the number of passphrase tries > > As a new co

Re: [PATCH] grub_diskfilter_memberlist: recurse into lv nodes.

This may have some interaction with my pending LVM patches from January & Febuary for a superficially similar issue on complex lv's. My original patch: https://lists.gnu.org/archive/html/grub-devel/2024-01/msg00110.html Github branch with split patches: https://github.com/byteit101/grub2/tree/grub

Re: [PATCH] LVM Cachevol and Integrity volumes break entire LVM VG

Feb 08, 2024 at 02:52:37PM -0500, Patrick Plenefisch wrote: > > Hmm, what would the logical parts be? The solution for both cachevol and > > integrity is the same. > > It seems to me at least code refactoring which you are doing could be > taken out to a separate patch. Maybe s

Re: [PATCH] LVM Cachevol and Integrity volumes break entire LVM VG

57 AM Daniel Kiper wrote: > On Mon, Jan 29, 2024 at 04:37:30PM -0500, Patrick Plenefisch wrote: > > In an effort to solve > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061168 > > for myself, I implemented basic support for cachevol and integrity > volumes in > &

[PATCH] LVM Cachevol and Integrity volumes break entire LVM VG

In an effort to solve https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061168 for myself, I implemented basic support for cachevol and integrity volumes in LVM. This is just an extension of the cachepool support that already existed, and just like that support, I ignore all of the metadata and j

Basic mouse support (cursor)

Over the past few days, I've been hacking on GRUB, and implemented mouse support in the form of a virtual keyboard. That is when you move the mouse around it generates arrow key presses or enter on clicks. The attached patch is based on current bzr trunk (4559) and also fixes a build error with a m