Re: [PATCH] Fix security issue when reading username and password

2019-10-24 Thread Hector Marco
(not underflow this time). As Ismael say, please read the entry we wrote in 2015 http://hmarco.org/bugs/CVE-2015-8370-Grub2-authentication-bypass.html Best regards, Hector. On 24/10/2019 16:04, Daniel Kiper wrote: > Hi Hector, > > On Thu, Oct 24, 2019 at 03:22:43PM +0100, Hector Marco w

Re: [PATCH] Fix security issue when reading username and password

2019-10-24 Thread Hector Marco
Hello Daniel, Something went wrong in my last email, what I wanted to say is: The patch prevents that "cur_len" underflows. No negative values for "cur_len" so no way to underflow the "cur_len" variable and therefore no vulnerability. Hector. On 24/10/2019 15:1

Re: [PATCH] Fix security issue when reading username and password

2019-10-24 Thread Hector Marco
0, Javier Martinez Canillas wrote: >> From: Hector Marco-Gisbert >> >> This patch fixes two integer underflows at: >> * grub-core/lib/crypto.c >> * grub-core/normal/auth.c >> >> Resolves: CVE-2015-8370 >> >> Signed-off-by: Hector M

Re: we need a doc too

2009-08-14 Thread Marco Gerards
Hi, "J.Bakshi" writes: > It is nice to see that grub 1.97 is on its way. Everyone is waiting > for this power pack. But we also need a good doc for it. > The wiki is out-dated. You are completely right. Do you volunteer to write docum

Re: Three question about grub2

2009-08-07 Thread Marco Gerards
"J.Bakshi" writes: > Coming back with one more question in mind. ( already searched bot no > luck yet ). "echo" can dispaly message. Is there ( by any luck ) any > command to display message from a file ? cat -- Marco __

Re: [PATCH 1/2] Relocator framework

2009-08-07 Thread Marco Gerards
r APPLE_CC ifdefs will probably need some review too, > but there's no hurry about that). Agreed. GRUB is a GNU project and we can depend on GNU programs. Especially since we use some GNU extensions. -- Marco ___ Grub-devel mailing list Gru

New maintainers

2009-08-05 Thread Marco Gerards
Hello, After a long discussion, I am happy to announce that Pavel and Robert are added to the list of GNU GRUB maintainers. I really hope this will improve the current situation. I will add them to savannah soonish, but they already are official GNU GRUB maintainers. Thanks, Marco

Re: Some ideas about new features of grub

2009-07-31 Thread Marco Gerards
ent to the memdisk of syslinux. > > Hard drives and CD-ROMs are usually large and would take a lot of space > in memory that would need to remain allocated. I think we need a strong > case to start that effort. > > I'd rather see an effort to support CD-R

Re: [PATCH] File access library for lua

2009-07-31 Thread Marco Gerards
requires the user to use lua: slowdown - Personally, I hope people improve on the default scripting language -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Proposal for GNU indent compatibility

2009-07-31 Thread Marco Gerards
t; Neither does it mean that it's acceptable to submit code that GNU indent > failed to format nicely. I do not have a problem with this. Thus the space change around "!". -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: GRUB 1.96 - unknown commands

2009-07-10 Thread Marco Gerards
Hello, Bean writes: > You need to add module sh, minicmd and linux. What was the reason it was split up? Sorry, I must have missed a discussion. I prefer scripting and normal.mod to be integrated, to prevent problems like these. -- Ma

Re: GRUB 1.96 - unknown commands

2009-07-10 Thread Marco Gerards
or a good purpose as you can see. Is it possible that lua integration has broken this? Support for the core scripting language is more important to me than any additional scripting language. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [RFC] New object format for grub2

2009-07-08 Thread Marco Gerards
windows or so and we can support it in a sane way, but changing our binary formats for it is one step too far for me... -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: regression in hiddenmenu (Re: [2158] 2009-05-02 Bean )

2009-06-28 Thread Marco Gerards
s to be the cause for this problem. > > I can suggest a few possible solutions: > > - Rename either (kludge! kludge!) > > - Put sh.mod back in kernel. Why was it moved out? Is there any good reason for this? I could have missed the discussion, I am quite busy lately... -

Re: [RFC] New menu design based on MVC

2009-06-28 Thread Marco Gerards
like XML. So I have a *very* strong opinion against using this. The current syntax is closer to most programming languages. Shouldn't we focus on getting that into shape? Perhaps I should actually make that my first priority when I get some time again to work on GRUB (fixing scripting su

Re: [PATCH 4/4] Define fields in terms of the Class Code register

2009-06-08 Thread Marco Gerards
Oliver Henshaw writes: Can you please send in patches in such a way they are recognised as text or inline? Please include a Changelog entry. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] add true and false commands

2009-06-05 Thread Marco Gerards
Felix Zielcke writes: > Am Freitag, den 05.06.2009, 14:26 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: > >> > So what should I do now? >> > Placing it in normal.mod or minicmd.mod where it's included in rescue >> > mode or placing it into

Re: [PATCH] add true and false commands

2009-06-05 Thread Marco Gerards
Felix Zielcke writes: > Am Freitag, den 05.06.2009, 12:00 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: >> >> > Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: >> >> Felix Zielcke writes: >> >> >> >> > A

Re: [PATCH] add true and false commands

2009-06-05 Thread Marco Gerards
Felix Zielcke writes: > Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards: >> Felix Zielcke writes: >> >> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder' >> > Serbinenko: >> >> However convention

Re: [PATCH] add true and false commands

2009-06-04 Thread Marco Gerards
; > Ok changed it. If everyone is fine with placing this in normal/main.c, I > commit it. Unless it is essential to do so, please do not place it in normal/main.c. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Data loss at savannah.gnu.org

2009-06-02 Thread Marco Gerards
nt more than most of us did? He actually wrote all the intial code of GRUB 2 from scratch. Besides that, a maintainer has to take care that the project remains a true GNU project. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Absence

2009-05-28 Thread Marco Gerards
Hi, Many of you might have noticed that I have not been very active lately. This is mainly caused by my new study, work and personal circumstances. To be honest, I have no idea when this will change. When I have some spare time, I will be here. -- Marco

Re: Parser

2009-03-07 Thread Marco Gerards
Making all kinds of dirty stubs is something I don't really like. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Menus and Functions

2009-03-03 Thread Marco Gerards
n that, > instead of being referred to by a function name, is referred to by a > menu title. This was on purpose. My idea was that menu entries can be generated in a macro like fashion. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org ht

Re: USB support merge (Re: [PATCH] (ata.mod) Fix ATAPI protocol)

2009-02-16 Thread Marco Gerards
Robert Millan writes: > On Mon, Jan 19, 2009 at 11:15:41AM +0100, Marco Gerards wrote: >> Perhaps my USB code might help in some occasions >> for scsi.c, I am not completely sure if they are in sync. I sent in >> the USB code earlier. This code can be committed, althoug

Re: [PATCH] (ata.mod) Fix ATAPI protocol

2009-01-20 Thread Marco Gerards
Christian Franke writes: > Christian Franke wrote: >> Marco Gerards wrote: >> >>> Christian Franke <...> writes: >>> >>> >>>> This patch fixes the data I/O protocol of the ATA PACKET command. >>>> >>>> The cu

Re: [PATCH] (ata.mod) Fix ATAPI protocol

2009-01-19 Thread Marco Gerards
is code can be committed, although endianess is not handled correctly at all places. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: USB support

2008-11-04 Thread Marco Gerards
the blockers for USB support was the terminal split. Now that I > implemented it (see my last patch about this), I think integration can > proceed. Also, feedback and testing is welcomed. I will commit the core USB code when I found the time to review my USB code and fix the endianesses in

Re: grub2 summer code theme in debian?

2008-09-24 Thread Marco Gerards
can I use those fancy gfxterm in debian ? > I have seen those are in action in kubuntu, suse etc... even I have > downloaded > successfully all the images, fonts to get the winter theme. Is not there any > alternative to use the theme ? Patch things yourself. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Absence

2008-09-21 Thread Marco Gerards
card will solve this problem too ;) Thanks, Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] fix disk->id abuse

2008-09-02 Thread Marco Gerards
t; I assume using LUNs is a proper solution for that one? No, it is not. I think I already said so on IRC? -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: debian upstream bugs

2008-08-29 Thread Marco Gerards
[EMAIL PROTECTED] writes: > Gentlemen, I submitted some what I thought were downstream bugs: > http://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=grub-pc;[EMAIL PROTECTED] Ehm? Can you please just start a discussion, I think that will give a better result than pointing to a website. --

Re: Handlers

2008-08-29 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> If I knew a better way, I would have used it. I think the >> alternatives will all end up in either code duplication or a loss of >> type safety that now is at least present through warnings. Bu

Re: grub 1.96 svn 20080813 and circular lvm2 metadata

2008-08-29 Thread Marco Gerards
n->offset seems to be little endian (64 bits), so please use grub_le_to_cpu64. Same for rlocn->size, please check the size of this member before you use a macro (I couldn't find it immediately...). > +{ > + /* metadata is circular */ Same as above. &g

Re: grub 1.96 svn 20080813 and circular lvm2 metadata

2008-08-29 Thread Marco Gerards
he list. Furthermore this makes a patch harder to apply. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Handlers

2008-08-29 Thread Marco Gerards
Hi, Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> This patch adds handler support to GRUB 2. This makes it easier to >> add new handlers to GRUB without duplicating code over and over. Bean >> wanted this for some of his ideas :-) >>

Re: Handlers

2008-08-29 Thread Marco Gerards
ertainly looks good, thanks for the suggestion. However, I do not think we have the same goals. For example, I focus on size and do not need many features. > Two comments: > > At Fri, 29 Aug 2008 14:36:56 +0200, > Marco Gerards wrote: >> +void >> +grub_handler_unregister

Handlers

2008-08-29 Thread Marco Gerards
most people agree with. I just don't want to commit this without proper review. Thanks, Marco 2008-08-29 Marco Gerards <[EMAIL PROTECTED]> * conf/i386-efi.rmk (grub_emu_SOURCES): Add `kern/handler.c'. (kernel_img_SOURCES): Likewise. (grub_setup_SO

Re: [PATCH] new static const char[] modname

2008-08-28 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Seems like it isn't that bad to review your own patches _before_ sending > them and actually to compile them .. ...and include a changelog entry? ;-) -- Marco ___ Grub-devel mailin

Absence

2008-08-23 Thread Marco Gerards
Hi, Since my modem is broken, I will most likely not read the list for a week or so. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

USB Support

2008-08-17 Thread Marco Gerards
sible to add and remove devices on the fly -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] romfs support for Grub2

2008-08-17 Thread Marco Gerards
tter if some one can introduce the framework of grub2, this would > reduce the difficulty of study the grub2. ;-) You can have a look at the wiki and ask questions :-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Replace magic numbers by constants

2008-08-17 Thread Marco Gerards
Millan on 2008-02-05) > > I'm sending a patch to change the magic numbers by constants. > > ChangeLog: > > 2008-08-17 Carles Pina i Estany <[EMAIL PROTECTED]> > > * menu/normal.c (run_menu): Change magic numbers by constants. Can you be

Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader

2008-08-16 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Aug 13, 2008 at 07:52:59PM +0200, Marco Gerards wrote: >> > #include >> > #include >> > +#include/* For struct grub_mmap_entry, which is >> > also >> > +

Re: [Fwd: Re: Bug#495049: grub-pc: does not boot because module "normal" is not loaded]

2008-08-15 Thread Marco Gerards
happen anymore? > And he reported against newest lenny version where this changes were > included by Robert and me. Perhaps he simply clicked on "newest version" without bothering to make sure? I can image such things just happen... -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-14 Thread Marco Gerards
* > * GRUB is free software: you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > @@ -74,6 +74,18 @@ grub_util_error (const char *fmt, ...) >exit (1); > } > > +int > +grub_err_printf (const char *fmt, ...) &g

Re: [PATCH] Drivemap module

2008-08-14 Thread Marco Gerards
I care, not because I am the foremost expert in BIOS disks. It's for the best if other people can look at specific parts of your patch, especially if it changes the kernel. Perhaps you do not notice how many time I spent on reviewing patches on th

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-14 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Donnerstag, den 14.08.2008, 09:07 +0200 schrieb Marco Gerards: > > Honourly I want that whole topic discussed with everyone who is > subscribed here and not just with you Marco, but it's very kind that at > least you reply :

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-14 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Donnerstag, den 14.08.2008, 00:39 +0200 schrieb Felix Zielcke: >> >> This time dear Marco I didn't bother to read through the changelog, it >> might be still not perfect and I'm even tired now. > > I shoul

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-14 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Mittwoch, den 13.08.2008, 20:41 +0200 schrieb Marco Gerards: >> So what do you propose? :-) You lost me midway since you change >> subjects a bit often ;( > > Oh sorry for that this time I only changed [PATCH] to [RFC]

Re: [PATCH] add support for GRUB_GFXMODE variable

2008-08-13 Thread Marco Gerards
;> >> 2008-07-31 Felix Zielcke <[EMAIL PROTECTED]> >> >> * util/update-grub.in (GRUB_GFXMODE): Export variable. >> * util/grub.d/00_header.in: Allow the administrator to change default >> gfxmode via ${GRUB_GFXMODE}. This is Robe

Re: [RFC] change grub_print_error to use stderr for the utils

2008-08-13 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Hello, > > Am Mittwoch, den 13.08.2008, 11:38 +0200 schrieb Marco Gerards: >> > 2008-08-12 Felix Zielcke <[EMAIL PROTECTED]> >> > >> > * kern/err.c [GRUB_UTIL]: Include . >> >

Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader

2008-08-13 Thread Marco Gerards
addr; > + grub_uint64_t len; > +#define GRUB_MMAP_MEMORY_AVAILABLE 1 > +#define GRUB_MMAP_MEMORY_RESERVED2 > + grub_uint32_t type; > +} __attribute__((packed)); > + > struct grub_mod_list > { >/* the memory used goes from bytes 'mod_start' to 'mod_end-1'

Re: [PATCH] Drivemap module

2008-08-13 Thread Marco Gerards
is over with Robert and me, you know that it was pointed out that this has to be a patch in a separate thread. Furthermore, this is a way to get some feedback from Bean who wants something similar, IIRC. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Drivemap module

2008-08-13 Thread Marco Gerards
Hi, Javier Martín <[EMAIL PROTECTED]> writes: > El mié, 13-08-2008 a las 15:00 +0200, Robert Millan escribió: >> Hi, >> >> Marco asked me to review this. > So he finally got fed up of me... Understandable ^^ No, but I am not as qualified regarding the BIOS as

Re: [PATCH] Home-End keys in menu

2008-08-13 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Aug 13, 2008 at 12:15:37PM +0200, Marco Gerards wrote: >> Hi, >> >> Carles Pina i Estany <[EMAIL PROTECTED]> writes: >> >> [...] >> >> > 2008-08-06 Carles Pina i Estany <[EMAI

Re: Idea: use menu hook to implement the savedefault command

2008-08-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > Hi, > > Now it's possible to implement savedefault with load_env and save_env, > but the problem is we need to add it to every menuitem, it's tedious > process, and new item don't get it automatically. > > I'm thinking about using menu hook to solve this. I can t

Re: [PATCH] Do not mess with libc's prototypes

2008-08-13 Thread Marco Gerards
not for GRUB_UTIL, so please don't do this. Perhaps your problem can be fixed in another way. IIRC, this was added because on the PPC, memcpy was required by libgcc, which is used there... -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Warning fixes

2008-08-13 Thread Marco Gerards
t): Mark pciid unused. Oh, I changed this, so this might not apply anymore... > * commands/i386/pc/pxecmd.c (grub_cmd_pxe): Mark argc and args > unused. > * include/grub/i386/pc/pxe.h (grub_pxenv_tftp_open): Use char > instead of grub_uint8_t for strings. >

Re: [PATCH] New command checktime

2008-08-13 Thread Marco Gerards
datetime > functions, it's a little wired to install the hook as a side effect. Fine for me :-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Home-End keys in menu

2008-08-13 Thread Marco Gerards
e it can be committed. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Drivemap module

2008-08-13 Thread Marco Gerards
Javier Martín <[EMAIL PROTECTED]> writes: > In this reply-to-myself hoping to keep the thread continuity, I put > forth the new "version 7" of the patch with the following changes: > > - A new switch -s/--swap has been implemented, so that running > "drivemap -s hd0 hd1" is equivalent to issuing

Re: [PATCH] Split of raid scan code

2008-08-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Tue, Aug 12, 2008 at 4:30 AM, Robert Millan <[EMAIL PROTECTED]> wrote: >> On Tue, Aug 12, 2008 at 04:24:26AM +0800, Bean wrote: >>> - disk/lvm.c disk/raid.c grub_probe_init.c >>> + disk/lvm.c disk/raid.c disk/mdraid_linux.c grub_probe_init.c >> >> Hi,

Re: [PATCH] add pkzip support for gzio

2008-08-13 Thread Marco Gerards
"Gregg Levine" <[EMAIL PROTECTED]> writes: > On Mon, Aug 11, 2008 at 1:22 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Hi, >> >> "y.volta" <[EMAIL PROTECTED]> writes: >> >>> i've made a little patch for pkzipe

Re: Idea: Use extended blocklist format to support installing to raid device.

2008-08-13 Thread Marco Gerards
ing to support > it in the future, deal with user problems and bug fixes. This shouldn't be > treated lightly IMHO. I personally have no problems with saying no from time to time :-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Is romfs supported in Grub2

2008-08-13 Thread Marco Gerards
Legacy filesystem code are *VERY* different. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-13 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote: >> > * kern/err.c [GRUB_UTIL]: Include . > >> Please don't do this. Why do you want this? > > It's needed for fprintf, and fprintf is on

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-13 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote: >> > [GRUB_UTIL] (grub_print_error): Use fprintf (stderr, ...) >> > instead of >> > grub_printf. >> >&g

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-13 Thread Marco Gerards
> comment :) > > 2008-08-12 Felix Zielcke <[EMAIL PROTECTED]> > > * kern/err.c [GRUB_UTIL]: Include . > (grub_print_error) [GRUB_UTIL]: Use fprintf (stderr, ...) instead > of > grub_printf. If there is another way to do this, I w

Re: [PATCH] change grub_print_error to use stderr for the utils

2008-08-13 Thread Marco Gerards
intf (stderr, ...) instead > of > grub_printf. Actually, both syntaxes are used. See: http://www.gnu.org/prep/standards/html_node/Conditional-Changes.html#Conditional-Changes Please do not use the current changelog as a manual, only for examples. The GCS is the manual :-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Enable grub_cpu_idle for i386 to halt the CPU

2008-08-13 Thread Marco Gerards
David Fries <[EMAIL PROTECTED]> writes: > Enable grub_cpu_idle for i386 to halt the CPU and modify the menu code > to make use of it. This will save power when booting. > Or maybe I should say it will keep the CPU from running so hot when > the timer is counting down. > > It isn't safe to call ha

Re: Idea: implementation of the password command

2008-08-13 Thread Marco Gerards
GET_PASSWORD) then > ... > fi > > # Store the new password > PASSWORD=$GET_PASSWORD > save_env PASSWORD > > This way looks neat, but it requires a working test command to be useful. I think this might become a security risk

Re: [PATCH] grub-mkelfimage

2008-08-13 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > If there are no objections, I will check this in soon. Looks fine to me. Didn't you break the ability to cross compile for PPC on x86 along the way? -- Marco ___ Grub-devel mailing l

Re: [PATCH] New command checktime

2008-08-12 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Tue, Aug 12, 2008 at 5:07 AM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> >>> * commands/date.c: New file. >>> >>> * commands/datetime.c: Likewise. >> >> This is not a command. But I d

Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

2008-08-12 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Dienstag, den 12.08.2008, 18:28 +0200 schrieb Felix Zielcke: > > Ok naming the old patch kern_err.diff and the new one raid_err.diff > isn't a good idea :( > > > 2008-08-12 Felix Zielcke <[EMAIL PROTECTED]> > > * kern/err.c [GRUB_UTIL]: In

ATAPI split-off

2008-08-12 Thread Marco Gerards
Hi, Here is a patch to remove the ATAPI code and add support for SCSI commands. I changed ata.c to use scsi.c. This results in cleaner, sharable code. Meanwhile, the hard coded disk size is removed, together with some other hacks. You can make me happy by testing this :-) -- Marco 2008-08

Re: [PATCH] New command checktime

2008-08-11 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Mon, Aug 11, 2008 at 2:04 AM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Hi, >> >> Bean <[EMAIL PROTECTED]> writes: >> >>> I implement this command for grub4dos some time ago, now it's ported

Re: [PATCH] add pkzip support for gzio

2008-08-11 Thread Marco Gerards
ur file is too small, pkzip will not compress it > but store the orginal data to the output file. Isn't this patented? -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] New command checktime

2008-08-10 Thread Marco Gerards
e scripting support in the first place. So can you please follow such scheme? -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Crypto Patch: Legal Issues

2008-08-09 Thread Marco Gerards
ible licenses and/or reassign > copyright? I was about the review Simon's patch. What is the best way to proceed. More than one person works on this and I am confused about how to deal with this. Would it help if Simons work got in first, or didn't you continue wi

Re: ATA update

2008-08-08 Thread Marco Gerards
d I forgot the Vista bootmgr file is 326 KB big, > so even with my (probable big) chunksize of 256 KB this file lies on > both disks. Can't raid.mod be used for this, somehow? -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: ATA update

2008-08-08 Thread Marco Gerards
ead > of the biosdisk.mod which works more then yeah BIOS ;) Hm? > I just tried to mount /dev/sda1 which is NTFS and syslog shows $MFT > corrupted (ntfs-3g). Also on biosdisk. > So I hope that GRUB will still have the biosdisk.mod for guys like

ATA update

2008-08-07 Thread Marco Gerards
pport. I have some code in that direction already, so you might not want to touch that now. -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: NEWS update

2008-08-07 Thread Marco Gerards
Christian Franke <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> I have just updated the NEWS file. Can you please look at it to see >> if I forgot something important? >> >> > Builds & runs out-of-the-box on Cygwin? Good one, can you please add i

NEWS update

2008-08-07 Thread Marco Gerards
Hi, I have just updated the NEWS file. Can you please look at it to see if I forgot something important? If someone can update DISTLIST, I will be *very* happy :-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org

Re: [PATCH] Fix infinite loop in grub_pit_wait()

2008-08-07 Thread Marco Gerards
outb ((grub_inb (TIMER2_REG_LATCH) & ~ TIMER2_SPEAKER) | TIMER2_GATE, > TIMER2_REG_LATCH); > + > + /* Wait. */ >while ((grub_inb (TIMER2_REG_LATCH) & TIMER2_LATCH) == 0x00); > + > + /* Disable timer2 gate and speaker. */ > + grub_outb (grub_inb (TIMER2_REG_LATCH) &am

Re: Remove conf/*.mk from svn

2008-08-05 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> Colin D Bennett <[EMAIL PROTECTED]> writes: >>> I think we should remove conf/*.mk from the Subversion repository. If >>> people are going to be developing on GRUB and checking out svn

Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Marco Gerards
Felix Zielcke <[EMAIL PROTECTED]> writes: > Am Dienstag, den 05.08.2008, 15:10 +0200 schrieb Marco Gerards: >> Felix Zielcke <[EMAIL PROTECTED]> writes: >> >> > 2008-08-05 Felix Zielcke <[EMAIL PROTECTED]> >> > >> >* partmap

Re: [PATCH] Home-End keys in menu

2008-08-05 Thread Marco Gerards
Hi, Carles Pina i Estany <[EMAIL PROTECTED]> writes: > Some weeks ago I sent a patch that didn't have any discussion. I'm > sending it again, maybe everybody was in holidays :-) > > Actually I updated the patch (added some spaces to comply with the > coding style). > > * menu/normal.c: Add Home a

Re: [PATCH] skip over invalid BSD partitions

2008-08-05 Thread Marco Gerards
t; + } Isn't a comma missing after the second string? I am surprised that this compiles. Or am I missing something? -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] High resolution time/TSC patch v3

2008-08-05 Thread Marco Gerards
Millan was interested in getting this patch merged for the > Coreboot port, so I decided to take another crack at it. > > Comments are welcome! I have just committed your patch, with the ChangeLog changes I proposed. Please have a look to

Re: [PATCH] Drivemap module

2008-08-05 Thread Marco Gerards
27;m not really bringing that issue, I was just joking, and in fact > I'm reconsidering my objections to the operator== arguments order rule, > even though I still consider my style safer and more sensible. If > someone else wants to express their opinion on that issue, do it fast >

Re: [PATCH] Drivemap module

2008-08-05 Thread Marco Gerards
rather be a jerk, than committing code that do not meet my expectations. But please understand, this contribution is highly appreciated. However, we want to have something maintainable for the far future as well :-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Drivemap module

2008-08-05 Thread Marco Gerards
Hi Javier, Javier Martín <[EMAIL PROTECTED]> writes: > El lun, 04-08-2008 a las 22:51 +0200, Marco Gerards escribió: >> Javier Martín <[EMAIL PROTECTED]> writes: >> >> > After your latest replay, I "reevaluated" my stubbornness WRT some of &g

Re: [PATCH] Test for files with ls

2008-08-05 Thread Marco Gerards
> > if ls /boot/grub/grub.cfg.gfx ; then > source /boot/grub/grub.cfg.gfx > fi > > I would be glad if you accept the patch or give me comments to improve > the patch. It would be better to add a "test" command. I have one sitting on my ha

Re: [PATCH] Fix color problem the grub-emu

2008-08-05 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Tue, Aug 5, 2008 at 6:15 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Hi, >> >> Bean <[EMAIL PROTECTED]> writes: >> >>> Currently, the color handling in grub-emu is broken, sometimes you see

Re: Bug#475718: Bug #475718 grub gets confused by hybrid apple/pc partmap

2008-08-05 Thread Marco Gerards
to MSDOS partitions. > > Btw, adding grub-devel to CC. Let's try to have discussions in upstream > list.. If I only know what you were talking about here... ;-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Remove conf/*.mk from svn

2008-08-05 Thread Marco Gerards
leased tarballs that we expect non-developers to use, we just need to > generate the *.mk files and include them in the tarball. I do not have problems with this. Besides this, it will stop people from sending in patches with .mk changes in it :-) -- Marco

Re: Remove conf/*.mk from svn

2008-08-05 Thread Marco Gerards
Hi, Christian Franke <[EMAIL PROTECTED]> writes: > For a release tarball, It IMO also makes sense to include > util/parser.tab.c. It is platform-independent and rarely changed. This > would remove bison from the list of prerequisites. Fine fo

Re: [PATCH] Misc patches for grub2

2008-08-05 Thread Marco Gerards
t should go into util/ When and how is it used? > 4. rename appleloader command to bootcamp > > The name appleloader may be a little confusing, bootcamp seems to be a > better choice. How about legacyloader or even legacy? Isn't that what it does without a

  1   2   3   4   5   6   7   8   9   10   >