Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-08-25 Thread Robert Millan
On Mon, Aug 24, 2009 at 05:45:15PM -0700, Joe Auricchio wrote: > On Sun, Aug 23, 2009 at 06:07, Robert Millan wrote: > > On Wed, Jul 22, 2009 at 10:42:54AM -0700, Joe Auricchio wrote: > >>> > >>> So perhaps this can be solved simpler by replacing grub_malloc with > >>> grub_zalloc ? > >> > >> I saw

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-08-24 Thread Joe Auricchio
On Sun, Aug 23, 2009 at 06:07, Robert Millan wrote: > On Wed, Jul 22, 2009 at 10:42:54AM -0700, Joe Auricchio wrote: >>> >>> So perhaps this can be solved simpler by replacing grub_malloc with >>> grub_zalloc ? >> >> I saw the zalloc commit and thought the same thing! :D I'll test it. But >> fg_col

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-08-23 Thread Robert Millan
On Wed, Jul 22, 2009 at 10:42:54AM -0700, Joe Auricchio wrote: >> >> So perhaps this can be solved simpler by replacing grub_malloc with >> grub_zalloc ? > > I saw the zalloc commit and thought the same thing! :D I'll test it. But > fg_color and bg_color must be set to the screen's current colors,

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-22 Thread Robert Millan
On Wed, Jul 22, 2009 at 10:42:54AM -0700, Joe Auricchio wrote: > > On 22 Jul, 2009, at 10:27 , Robert Millan wrote: > >> On Sat, Jul 18, 2009 at 03:39:00PM -0700, Joe Auricchio wrote: >>> >>> On 18 Jul, 2009, at 11:58 , Robert Millan wrote: On Sat, Jul 18, 2009 at 12:15:04AM -0700, Joe Auricch

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-22 Thread Joe Auricchio
On 22 Jul, 2009, at 10:27 , Robert Millan wrote: On Sat, Jul 18, 2009 at 03:39:00PM -0700, Joe Auricchio wrote: On 18 Jul, 2009, at 11:58 , Robert Millan wrote: On Sat, Jul 18, 2009 at 12:15:04AM -0700, Joe Auricchio wrote: This fixes a 100% reproducible and very annoying bug I've found: S

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-22 Thread Robert Millan
On Sat, Jul 18, 2009 at 03:39:00PM -0700, Joe Auricchio wrote: > > On 18 Jul, 2009, at 11:58 , Robert Millan wrote: >> On Sat, Jul 18, 2009 at 12:15:04AM -0700, Joe Auricchio wrote: >>> >>> This fixes a 100% reproducible and very annoying bug I've found: >>> Switch >>> to gfxterm and until your c

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-20 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jul 18, 2009 at 9:15 AM, Joe Auricchio wrote: > Hi, > > My first patch! Please be nice. Welcome aboard > > * src/term/gfxterm.c (grub_virtual_screen_setup): Clear out text_buffer > instead of leaving it uninitialized. > No needfor "src" part > This fixes a 100% reproducible and very annoyin

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-18 Thread Joe Auricchio
On 18 Jul, 2009, at 11:58 , Robert Millan wrote: On Sat, Jul 18, 2009 at 12:15:04AM -0700, Joe Auricchio wrote: This fixes a 100% reproducible and very annoying bug I've found: Switch to gfxterm and until your clear the screen or scroll, the last position of every line has a random junk c

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-18 Thread Robert Millan
On Sat, Jul 18, 2009 at 12:15:04AM -0700, Joe Auricchio wrote: > Hi, > > My first patch! Please be nice. > > * src/term/gfxterm.c (grub_virtual_screen_setup): Clear out text_buffer > instead of leaving it uninitialized. > > This fixes a 100% reproducible and very annoying bug I've found: Switch >

[PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-07-18 Thread Joe Auricchio
Hi, My first patch! Please be nice. * src/term/gfxterm.c (grub_virtual_screen_setup): Clear out text_buffer instead of leaving it uninitialized. This fixes a 100% reproducible and very annoying bug I've found: Switch to gfxterm and until your clear the screen or scroll, the last position of