On Fri, 2012-02-03 at 10:52 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> > zfs-on-linux-rlaager6.patch
> >
> >
> > Handle pool names with trailing spaces
> What about the ones with spaces in the middle? It feels like the logic
> is broken elsewhere and using strncmp is just a workaround w
On 02.02.2012 12:13, Richard Laager wrote:
Attached are two more patches to add to the stack.
Committed (see below for comments). Next time please attach ChangeLog
entry and use -p on diff.
-- Richard
zfs-on-linux-rlaager10.patch
Index: grub/util/grub-probe.c
On 31.01.2012 09:45, Richard Laager wrote:
Attached is a stack of trivial patches that apply*on top of* your
zfs.diff from 2012-01-29. They each deal with one logical change and
should be very easy to review.
After your original patch and this stack have been dealt with, I'll
submit an updated
Attached are two more patches to add to the stack.
--
Richard
Index: grub/util/grub-probe.c
===
--- grub.orig/util/grub-probe.c 2012-02-02 03:36:38.827815635 -0600
+++ grub/util/grub-probe.c 2012-02-02 03:39:22.727085000 -0600
@@ -32
Attached is a stack of trivial patches that apply *on top of* your
zfs.diff from 2012-01-29. They each deal with one logical change and
should be very easy to review.
After your original patch and this stack have been dealt with, I'll
submit an updated patch for native ZFS on Linux support, which
On 30.01.2012 02:22, Richard Laager wrote:
On Sat, 2012-01-28 at 13:51 +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
As for /proc/mounts : is there a reason to suppose that /proc/mounts
would work when /proc/self/mountinfo doesn't
/proc/self/mountinfo doesn't exist on older Linux kernels.
On Sat, 2012-01-28 at 13:51 +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> As for /proc/mounts : is there a reason to suppose that /proc/mounts
> would work when /proc/self/mountinfo doesn't
/proc/self/mountinfo doesn't exist on older Linux kernels. What is
upstream GRUB's minimum required
On 28.01.2012 19:33, Richard Laager wrote:
On Sat, 2012-01-28 at 13:51 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
Index: grub/util/grub.d/10_linux.in
===
--- grub.orig/util/grub.d/10_linux.in 2012-01-24 23:44:10.530591000
On 28.01.2012 19:40, Darik Horn wrote:
2012/1/28 Vladimir 'φ-coder/phcoder' Serbinenko:
I already commented on 10_linux.in changes. They are pretty sloppy. (mostly
is "it works for me and I don't care about other legitimate configs")
How do you want these things changed? I searched the email a
On 28.01.2012 19:33, Richard Laager wrote:
On Sat, 2012-01-28 at 13:51 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
Index: grub/util/grub.d/10_linux.in
===
--- grub.orig/util/grub.d/10_linux.in 2012-01-24 23:44:10.530591000
2012/1/28 Vladimir 'φ-coder/phcoder' Serbinenko :
>
> I already commented on 10_linux.in changes. They are pretty sloppy. (mostly
> is "it works for me and I don't care about other legitimate configs")
How do you want these things changed? I searched the email archive
and couldn't find where you
On Sat, 2012-01-28 at 13:51 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> > Index: grub/util/grub.d/10_linux.in
> > ===
> > --- grub.orig/util/grub.d/10_linux.in 2012-01-24 23:44:10.530591000
> > -0600
> > +++ grub/util/
On 28.01.2012 18:06, Darik Horn wrote:
2012/1/28 Richard Laager:
I tried to apply your patch to revision 3781 and got this:
util/grub-setup.c:541:12:
error 'struct grub_fs' has no member named 'blocklist_install'
This is not caused by the proposed zfs patch.
It is. blocklist_install from u
2012/1/28 Richard Laager :
> I tried to apply your patch to revision 3781 and got this:
>
> util/grub-setup.c:541:12:
> error 'struct grub_fs' has no member named 'blocklist_install'
This is not caused by the proposed zfs patch. The grub trunk fails to
build on Debian, Ubuntu, and OpenIndiana.
I tried to apply your patch to revision 3781 and got this:
util/grub-setup.c:541:12:
error 'struct grub_fs' has no member named 'blocklist_install'
--
Richard
signature.asc
Description: This is a digitally signed message part
___
Grub-devel maili
On 28.01.2012 03:50, Richard Laager wrote:
On Fri, 2012-01-27 at 14:04 -0500, Zachary Bedell wrote:
> I've had to forward port the other changes necessary to support build on
Linux.
I attach my zfs-related changed. I'll commit them before your patch and
it already covers most of issues
Att
On Fri, 2012-01-27 at 14:04 -0500, Zachary Bedell wrote:
> I've had to forward port the other changes necessary to support build on
> Linux.
Attached is the work I've done on this front. This includes the "allow
spaces in zpools" patch I previously submitted to grub-devel. And, the
changes in 10_
On 27.01.2012 20:04, Zachary Bedell wrote:
Thanks for plodding through my mess. It looks like the changes are committed
to trunk at this point, right? I'm trying to get a test together, but I've had
to forward port the other changes necessary to support build on Linux. I think
I have those
Thanks for plodding through my mess. It looks like the changes are committed
to trunk at this point, right? I'm trying to get a test together, but I've had
to forward port the other changes necessary to support build on Linux. I think
I have those changes done in a such a way as they won't co
I tested in a virtual machine on a pool with ashift=12 set. It works!
--
Richard
signature.asc
Description: This is a digitally signed message part
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
On Sun, 2012-01-22 at 15:18 +0100, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> I've cleaned this patch up (attached). Can you test it on these 4K FSes
> or tell me how to create one w/o really having such a disk?
I'll hopefully be able to do a test install today or tomorrow.
With ZFS on Linux
I've cleaned this patch up (attached). Can you test it on these 4K FSes
or tell me how to create one w/o really having such a disk?
On 19.01.2012 12:36, Richard Laager wrote:
static grub_err_t
-uberblock_verify (uberblock_phys_t * ub, int offset)
+uberblock_verify (uberblock_t * uber, int offs
Original mailing list thread:
http://lists.gnu.org/archive/html/grub-devel/2011-09/msg00031.html
On 2011-09-28, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Could you please split this patch? In particular the removing of dprintf
> takes to much of this patch and makes it unreadable. Note that w
On 19.09.2011 20:45, Zachary Bedell wrote:
> Greetings,
>
> In working with ZFSonLinux, I found myself with a number of somewhat
> inconstant pools which failed either when running grub-probe or at boot time.
> In all cases, these pools were importable by the ZFS driver and completed a
> `zpool
Could you please split this patch? In particular the removing of dprintf
takes to much of this patch and makes it unreadable. Note that we don't
comment out the code, we only remove it.
On 19.09.2011 20:45, Zachary Bedell wrote:
> Greetings,
>
> In working with ZFSonLinux, I found myself with a num
Greetings,
In working with ZFSonLinux, I found myself with a number of somewhat inconstant
pools which failed either when running grub-probe or at boot time. In all
cases, these pools were importable by the ZFS driver and completed a `zpool
scrub` with no errors reported, but still Grub wasn't
26 matches
Mail list logo
