Re: [PATCH v2] Track explicit module dependencies in Makefile.core.def

2024-03-03 Thread Oskari Pirhonen
On Wed, Feb 28, 2024 at 13:36:00 +0100, Oliver Steffen wrote: > Add a new keyword, "depends", to the module definition syntax > used in Makefile.core.def. This allows specifying explicit module > dependencies together with the module definition. > > Do not track the &qu

[PATCH v2] Track explicit module dependencies in Makefile.core.def

2024-02-28 Thread Oliver Steffen
Add a new keyword, "depends", to the module definition syntax used in Makefile.core.def. This allows specifying explicit module dependencies together with the module definition. Do not track the "extra_deps.lst" file in the repository anymore, it is now auto-generated.

Re: [RFC PATCH] Track explicit module dependencies in Makefile.core.def

2024-02-22 Thread Oskari Pirhonen
On Thu, Feb 22, 2024 at 14:32:31 +0100, Oliver Steffen wrote: > Add a new keyword, "depends", to the module definition syntax > used in Makefile.core.def. This allows specifying explicit module > dependencies together with the module definition. > > Do not track the &qu

Re: [RFC PATCH] Track explicit module dependencies in Makefile.core.def

2024-02-22 Thread Daniel Kiper
Adding Vladimir... On Thu, Feb 22, 2024 at 02:32:31PM +0100, Oliver Steffen wrote: > Add a new keyword, "depends", to the module definition syntax > used in Makefile.core.def. This allows specifying explicit module > dependencies together with the module definition. &

[RFC PATCH] Track explicit module dependencies in Makefile.core.def

2024-02-22 Thread Oliver Steffen
Add a new keyword, "depends", to the module definition syntax used in Makefile.core.def. This allows specifying explicit module dependencies together with the module definition. Do not track the "extra_deps.lst" file in the repository anymore, it is now auto-generated.

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-11 Thread Oliver Steffen
Quoting Julian Andres Klode (2023-12-08 18:29:52) > On Fri, Dec 08, 2023 at 01:20:37PM +0100, Daniel Kiper wrote: > > On Wed, Dec 06, 2023 at 05:39:53PM +0100, Daniel Kiper wrote: > > > On Wed, Dec 06, 2023 at 04:39:29PM +0100, Olaf Hering wrote: > > > > Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-08 Thread Julian Andres Klode
On Fri, Dec 08, 2023 at 01:20:37PM +0100, Daniel Kiper wrote: > On Wed, Dec 06, 2023 at 05:39:53PM +0100, Daniel Kiper wrote: > > On Wed, Dec 06, 2023 at 04:39:29PM +0100, Olaf Hering wrote: > > > Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper : > > > > > > > Could you provide us exact steps to reprod

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-08 Thread Daniel Kiper
On Wed, Dec 06, 2023 at 05:39:53PM +0100, Daniel Kiper wrote: > On Wed, Dec 06, 2023 at 04:39:29PM +0100, Olaf Hering wrote: > > Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper : > > > > > Could you provide us exact steps to reproduce the problem? > > > > Something like this? > > > > mkdir .b > > cd $_

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-06 Thread Daniel Kiper
On Wed, Dec 06, 2023 at 04:39:29PM +0100, Olaf Hering wrote: > Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper : > > > Could you provide us exact steps to reproduce the problem? > > Something like this? > > mkdir .b > cd $_ > ../grub-src-dir/configure [options] Ugh, yeah, the file is missing in this c

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-06 Thread Olaf Hering
Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper : > Could you provide us exact steps to reproduce the problem? Something like this? mkdir .b cd $_ ../grub-src-dir/configure [options] A brief look at the sources indicates the new file could be generated during build, with "echo content > $@". Ola

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-06 Thread Daniel Kiper
Hi Olaf, On Wed, Dec 06, 2023 at 09:19:06AM +0100, Olaf Hering wrote: > Thu, 16 Nov 2023 16:37:38 +0100 Oliver Steffen : > > > +syminfo.lst: gensyminfo.sh kernel_syms.lst extra_deps.lst $(MODULE_FILES) > > + cat kernel_syms.lst extra_deps.lst > $@.new > > There are rules to create gensyminfo.sh

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-06 Thread Olaf Hering
Thu, 16 Nov 2023 16:37:38 +0100 Oliver Steffen : > +syminfo.lst: gensyminfo.sh kernel_syms.lst extra_deps.lst $(MODULE_FILES) > + cat kernel_syms.lst extra_deps.lst > $@.new There are rules to create gensyminfo.sh and kernel_syms.lst, but there is no rule to create extra_deps.lst. As a resul

[PATCH v3 1/3] Allow explicit module dependencies

2023-11-16 Thread Oliver Steffen
The build system deduces inter-module dependencies from the symbols required and exported by the modules. This works well, except for some rare cases where the dependency is indirect or hidden. A module might not make use of any function of some other module, but still expect its functionality to

[PATCH v2 1/3] Allow explicit module dependencies

2023-11-15 Thread Oliver Steffen
The build system deduces inter-module dependencies from the symbols required and exported by the modules. This works well, except for some rare cases where the dependency is indirect or hidden. A module might not make use of any function of some other module, but still expect its functionality to

[PATCH 1/2] Allow explicit module dependencies

2023-11-14 Thread Oliver Steffen
The build system deduces inter-module dependencies from the symbols required and exported by the modules. This works well, except for some rare cases where the dependency is indirect or hidden. A module might not make use of any function of some other module, but still expect its functionality to

Re: Module dependencies

2023-11-10 Thread Daniel Kiper
Adding Vladimir... On Thu, Oct 19, 2023 at 04:50:10AM -0700, Oliver Steffen wrote: > Quoting Daniel Axtens (2023-10-05 08:07:47) > > (Unless anything has changed dramatically in the last year:) Dependencies > > are calculated automatically on the basis of symbols that you use in your > > module.

Re: Module dependencies

2023-10-19 Thread Daniel Axtens
> There is the problem with the new bli module, that it requires the > part_gpt module to be loaded beforehand, but the module dependency list > for bli is emplty (see moddep.lst). > > The part_gpt module only exports one function, > grub_gpt_partition_map_iterate(). This is not used in the bli m

Re: Module dependencies

2023-10-19 Thread Oliver Steffen
Quoting Daniel Axtens (2023-10-05 08:07:47) > (Unless anything has changed dramatically in the last year:) Dependencies are > calculated automatically on the basis of symbols that you use in your module. > If you look at genmoddep.awk and work out from there you can get a handle on > the process

Re: Module dependencies

2023-10-04 Thread Daniel Axtens
(Unless anything has changed dramatically in the last year:) Dependencies are calculated automatically on the basis of symbols that you use in your module. If you look at genmoddep.awk and work out from there you can get a handle on the process. If you only use symbols provided by the ‘kernel’,

Module dependencies

2023-10-04 Thread Oliver Steffen
Hi, Is there a way to specify dependencies for a module? As in a list of other modules that need to be loaded before? I found a macro named GRUB_MOD_DEP in dh.h, but when I use it in the module's .c file I get errors about a missing .moddeps section. It also does not seem to be in use anywhere.