rhaps we could leave that open and fill it in with a function, or
>> can we use a ld/gcc feature to do that? This will make the backtrace
>> code simpler and it saves memory. Do you think that is somehow
>> possible?
>
> This is true, another list of symbols is not
feature to do that? This will make the backtrace
code simpler and it saves memory. Do you think that is somehow
possible?
This is true, another list of symbols is not required for this backtrace
support but it makes the implementation a lot less intrusive. It would
be possible to use some
Hi,
I will make change to the patch according to these comments.
+void EXPORT_FUNC(grub_register_debug_sym) (const char*, void*,
grub_size_t);
+void EXPORT_FUNC(grub_unregister_debug_sym) (void *);
+int EXPORT_FUNC(grub_print_debug_sym) (grub_addr_t);
+void EXPORT_FUNC(grub_backtrace) (void
Vincent Guffens <[EMAIL PROTECTED]> writes:
Hi Vincent,
> Here is a new version of the backtrace support. I have written the
> ChangeLog and modified the code according to your advices.
Thanks a lot! Here are still some comments and questions about the
patch.
> To compile wit
On Monday 22 August 2005 23:23, Vincent Guffens wrote:
> +# For kern_debug.mod
> +kern_debug_mod_OTHERDEP = kern/grub_debug_kern.sym
> +kern_debug_mod_SOURCES = kern/kern_debug.c
> +kern_debug_mod_CFLAGS = $(COMMON_CFLAGS)
I think it is a really good idea to make a variable for dependencies, but
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Vincent Guffens wrote:
> This is a problem because I would say that it breaks compilation for
> other architectures. I think that the other architectures should have a
> function grub_backtrace() that does nothing, or even better that really
> does pri
Here is a new version of the backtrace support. I have written the
ChangeLog and modified the code according to your advices.
To compile with the backtrace support use ./configure --with-debug and
load grub2 with the kern_debug module. The kern module will be unloaded
automatically after
On Thursday 18 August 2005 23:19, Vincent Guffens wrote:
> cool ! I will wait a little bit for your comments and those from Okuji
> as there are a few changes I made that I'm not sure if they are very
> clean, especially those in genmk.rb.
Good job, Vincent.
> I used some "cat config.h" and
> ma
eady existing
symbol list but that way, it does not modify anything if the backtrace
support is not compiled in.
Should the Changelog entries be included in the patch or is it generated
with the cvs log and it should then be sent in the mail body ?
_
Vincent Guffens <[EMAIL PROTECTED]> writes:
Hi Vincent,
> After having searched for the reason of the unaligned pointer caused
> by the nested functions bug, I thought that it could be interesting to
> have a backtrace in grub. It would be triggered in grub_fatal and
> would print the last few fu
ub2/btmake grub2-backtrace/btmake
--- grub2/btmake1970-01-01 01:00:00.0 +0100
+++ grub2-backtrace/btmake 2005-08-18 18:48:36.0 +0200
@@ -0,0 +1,9 @@
+#!/bin/sh
+# Create a grub kernel image with backtrace support
+# configure must have been run with : --with-backtrace
+make
11 matches
Mail list logo