Re: gettextize normal/menu_text.c (print_timeout)

2009-11-25 Thread Robert Millan
On Wed, Nov 25, 2009 at 10:54:22PM +, Carles Pina i Estany wrote: > > I thought that Robert wanted to have 3 strings to translate, one per > line, not one long dynamic string. Not at all! That would be even worse :-) The problem is if we don't remove the newlines, we're putting a burden on t

Re: gettextize normal/menu_text.c (print_timeout)

2009-11-25 Thread Carles Pina i Estany
Hi, On Nov/25/2009, Vladimir '??-coder/phcoder' Serbinenko wrote: > Carles Pina i Estany wrote: > > Hi, > > > > On Nov/25/2009, Robert Millan wrote: > > > >> On Wed, Nov 25, 2009 at 12:30:59AM +, Carles Pina i Estany wrote: > >> > >>> BTW, I left spaces on the left of lot of strings.

Re: gettextize normal/menu_text.c (print_timeout)

2009-11-25 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Carles Pina i Estany wrote: > Hi, > > On Nov/25/2009, Robert Millan wrote: > >> On Wed, Nov 25, 2009 at 12:30:59AM +, Carles Pina i Estany wrote: >> >>> BTW, I left spaces on the left of lot of strings. In my opinion I would >>> delete it and call print_spaces(3);. Fine? (or call grub_p

Re: gettextize normal/menu_text.c (print_timeout)

2009-11-25 Thread Carles Pina i Estany
Hi, On Nov/25/2009, Robert Millan wrote: > On Wed, Nov 25, 2009 at 12:30:59AM +, Carles Pina i Estany wrote: > > BTW, I left spaces on the left of lot of strings. In my opinion I would > > delete it and call print_spaces(3);. Fine? (or call grub_printf (" "); > > ). > > Yes. ok! > > -

Re: gettextize normal/menu_text.c (print_timeout)

2009-11-25 Thread Robert Millan
On Wed, Nov 25, 2009 at 12:30:59AM +, Carles Pina i Estany wrote: > BTW, I left spaces on the left of lot of strings. In my opinion I would > delete it and call print_spaces(3);. Fine? (or call grub_printf (" "); > ). Yes. > - grub_printf ("\n\ > + grub_printf (_("\ >Minim

Re: gettextize normal/menu_text.c (print_timeout)

2009-11-24 Thread Carles Pina i Estany
Hi, On Nov/25/2009, Carles Pina i Estany wrote: > > Hi, > > > > + const char *msg_localized = _(" The highlighted entry will be booted > > > automatically in %ds."); > > > + const int msg_localized_len = grub_strlen (msg_localized); > > > + const int number_spaces = GRUB_TERM_WIDTH - msg_

Re: gettextize normal/menu_text.c (print_timeout)

2009-11-24 Thread Carles Pina i Estany
Hi, > > + const char *msg_localized = _(" The highlighted entry will be booted > > automatically in %ds."); > > + const int msg_localized_len = grub_strlen (msg_localized); > > + const int number_spaces = GRUB_TERM_WIDTH - msg_localized_len; > > Seems like the right approach. I wonder if

Re: gettextize normal/menu_text.c (print_timeout)

2009-11-23 Thread Robert Millan
On Sun, Nov 22, 2009 at 11:50:13PM +, Carles Pina i Estany wrote: > === modified file 'normal/menu_text.c' > --- normal/menu_text.c2009-11-22 22:24:54 + > +++ normal/menu_text.c2009-11-22 23:40:20 + > @@ -262,12 +262,34 @@ >return entry; > } > > +static char* > +g

gettextize normal/menu_text.c (print_timeout)

2009-11-22 Thread Carles Pina i Estany
Hello, Attached a proposal of gettextize for normal/menu_text.c -- 2009-11-22 Carles Pina i Estany * normal/menu_text.c (get_spaces): New function. (print_timeout): Gettexttize and uses get_spaces. -- If accepted I can combine with the previous patch gettextizing some