Re: how to increase commandline size (patch + changelog)

2006-10-13 Thread Yoshinori K. Okuji
On Tuesday 10 October 2006 19:17, Jeff Chua wrote: > On Tue, 10 Oct 2006, Marco Gerards wrote: > > Hollis Blanchard <[EMAIL PROTECTED]> writes: > >> What exactly happens if we give the kernel a longer cmdline than it > >> supports? Does it just truncate, or fail to boot? > > > > It truncates. > > >

Re: how to increase commandline size (patch + changelog)

2006-10-10 Thread Jeff Chua
On Tue, 10 Oct 2006, Marco Gerards wrote: Hollis Blanchard <[EMAIL PROTECTED]> writes: What exactly happens if we give the kernel a longer cmdline than it supports? Does it just truncate, or fail to boot? It truncates. Why not allow users to pass as much as they want, and just warn them if

Re: how to increase commandline size (patch + changelog)

2006-10-10 Thread Marco Gerards
Hollis Blanchard <[EMAIL PROTECTED]> writes: > On Tue, 2006-10-10 at 16:38 +0200, Marco Gerards wrote: >> >> - Add some run-time argument to the loader to override the command >> line length. But I do not like this either because it allows >> breaking the Linux boot protocol. > > What exact

Re: how to increase commandline size (patch + changelog)

2006-10-10 Thread Hollis Blanchard
On Tue, 2006-10-10 at 16:38 +0200, Marco Gerards wrote: > > - Add some run-time argument to the loader to override the command > line length. But I do not like this either because it allows > breaking the Linux boot protocol. What exactly happens if we give the kernel a longer cmdline than

Re: how to increase commandline size (patch + changelog)

2006-10-10 Thread Marco Gerards
Jeff Chua <[EMAIL PROTECTED]> writes: > On Tue, 10 Oct 2006, Marco Gerards wrote: > >> Isn't it possible to use the kernel binary to determine this? For >> example, is the maximum commandline size stored somewhere? Perhaps, >> we can determine it by looking at some version field? According to >

Re: how to increase commandline size (patch + changelog)

2006-10-10 Thread Markus Laire
On 10/10/06, Jeff Chua <[EMAIL PROTECTED]> wrote: Agree. So, standard 255 is ok, but then it'll be nice to allow user to compile "grub2" to expand the commandline. I don't know whether any distributions expand more than 255 characters. At least Knoppix 4.0.2 uses a patch to extend the boot comm

Re: how to increase commandline size (patch + changelog)

2006-10-10 Thread Jeff Chua
On Tue, 10 Oct 2006, Marco Gerards wrote: Isn't it possible to use the kernel binary to determine this? For example, is the maximum commandline size stored somewhere? Perhaps, we can determine it by looking at some version field? According to the documentation it is has a maximum length of 25

Re: how to increase commandline size (patch + changelog)

2006-10-09 Thread Marco Gerards
Jeff Chua <[EMAIL PROTECTED]> writes: > On Mon, 9 Oct 2006, Hollis Blanchard wrote: > >>> Shall I use '#ifdef __linux__' to include only on linux, and >>> '#define COMMAND_LINE_SIZE 255' for non-linux system? >> > 5B> Well, does this number change often? If not, let's just copy it. >> >> If so, t

Re: how to increase commandline size (patch + changelog)

2006-10-09 Thread Marco Gerards
Hollis Blanchard <[EMAIL PROTECTED]> writes: > On Tue, 2006-10-10 at 11:08 +0800, Jeff Chua wrote: >> On Mon, 9 Oct 2006, Hollis Blanchard wrote: >> >> >> +#include >> > >> > I don't think this is a good idea because it requires we build on a >> > Linux host. >> >> Shall I use '#ifdef __linux__

Re: how to increase commandline size (patch + changelog)

2006-10-09 Thread Jeff Chua
On Mon, 9 Oct 2006, Hollis Blanchard wrote: Shall I use '#ifdef __linux__' to include only on linux, and '#define COMMAND_LINE_SIZE 255' for non-linux system? 5B> Well, does this number change often? If not, let's just copy it. If so, then we're screwed anyways because asm/param.h would o

Re: how to increase commandline size (patch + changelog)

2006-10-09 Thread Hollis Blanchard
On Tue, 2006-10-10 at 11:08 +0800, Jeff Chua wrote: > On Mon, 9 Oct 2006, Hollis Blanchard wrote: > > >> +#include > > > > I don't think this is a good idea because it requires we build on a > > Linux host. > > Shall I use '#ifdef __linux__' to include only on linux, and > '#define COMMAND_LINE

Re: how to increase commandline size (patch + changelog)

2006-10-09 Thread Jeff Chua
On Mon, 9 Oct 2006, Hollis Blanchard wrote: +#include I don't think this is a good idea because it requires we build on a Linux host. Shall I use '#ifdef __linux__' to include only on linux, and '#define COMMAND_LINE_SIZE 255' for non-linux system? Sorry, I only thought of using grub2 on

Re: how to increase commandline size (patch + changelog)

2006-10-09 Thread Hollis Blanchard
On Tue, 2006-10-10 at 09:03 +0800, Jeff Chua wrote: > > +#include I don't think this is a good idea because it requires we build on a Linux host. -Hollis ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-deve

Re: how to increase commandline size (patch + changelog)

2006-10-09 Thread Jeff Chua
On Tue, 10 Oct 2006, Jeff Chua wrote: Here's with ChangeLog included. On Sun, 8 Oct 2006, Marco Gerards wrote: It seems to stop at 256 characters counting the input length That's weird. Could you please have a look at loader/i386/pc/linux.c to see if it gets the entire line or just a pa