Re: GConverter commited

2009-11-24 Thread Alexander Larsson
On Mon, 2009-11-23 at 17:22 +0100, Alexander Larsson wrote: On Mon, 2009-11-23 at 10:52 -0500, Behdad Esfahbod wrote: On 11/23/2009 10:30 AM, Alexander Larsson wrote: Please check out this API and give comments on it. I think its pretty good, as we've talked about this a bit on irc

Re: GConverter commited

2009-11-24 Thread Alexander Larsson
On Mon, 2009-11-23 at 21:57 -0600, Shaun McCance wrote: I'll be using the bzip2 and lzma converters in Yelp. I'm not sure about the magic converter. I might just throw it away and go off the file name. The magic detection is not suitable for general use, though I think it's OKish for Yelp.

Re: GConverter commited

2009-11-24 Thread Behdad Esfahbod
On 11/24/2009 03:29 AM, Alexander Larsson wrote: On Mon, 2009-11-23 at 17:22 +0100, Alexander Larsson wrote: On Mon, 2009-11-23 at 10:52 -0500, Behdad Esfahbod wrote: On 11/23/2009 10:30 AM, Alexander Larsson wrote: Please check out this API and give comments on it. I think its pretty good,

Re: GConverter commited

2009-11-24 Thread Behdad Esfahbod
On 11/24/2009 03:36 AM, Alexander Larsson wrote: On Mon, 2009-11-23 at 21:57 -0600, Shaun McCance wrote: I'll be using the bzip2 and lzma converters in Yelp. I'm not sure about the magic converter. I might just throw it away and go off the file name. The magic detection is not suitable for

Re: GConverter commited

2009-11-24 Thread Alexander Larsson
On Tue, 2009-11-24 at 04:22 -0500, Behdad Esfahbod wrote: Anyway, since I was one of the people wanting this, I thought I'd share my first experiences with it. I'm curious what other people would like to do about GConverters for other compression schemes. The code is simple enough that

Re: GConverter commited

2009-11-24 Thread Christian Dywan
Am Tue, 24 Nov 2009 11:16:19 +0100 schrieb Alexander Larsson al...@redhat.com: On Tue, 2009-11-24 at 04:22 -0500, Behdad Esfahbod wrote: Anyway, since I was one of the people wanting this, I thought I'd share my first experiences with it. I'm curious what other people would like to

Re: GConverter commited

2009-11-24 Thread Alexander Larsson
On Tue, 2009-11-24 at 11:43 +0100, Christian Dywan wrote: However, in this particular case if we had the plugin system cache i wouldn't mind having a basic uncompression GConverter that used magic sniffing and modules for extending to new forms of compression. I have to wonder how

GTKTreeView navigation improvement

2009-11-24 Thread Andrey M
Hi gtk-devel-list, First time submitting a patch to gnome, so bear with me. I've included a patch that should greatly enhance the usability of GTKTreeView. Currently the keyboard navigation of GTKTreeView is a bit cumbersome, collapsing nodes is frustrating because the user has to either click on

Re: GTKTreeView navigation improvement

2009-11-24 Thread Kristian Rietveld
On Mon, Nov 23, 2009 at 8:18 AM, Andrey M admar...@gmail.com wrote: Currently the keyboard navigation of GTKTreeView is a bit cumbersome, collapsing nodes is frustrating because the user has to either click on the collapse arrow or select the parent node and Shift+Left on it. Are you aware

Re: GConverter commited

2009-11-24 Thread Shaun McCance
On Tue, 2009-11-24 at 09:36 +0100, Alexander Larsson wrote: On Mon, 2009-11-23 at 21:57 -0600, Shaun McCance wrote: I'll be using the bzip2 and lzma converters in Yelp. I'm not sure about the magic converter. I might just throw it away and go off the file name. The magic detection is

Re: GConverter commited

2009-11-24 Thread Bastien Nocera
On Tue, 2009-11-24 at 10:09 -0600, Shaun McCance wrote: snip I don't disagree. Is there a place to plop this code for people to pick it up? I'll be putting at least the bz2 and lzma converters into Yelp soon (or possibly an xv converter instead of the lzmadec-based one). I'm still

[REMINDER] GTK+ IRC Team meeting - 2009-11-24

2009-11-24 Thread Emmanuele Bassi
hi everyone; this is a reminder for the GTK+ team IRC meeting: ◦ date: 2009-11-24 ◦ time: 20:00 UTC [0] ◦ channel: #gtk-devel on irc.gnome.org ◦ agenda: • CodyRussell: Client-side decorations, RGBA windows GTK+/ClientSideDecorations • CarlosGarnacho: MPX awesomeness GTK+/MPX • Drop

Re: GTKTreeView navigation improvement

2009-11-24 Thread Andrey M
Hi Kris, Thanks for your quick reply. Are you aware that there is a key binding bound to backspace that is in charge of selecting the parent node? I was unaware about backspace and none of the following searches yielded any usable results: (0 hits)

Re: GTKTreeView navigation improvement

2009-11-24 Thread Martin Nordholts
Andrey M wrote: I've included a patch that should greatly enhance the usability of GTKTreeView. Hi, Just two spontaneous comments: 1. You should provide regression tests for this feature (tests/testtree*) 2. You are introducing C++ comments (//) but the core code should use C-style comments

Re: GTKTreeView navigation improvement

2009-11-24 Thread Martin Nordholts
Andrey M wrote: Just two spontaneous comments: 1. You should provide regression tests for this feature (tests/testtree*) What are those? I'm not changing any structures or declaring any new variables. I don't understand. If someone makes changes that breaks your new feature, there should be

Re: GTKTreeView navigation improvement

2009-11-24 Thread Andrey M
If someone makes changes that breaks your new feature, there should be regression tests that detects this. To run tests you do 'make check'. I don't know how to do that (or if it even applies to this). Additionally, as long as the functionality of the following remains the same (as of

Re: GConverter commited

2009-11-24 Thread Shaun McCance
On Tue, 2009-11-24 at 16:22 +, Bastien Nocera wrote: On Tue, 2009-11-24 at 10:09 -0600, Shaun McCance wrote: snip I don't disagree. Is there a place to plop this code for people to pick it up? I'll be putting at least the bz2 and lzma converters into Yelp soon (or possibly an xv

Minutes of the GTK+ Team Meeting - 2009-11-27

2009-11-24 Thread Emmanuele Bassi
= minutes for the 2009-11-27 meeting = 1. client-side decorations, RGBA windows [bratsche] - bratsche has time to finish the work on csd - currently targeting gtk+ 2.20 - some fallout in nautilus/gnome-bg - Google is interested in csd for Chromium (browser) - there's the potential for some abuse,

Re: GConverter commited

2009-11-24 Thread Shaun McCance
On Tue, 2009-11-24 at 17:20 -0500, Behdad Esfahbod wrote: On 11/24/2009 11:09 AM, Shaun McCance wrote: So with my implementation, by the time you get to the magic, you've already set up a GConverterInputStream with the magic decompressor. If the stream turns out to be uncompressed,

Re: GConverter commited

2009-11-24 Thread Alexander Larsson
On Tue, 2009-11-24 at 10:09 -0600, Shaun McCance wrote: On Tue, 2009-11-24 at 09:36 +0100, Alexander Larsson wrote: I'm not sure why you'd need this, you just don't add a GConverterInputStream in that case. Well, the way I did the magic was with a GConverter that inspects its data the

Re: Minutes of the GTK+ Team Meeting - 2009-11-27

2009-11-24 Thread Kristian Rietveld
On Tue, Nov 24, 2009 at 11:13 PM, Emmanuele Bassi eba...@gmail.com wrote: 4. Implement finger and kinetic scrolling [jjardon] - Midori has a finger/kinetic scrolled window implementation - Hildon has one as well - OpenMoko had one - would it make sense to port the feature to GtkScrolledWindow