Re: let g_warn_if_fail replace g_assert

2007-10-19 Thread Tim Janik
On Fri, 19 Oct 2007, Federico Mena Quintero wrote: > On Wed, 2007-10-17 at 11:56 +0200, Tim Janik wrote: >> - extend the g_assert() docs to note that: >>1) programmers are more likely to want to use g_warn_if_fail instead >> (particularly for libraries, allthough the destabilizing effect

Re: let g_warn_if_fail replace g_assert

2007-10-19 Thread Federico Mena Quintero
On Wed, 2007-10-17 at 11:56 +0200, Tim Janik wrote: > - extend the g_assert() docs to note that: >1) programmers are more likely to want to use g_warn_if_fail instead > (particularly for libraries, allthough the destabilizing effects > of g_assert are also worth avoiding in applicai

Re: let g_warn_if_fail replace g_assert

2007-10-19 Thread Yevgen Muntyan
Tim Janik wrote: > hey All. > > proposing to turn g_asert into a warning: >http://mail.gnome.org/archives/gtk-devel-list/2007-October/msg00053.html > was obviously not perceived too well. > > as i read it, most people are not against my basic > reasoning, but are clearly in favour of adding > g

Re: let g_warn_if_fail replace g_assert

2007-10-18 Thread Brian J. Tarricone
Armin Burgmeier wrote: > I think the proposal is that g_warn_if_fail() shall return (in contrast > to g_assert(), which most of the time aborts the program), but it shall > not return from the function calling it. g_warn_if_fail() is supposed to > do exactly what its name implies: Just print a war

Re: let g_warn_if_fail replace g_assert

2007-10-18 Thread Armin Burgmeier
On Wed, 2007-10-17 at 09:44 -0700, Brian J. Tarricone wrote: > Marco Barisione wrote: > > Il giorno mer, 17/10/2007 alle 11.56 +0200, Tim Janik ha scritto: > >> - add g_warn_if_fail (condition); which produces a critical > >>warning about failing assertions but contrary to g_assert > >>ret

Re: let g_warn_if_fail replace g_assert

2007-10-17 Thread Brian J. Tarricone
Marco Barisione wrote: > Il giorno mer, 17/10/2007 alle 11.56 +0200, Tim Janik ha scritto: >> - add g_warn_if_fail (condition); which produces a critical >>warning about failing assertions but contrary to g_assert >>returns. > > If it's called g_warn_if_fail() I would expect a g_warning()

Re: let g_warn_if_fail replace g_assert

2007-10-17 Thread Marco Barisione
Il giorno mer, 17/10/2007 alle 11.56 +0200, Tim Janik ha scritto: > - add g_warn_if_fail (condition); which produces a critical >warning about failing assertions but contrary to g_assert >returns. If it's called g_warn_if_fail() I would expect a g_warning() not a g_critical(). -- Marco B

let g_warn_if_fail replace g_assert

2007-10-17 Thread Tim Janik
hey All. proposing to turn g_asert into a warning: http://mail.gnome.org/archives/gtk-devel-list/2007-October/msg00053.html was obviously not perceived too well. as i read it, most people are not against my basic reasoning, but are clearly in favour of adding g_warn_if_fail or a similar varian