Christian Biere <[EMAIL PROTECTED]> wrote:
clayton rollins wrote:
> On May 25, 2004, Christian Biere <[EMAIL PROTECTED]> wrote:
> >the GTK+ 1.2 interface lately. Anyway, currently I'm using the GTK+ 2.x
> >interface to do a little debugging. It turned out that "Abort all by
> >..." doesn't really w
clayton rollins wrote:
> On May 25, 2004, Christian Biere <[EMAIL PROTECTED]> wrote:
> >the GTK+ 1.2 interface lately. Anyway, currently I'm using the GTK+ 2.x
> >interface to do a little debugging. It turned out that "Abort all by
> >..." doesn't really work and sometimes the CPU usage is really h
Bill Pringlemeir wrote:
> Everything looks ok when it is explained. Maybe if anyone revisits
> the file they could consider,
>
>void prop_load_from_file(
>prop_set_t *ps, const gchar *dir, const gchar *filename)
> ...
>char * saved_local = setlocale(LC_CTYPE, NULL);
>
Hi,
Around christmas I added grouped downloads to gtk2. This is what I know
about the grouped dl's stuff, if you're not talking about that or if
this part of the code has changed drastically since then, I apologize (I
haven't been coding on gtkg much at all since then).
I think that when I left
On May 25, 2004, Christian Biere <[EMAIL PROTECTED]> wrote:
Hi,
I don't use GTKG often as an "user" (believe it or not) and I had used
the GTK+ 1.2 interface lately. Anyway, currently I'm using the GTK+ 2.x
interface to do a little debugging. It turned out that "Abort all by
..." doesn't really wor
Bill Pringlemeir wrote:
>> [props.c 1.39: line 1394]
>> - while ((c = (guchar) *s) != '\0' && isascii(c) && isblank(c))
>> + while ((c = (guchar) *s) != '\0' && isblank(c))
>> s++;
>> If c is "blank", it is also ascii? Isn't that right? I don't
>> think there are UTF type blanks.
Hi,
I don't use GTKG often as an "user" (believe it or not) and I had used
the GTK+ 1.2 interface lately. Anyway, currently I'm using the GTK+ 2.x
interface to do a little debugging. It turned out that "Abort all by
..." doesn't really work and sometimes the CPU usage is really high for
a few seco
Christian Biere wrote:
> Bill Pringlemeir wrote:
> > > If that analysis is correct, then the same thing applies to
> > > routing.c.
> Thanks, I've removed the unnecessary newlines.
Oops, sorry for misspelling your name in the CVS commit message.
Christian
pgpAwj4erxU2s.pgp
Description: PGP sig
Bill Pringlemeir wrote:
> Ok. I guess you got the routing.c and the one line in props.c as
> well?
There were even two lines - fixed.
> It is much easier to be a critic than an artist.
Well, thanks a lot for double-checking the recent commits.
> I especially like
> the removal of the all the s
Bill Pringlemeir wrote:
> > If that analysis is correct, then the same thing applies to
> > routing.c.
Thanks, I've removed the unnecessary newlines.
> [props.c 1.39: line 1357]
> - static const char fmt[] = "Bad line %u in config file, ignored\n";
> + static const char fmt[] = "Bad line
Bill Pringlemeir wrote:
> An extra semi-colon was added when the GCC format check was added.
Thanks, fixed. IIRC, an extra semi-colon isn't allowed in C99 but I
can't find the appropriate statement.
Christian
pgppIc6OVCrdA.pgp
Description: PGP signature
Bill Pringlemeir wrote:
> The `Replaced "%lx" by proper "%p".' is a good thing, but I think that
> all printf/sprintf/etc implementations prepend a "0x".
Strictly speaking, the output of %p is implementation-defined but of course
your right that I accidently didn't remove "0x". Thanks, fixed.
Chr
On Mon, 24 May 2004, [EMAIL PROTECTED] wrote:
> Thanks. I've just committed a patch to remove the newlines as they
> are no longer needed when using g_warning.
Ok. I guess you got the routing.c and the one line in props.c as
well?
[props.c 1.39: line 1357]
- static const char fmt[] = "Bad
On 24 May 2004, [EMAIL PROTECTED] wrote:
>
> On 24 May 2004, [EMAIL PROTECTED] wrote:
>>
>> In the latest changeset, several file had newlines removed when
>> using the "g_warning()" function. The latest changes to sockets.c
>> removed the "show_error()" function. All of the changes kept the
>>
Richard Eckart wrote:
> g_warning() and friends automatically add a line break.
I think that was his point.
Christian
pgpe9xNGib5Qh.pgp
Description: PGP signature
On 24 May 2004, Bill Pringlemeir wrote:
>
> In the latest changeset, several file had newlines removed when
> using the "g_warning()" function. The latest changes to sockets.c
> removed the "show_error()" function. All of the changes kept the
> newline characters in the string data. For example
On 24 May 2004, [EMAIL PROTECTED] wrote:
>
> In the latest changeset, several file had newlines removed when
> using the "g_warning()" function. The latest changes to sockets.c
> removed the "show_error()" function. All of the changes kept the
> newline characters in the string data. For examp
Hi
g_warning() and friends automatically add a line break.
Richard
Am Mo, den 24.05.2004 schrieb Bill Pringlemeir um 20:18:
> In the latest changeset, several file had newlines removed when using
> the "g_warning()" function. The latest changes to sockets.c removed
> the "show_error()" function
An extra semi-colon was added when the GCC format check was added.
[gmsg.h 1.18: line 61]
void gmsg_log_bad(struct gnutella_node *n,
- gchar *reason, ...) G_GNUC_PRINTF(2, 3);;
+ gchar *reason, ...) G_GNUC_PRINTF(2, 3);
Nit picking, as it doesn't affect anything visible t
In the latest changeset, several file had newlines removed when using
the "g_warning()" function. The latest changes to sockets.c removed
the "show_error()" function. All of the changes kept the newline
characters in the string data. For example,
[Sockets.c 1.115: line 1585]
- g_
CVS logs say,
revision 1.81
date: 2004/05/24 04:15:11; author: cbiere; state: Exp; lines: +8 -7
FUZZY_DROP and FUZZY_MATCH were accidently defined as zero.
dmesh_url_strerror(): Fixed too weak assertion.
Replaced "%lx" by proper "%p".
The `Replaced "%lx" by proper
21 matches
Mail list logo
