Re: Questionable "cosmetic changes" commits

2020-12-02 Thread Bengt Richter
Hi Ryan, Mark, et al, On +2020-12-02 20:13:56 +, Ryan Prior wrote: > Hi Mark! > > On December 2, 2020, Mark H Weaver wrote: > > We all have our own personal preferences of how best to indent scheme > > code, but if more of us adopted the habit of needlessly reordering > > fields and

Re: Questionable "cosmetic changes" commits

2020-12-02 Thread Mark H Weaver
Hi Ryan, Ryan Prior writes: > I do think it's important to acknowledge that the commits written by > Raghav were part of his internship and advised by his mentors who signed > off on the commits, so it's not like these changes were unsolicited and > materialized out of nowhere. If those

Re: Questionable "cosmetic changes" commits

2020-12-02 Thread Hartmut Goebel
Hi Martin, Am 02.12.20 um 19:55 schrieb Mark H Weaver: > I think that commits like this are best avoided for several reasons. […] > Should I change those things back the next time I update that package? My main project (PyInstaller) has the policy to not accept any white-space changes and

Re: Questionable "cosmetic changes" commits

2020-12-02 Thread Tobias Geerinckx-Rice
Ryan Prior 写道: I don't particularly hold any opinion about stylistic commits except that I prefer tools like gofmt, Python's Black and standard.js which enforce uniform code style, and would use such a tool for my Guile code if it exists. Guix already has a uniform code formatter -- GNU

[support-re...@gandi.net: [GANDI] guixsd.org expires in 60 days]

2020-12-02 Thread Andreas Enge
Hello all, just for your information, our domain name guixsd.org will expire soon (how many out there still remember that we own it?). We decided last year to renew it for just one more year and to let it run out. So if we still have anything pointing there, it would be good to change it now.

Re: Questionable "cosmetic changes" commits

2020-12-02 Thread Ryan Prior
Hi Mark! On December 2, 2020, Mark H Weaver wrote: > We all have our own personal preferences of how best to indent scheme > code, but if more of us adopted the habit of needlessly reordering > fields and reindenting code of every package we touch, as one of us > seems to have done, it could get

Questionable "cosmetic changes" commits

2020-12-02 Thread Mark H Weaver
Hello fellow Guix, In recent months there have been several "cosmetic changes" commits that I find questionable. These commits reorder package fields and reindent code that was already ordered and indented according to our conventions, apparently in order to match the author's personal

Poetry upgrade and related packages

2020-12-02 Thread Sébastien Lerique
Dear all, This thread is an attempt to keep a handle on the various patches involved in upgrading Poetry to 1.1.4, and to ask a couple questions that crop up. - Tanguy's original patch http://issues.guix.info/44077 is merged - But python-packaging had to be downgraded again because it

Re: 01/07: gnu: python-packaging: Update to 20.4.

2020-12-02 Thread Tanguy LE CARROUR
Hi Marius! Excerpts from Tanguy LE CARROUR's message of December 2, 2020 8:56 am: > Excerpts from Marius Bakke's message of December 2, 2020 12:10 am: >> guix-comm...@gnu.org skriver: >> >>> ngz pushed a commit to branch master >>> in repository guix. >>> >>> commit

Re: Welcome to Grub!... for a minute

2020-12-02 Thread Yasuaki Kudo
Hi Everyone, Thank for responding - I was just experimenting with repeated guix pull and build commands (because the "proprietary" packages in those separate channels take ages to compile) In retrospect, this lead me to realize that instead of guix system reconfigure, I could just do guix