On Sun, Nov 20, 2016 at 06:02:59PM +0100, Marius Bakke wrote:
> Sorry for the delay, PHP is in master now!
Wow, thanks to everyone who worked on this!
signature.asc
Description: PGP signature
Marius Bakke skribis:
> Marius Bakke writes:
>
> Failures in tests caused by external gd are not too serious to
> require us to switch to the bundled one I think. We may not even
> need to patch our libgd with php specific patches, since the
> failures are only slight deviati
Marius Bakke writes:
>>> > Failures in tests caused by external gd are not too serious to
>>> > require us to switch to the bundled one I think. We may not even
>>> > need to patch our libgd with php specific patches, since the
>>> > failures are only slight deviation from the spec on corner case
Julien Lepiller writes:
> On Thu, 17 Nov 2016 21:43:39 +0100
> Marius Bakke wrote:
>
>> Julien Lepiller writes:
>>
>> >> >> Unfortunately that only fixed a handful of tests, the remaining
>> >> >> 50-something had to be disabled for a variety of reasons.
>> >> >>
>> >> >> I've added a comment
On Thu, 17 Nov 2016 21:43:39 +0100
Marius Bakke wrote:
> Julien Lepiller writes:
>
> >> >> Unfortunately that only fixed a handful of tests, the remaining
> >> >> 50-something had to be disabled for a variety of reasons.
> >> >>
> >> >> I've added a commentary to each disabled test. If you rec
Julien Lepiller writes:
>> >> Unfortunately that only fixed a handful of tests, the remaining
>> >> 50-something had to be disabled for a variety of reasons.
>> >>
>> >> I've added a commentary to each disabled test. If you recognize
>> >> any of these errors/think you know what's going on, plea
On Thu, 17 Nov 2016 11:22:53 +0100
Hartmut Goebel wrote:
> Am 17.11.2016 um 01:01 schrieb Marius Bakke:
> > If there are no further comments, I will push this in the next few
> > days:
>
> Thanks for your work on this. It seems to be laborious.
>
> I don't have time to inspect not to test the
On Thu, 17 Nov 2016 19:22:48 +0100
Marius Bakke wrote:
> tyreunom writes:
>
> > Le 2016-11-17 01:01, Marius Bakke a écrit :
> >> Ludovic Courtès writes:
> >>
> >>> Marius Bakke skribis:
> >>>
> Some failures are indeed due to missing network or programs in
> the build
>
tyreunom writes:
> Le 2016-11-17 01:01, Marius Bakke a écrit :
>> Ludovic Courtès writes:
>>
>>> Marius Bakke skribis:
>>>
Some failures are indeed due to missing network or programs in the
build
environment. I tried patching a few just now, but unfortunately some
files a
Hello!
tyreunom skribis:
> we could include patches to our libgd to fix two (maybe four)
> issues. We should also upgrade our sqlite version, but many packages
> will then have to be rebuilt, or we could create a separate package
> for the newer version. What do you suggest?
Until we upgrade ‘g
Le 2016-11-17 01:01, Marius Bakke a écrit :
Ludovic Courtès writes:
Marius Bakke skribis:
Some failures are indeed due to missing network or programs in the
build
environment. I tried patching a few just now, but unfortunately some
files are in a format apparently not supported by Guile!
Am 17.11.2016 um 01:01 schrieb Marius Bakke:
> If there are no further comments, I will push this in the next few days:
Thanks for your work on this. It seems to be laborious.
I don't have time to inspect not to test the patch, so just some
thought. I'm not a php-user, but wanted to install a php
Marius Bakke skribis:
> Some failures are indeed due to missing network or programs in the build
> environment. I tried patching a few just now, but unfortunately some
> files are in a format apparently not supported by Guile!
>
> 870: 5 [call-with-input-file "ext/mbstring/tests/bug26639.phpt" .
Ludovic Courtès writes:
> Hi Marius,
>
> Marius Bakke skribis:
>
>> Marius Bakke writes:
>>
>>> Julien Lepiller writes:
>>>
> Could you send an updated patch to address those issues? Then we can
> happily apply it.
here is the updated patch. I let the tests be done because it doe
Hi Marius,
Marius Bakke skribis:
> Marius Bakke writes:
>
>> Julien Lepiller writes:
>>
Could you send an updated patch to address those issues? Then we can
happily apply it.
>>> here is the updated patch. I let the tests be done because it doesn't
>>> harm, but it does no good eith
Marius Bakke writes:
> Julien Lepiller writes:
>
>>> Could you send an updated patch to address those issues? Then we can
>>> happily apply it.
>> here is the updated patch. I let the tests be done because it doesn't
>> harm, but it does no good either, so feel free to disable them if you
>> pr
Julien Lepiller writes:
>> Could you send an updated patch to address those issues? Then we can
>> happily apply it.
> here is the updated patch. I let the tests be done because it doesn't
> harm, but it does no good either, so feel free to disable them if you
> prefer.
Hello! I've gone through
On Wed, 09 Nov 2016 16:44:41 +0100
l...@gnu.org (Ludovic Courtès) wrote:
> Hello Julien,
>
> Seems like the original reviewer (hi Marius! ;-)) missed this
> revision, so here are a few comments.
>
> Julien Lepiller skribis:
>
> > From 94c512aa3c9710b65b6fce0cd108744a7c308c63 Mon Sep 17 00:00:0
Hello Julien,
Seems like the original reviewer (hi Marius! ;-)) missed this revision,
so here are a few comments.
Julien Lepiller skribis:
> From 94c512aa3c9710b65b6fce0cd108744a7c308c63 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller
> Date: Sun, 30 Oct 2016 15:05:51 +0100
> Subject: [PATCH]
On Sun, 30 Oct 2016 23:17:58 +
Marius Bakke wrote:
>
> We prefer HTTPS when available, which is the case for https://php.net.
>
>
> Please move this to a source "snippet", so that they are not included
> in `guix build -S`. I believe we also have to list the licenses of the
> bundles that
On Sun, Oct 30, 2016 at 01:08:28PM +0100, Julien Lepiller wrote:
> Hi,
>
> here is a patch to add php to guix.
> From b20406a07e8d8c99a189f5295929ff76a53d47e7 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller
> Date: Sun, 30 Oct 2016 15:05:51 +0100
> Subject: [PATCH] gnu: Add php
>
> * gnu/packa
> From 2b0d70360296a9f7639529507bea6d28d3524e06 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller
> Date: Sun, 30 Oct 2016 15:05:51 +0100
> Subject: [PATCH] gnu: Add php
>
> * gnu/packages/php.scm: New file.
> * gnu/packages/php.scm (php): New variable.
> ---
> gnu/local.mk | 1 +
> gnu
Julien Lepiller skribis:
> Here is a new patch that addresses your comments and Efraim's. Also I'm
> pretty sure you're not supposed to end a description with a full stop.
I’m afraid Tobias was right. ;-)
https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html
Tha
On Sun, 30 Oct 2016 15:03:39 +0100
Tobias Geerinckx-Rice wrote:
> Julien,
>
> On 30/10/16 13:08, Julien Lepiller wrote:
> > here is a patch to add php to guix.
>
> Excellent! I see you've broken into my machine (probably through PHP),
> stolen my bitrotting PHP 7 package and greatly improved
Julien,
On 30/10/16 13:08, Julien Lepiller wrote:
> here is a patch to add php to guix.
Excellent! I see you've broken into my machine (probably through PHP),
stolen my bitrotting PHP 7 package and greatly improved it. Thanks!
An incomplete review:
> +(chdir "ext")
[...]
> +
On Sun, Oct 30, 2016 at 01:08:28PM +0100, Julien Lepiller wrote:
> Hi,
>
> here is a patch to add php to guix.
> From b20406a07e8d8c99a189f5295929ff76a53d47e7 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller
> Date: Sun, 30 Oct 2016 15:05:51 +0100
> Subject: [PATCH] gnu: Add php
>
> * gnu/packa
Hi,
here is a patch to add php to guix.From b20406a07e8d8c99a189f5295929ff76a53d47e7 Mon Sep 17 00:00:00 2001
From: Julien Lepiller
Date: Sun, 30 Oct 2016 15:05:51 +0100
Subject: [PATCH] gnu: Add php
* gnu/packages/php.scm: New file.
* gnu/packages/php.scm (php): New variable.
---
gnu/local.mk
27 matches
Mail list logo
