Re: Odd behavior with --dry-run and --upgrade

2016-08-28 Thread Ludovic Courtès
Hi Roel, Roel Janssen skribis: > From cf5a01aba3c08b7c62048bff3e0f1df80dc0b4dc Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Sun, 21 Aug 2016 06:48:52 +0200 > Subject: [PATCH] guix scripts: Disable grafting on dry runs. > > * guix/scripts/archive.scm, guix/scripts/build.scm, > guix/sc

Re: Odd behavior with --dry-run and --upgrade

2016-08-27 Thread Roel Janssen
Roel Janssen writes: > Ludovic Courtès writes: > >> Roel Janssen skribis: >> >>> Ludovic Courtès writes: >>> Hi! Alex Kost skribis: > Roel Janssen (2016-07-23 18:11 +0300) wrote: > >> Dear Guix, >> >> For some time now, running `guix package --dry-run --u

Re: Odd behavior with --dry-run and --upgrade

2016-08-20 Thread Roel Janssen
>From cf5a01aba3c08b7c62048bff3e0f1df80dc0b4dc Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Sun, 21 Aug 2016 06:48:52 +0200 Subject: [PATCH] guix scripts: Disable grafting on dry runs. * guix/scripts/archive.scm, guix/scripts/build.scm, guix/scripts/environment.scm, guix/scripts/system.scm

Re: Odd behavior with --dry-run and --upgrade

2016-07-30 Thread Ludovic Courtès
Alex Kost skribis: > Ludovic Courtès (2016-07-28 16:01 +0300) wrote: [...] >> --- a/guix/scripts.scm >> +++ b/guix/scripts.scm >> @@ -22,6 +22,7 @@ >>#:use-module (guix utils) >>#:use-module (guix ui) >>#:use-module (guix store) >> + #:use-module (guix grafts) >>#:use-module (g

Re: Odd behavior with --dry-run and --upgrade

2016-07-30 Thread Alex Kost
Ludovic Courtès (2016-07-28 16:01 +0300) wrote: > Alex Kost skribis: [...] >> However, I tried it and it doesn't work for me (note: I know nothing >> about monads, gexps, etc.). When I try this: >> >>(mbegin %store-monad >> (set-grafting #f) >> …) >> >> the grafting doesn't happen,

Re: Odd behavior with --dry-run and --upgrade

2016-07-28 Thread Ludovic Courtès
Alex Kost skribis: > Ludovic Courtès (2016-07-28 01:19 +0300) wrote: > >> Alex Kost skribis: [...] >>> From d7747453bf31a616d414dce293fc0556d601abcb Mon Sep 17 00:00:00 2001 >>> From: Alex Kost >>> Date: Wed, 27 Jul 2016 14:55:50 +0300 >>> Subject: [PATCH] emacs: Disable grafts when dry-run i

Re: Odd behavior with --dry-run and --upgrade

2016-07-28 Thread Alex Kost
Ludovic Courtès (2016-07-28 01:19 +0300) wrote: > Alex Kost skribis: > >> I have zero knowledge in grafting, but if I checked it right, the >> attached patch should disable grafting for the emacs interface (when >> dry-run is on). If you think it should be a part of a bigger >> dry-run+no-grafts

Re: Odd behavior with --dry-run and --upgrade

2016-07-27 Thread Ludovic Courtès
Alex Kost skribis: > I have zero knowledge in grafting, but if I checked it right, the > attached patch should disable grafting for the emacs interface (when > dry-run is on). If you think it should be a part of a bigger > dry-run+no-grafts patch, please use it. Two separate patches is fine, IM

Re: Odd behavior with --dry-run and --upgrade

2016-07-27 Thread Alex Kost
Ludovic Courtès (2016-07-26 15:41 +0300) wrote: > Roel Janssen skribis: > >> Ludovic Courtès writes: [...] >>> Something similar should be done in the Emacs interface. >> >> I'm not familiar with the code of the Emacs interface. Any other >> takers for it? Otherwise I will look into it, but tha

Re: Odd behavior with --dry-run and --upgrade

2016-07-26 Thread Ludovic Courtès
Alex Kost skribis: > The only way I see for the Emacs interface is to modify > "emacs/guix-main.scm" to parameterize ‘%graft?’ as well and to set it > depending on the current value of ‘dry-run’. AFAICT this > parameterization should be added to: > > - 'process-package-actions': it is responsibl

Re: Odd behavior with --dry-run and --upgrade

2016-07-26 Thread Alex Kost
Ludovic Courtès (2016-07-26 12:50 +0300) wrote: > Roel Janssen skribis: > >> Ludovic Courtès writes: [...] >>> But honestly, I think changing ‘--dry-run’ to do ‘--dry-run --no-grafts’ >>> would be fine, and probably better than the current situation. >> >> Could you provide some insight in where

Re: Odd behavior with --dry-run and --upgrade

2016-07-26 Thread Ludovic Courtès
Roel Janssen skribis: > Ludovic Courtès writes: > >> Roel Janssen skribis: >> >>> Ludovic Courtès writes: [...] >> Everything that relates to command-line argument processing is in (guix >> scripts build), for the common options, and then in each (guix scripts >> *) module. >> >> Roughly, the

Re: Odd behavior with --dry-run and --upgrade

2016-07-26 Thread Roel Janssen
Ludovic Courtès writes: > Roel Janssen skribis: > >> Ludovic Courtès writes: >> >>> Hi! >>> >>> Alex Kost skribis: >>> Roel Janssen (2016-07-23 18:11 +0300) wrote: > Dear Guix, > > For some time now, running `guix package --dry-run --upgrade' results in > build actions

Re: Odd behavior with --dry-run and --upgrade

2016-07-26 Thread Ludovic Courtès
Roel Janssen skribis: > Ludovic Courtès writes: > >> Hi! >> >> Alex Kost skribis: >> >>> Roel Janssen (2016-07-23 18:11 +0300) wrote: >>> Dear Guix, For some time now, running `guix package --dry-run --upgrade' results in build actions involving grafting. For a dry-run, I fi

Re: Odd behavior with --dry-run and --upgrade

2016-07-25 Thread Roel Janssen
Ludovic Courtès writes: > Hi! > > Alex Kost skribis: > >> Roel Janssen (2016-07-23 18:11 +0300) wrote: >> >>> Dear Guix, >>> >>> For some time now, running `guix package --dry-run --upgrade' results in >>> build actions involving grafting. For a dry-run, I find that really >>> odd. I believe t

Re: Odd behavior with --dry-run and --upgrade

2016-07-25 Thread Andreas Enge
On Mon, Jul 25, 2016 at 12:18:41AM +0200, Ludovic Courtès wrote: > > I'm totally agree with this; nowadays I always use --dry-run with > > --no-grafts option. > Same here… > > As a user I expect that --dry-run means no building at all. > But honestly, I think changing ‘--dry-run’ to do ‘--dry-run -

Re: Odd behavior with --dry-run and --upgrade

2016-07-24 Thread Ludovic Courtès
Hi! Alex Kost skribis: > Roel Janssen (2016-07-23 18:11 +0300) wrote: > >> Dear Guix, >> >> For some time now, running `guix package --dry-run --upgrade' results in >> build actions involving grafting. For a dry-run, I find that really >> odd. I believe the correct behavior should be what can

Re: Odd behavior with --dry-run and --upgrade

2016-07-24 Thread Alex Kost
Roel Janssen (2016-07-23 18:11 +0300) wrote: > Dear Guix, > > For some time now, running `guix package --dry-run --upgrade' results in > build actions involving grafting. For a dry-run, I find that really > odd. I believe the correct behavior should be what can be achieved > with: `guix package

Re: Odd behavior with --dry-run and --upgrade

2016-07-23 Thread Leo Famulari
On Sat, Jul 23, 2016 at 05:11:03PM +0200, Roel Janssen wrote: > For some time now, running `guix package --dry-run --upgrade' results in > build actions involving grafting. For a dry-run, I find that really > odd. I believe the correct behavior should be what can be achieved > with: `guix package

Odd behavior with --dry-run and --upgrade

2016-07-23 Thread Roel Janssen
Dear Guix, For some time now, running `guix package --dry-run --upgrade' results in build actions involving grafting. For a dry-run, I find that really odd. I believe the correct behavior should be what can be achieved with: `guix package --dry-run --no-grafts --upgrade'. Do you think the behav