Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-28 Thread Christopher Baines
Luciana Lima Brito writes: > Hi, > > On Tue, 27 Apr 2021 21:29:35 +0100 > Christopher Baines wrote: > > >> Great :) I've tweaked the commit message a little and pushed. > > This is really great!!! > > I started to look after my final application and I need to see two > specific things with you

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-27 Thread Luciana Lima Brito
Hi, On Tue, 27 Apr 2021 21:29:35 +0100 Christopher Baines wrote: > Great :) I've tweaked the commit message a little and pushed. This is really great!!! I started to look after my final application and I need to see two specific things with you to finish filling the forms. 1 - There is a fie

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-27 Thread Christopher Baines
Luciana Lima Brito writes: > On Tue, 27 Apr 2021 19:42:13 +0100 > Christopher Baines wrote: > >> I'd go with this approach, applying the comments I made about the >> match-lambda bit above in the email I sent a few minutes ago. > > I applied all you instructed me. See if it looks better now. G

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-27 Thread Luciana Lima Brito
On Tue, 27 Apr 2021 19:42:13 +0100 Christopher Baines wrote: > I'd go with this approach, applying the comments I made about the > match-lambda bit above in the email I sent a few minutes ago. I applied all you instructed me. See if it looks better now. -- Best Regards, Luciana Lima Brito MSc

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-27 Thread Christopher Baines
Luciana Lima Brito writes: > On Tue, 27 Apr 2021 13:10:01 + > Luciana Lima Brito wrote: > >> > Maybe add another procedure that combines group-to-alist but >> > generates an alist with vectors as the values? >> > (group-to-alist/vector maybe). > > I did it! :) > It was so much simpler. I cr

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-27 Thread Luciana Lima Brito
On Tue, 27 Apr 2021 13:10:01 + Luciana Lima Brito wrote: > > Maybe add another procedure that combines group-to-alist but > > generates an alist with vectors as the values? > > (group-to-alist/vector maybe). I did it! :) It was so much simpler. I created a function group-to-alist/vector,

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-27 Thread Christopher Baines
Luciana Lima Brito writes: > On Mon, 26 Apr 2021 22:21:50 +0100 > Christopher Baines wrote: > >> >> Rather than writing: >> >> (match-lambda >> ((alist ...) >> >> I'd just use >> >> (lambda (alist) >> >> as I think that's equivalent right? > > Right, I did this. Great. Unfortunately I

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-27 Thread Luciana Lima Brito
On Mon, 26 Apr 2021 22:21:50 +0100 Christopher Baines wrote: > > Rather than writing: > > (match-lambda > ((alist ...) > > I'd just use > > (lambda (alist) > > as I think that's equivalent right? Right, I did this. > >> I'd consider these options first probably: > >> > >> - Could

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-26 Thread Christopher Baines
Luciana Lima Brito writes: > On Mon, 26 Apr 2021 09:15:37 +0100 > Christopher Baines wrote: > >> So, one advantage of alists over lists is that the code is probably >> less brittle when adding elements say, since code parsing the list >> will probably break with a new element, but this is proba

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-26 Thread Luciana Lima Brito
On Mon, 26 Apr 2021 09:15:37 +0100 Christopher Baines wrote: > So, one advantage of alists over lists is that the code is probably > less brittle when adding elements say, since code parsing the list > will probably break with a new element, but this is probably less > likely to happen with an al

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-26 Thread Christopher Baines
Luciana Lima Brito writes: > Your advices helped me think more clearly. Great :) > There was no need to create or modify structures other than what I was > already changing. I now return an alist instead of a list on the > derivation-differences-* functions on comparison.scm (for outputs, > in

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-25 Thread Luciana Lima Brito
Hi Your advices helped me think more clearly. There was no need to create or modify structures other than what I was already changing. I now return an alist instead of a list on the derivation-differences-* functions on comparison.scm (for outputs, inputs and sources). It helped to simplify the m

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-23 Thread Christopher Baines
Luciana Lima Brito writes: > Hi, > > On Thu, 22 Apr 2021 22:15:34 +0100 > Christopher Baines wrote: > > I'm stuck. > >> I'd suggest avoiding '() as the value for hash and hash-algorithm when >> they're NULL in the database. One option here that I've used in some >> places is to return a alist r

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-23 Thread Luciana Lima Brito
Hi, On Thu, 22 Apr 2021 22:15:34 +0100 Christopher Baines wrote: I'm stuck. > I'd suggest avoiding '() as the value for hash and hash-algorithm when > they're NULL in the database. One option here that I've used in some > places is to return a alist rather than a list. This can simplify JSON >

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-22 Thread Christopher Baines
Luciana Lima Brito writes: > On Thu, 22 Apr 2021 21:08:08 +0100 > Christopher Baines wrote: > >> I'm not quite sure what you mean by empty fields in the JSON here? > > I mean now it appears like this in the json > > hash-alg: {} > > Before, it was entirely omitted. Right, OK. I'd call that

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-22 Thread Luciana Lima Brito
On Thu, 22 Apr 2021 21:08:08 +0100 Christopher Baines wrote: > I'm not quite sure what you mean by empty fields in the JSON here? I mean now it appears like this in the json hash-alg: {} Before, it was entirely omitted. > It sounds like you're roughly on the right track, do share what

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-22 Thread Christopher Baines
Luciana Lima Brito writes: > Hi, > >> Small intentional changes are better, so I'd start just with looking >> at some of the data coming out of the query. But yes, I think you're >> in the right place. The hard part here is probably to look at how >> those values are used in the JSON and HTML re

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-22 Thread Luciana Lima Brito
Hi, > Small intentional changes are better, so I'd start just with looking > at some of the data coming out of the query. But yes, I think you're > in the right place. The hard part here is probably to look at how > those values are used in the JSON and HTML rendering code, and adjust > that accor

Re: Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-22 Thread Christopher Baines
Luciana Lima Brito writes: > Hi, > > This email is mostly addressed to Christopher Baines, due to the > Outreachy. > > In the last email to me, you said this about my next steps on > contributing: > > "In terms of what to do next, you could continue on this derivation > comparison path. Some of

Outreachy - Guix Data Service: questions about improving the data for derivation comparisons.

2021-04-21 Thread Luciana Lima Brito
Hi, This email is mostly addressed to Christopher Baines, due to the Outreachy. In the last email to me, you said this about my next steps on contributing: "In terms of what to do next, you could continue on this derivation comparison path. Some of the code you've got here could be used to make