[hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Markus F.X.J. Oberhumer
Hi, this is my first post to this list, so I hope I got the email patch right. GitHub repo is at https://github.com/markus-oberhumer/suckless-st/compare/mild-const-correctness-improvements Cheers, Markus -- Markus Oberhumer, , http://www.oberhumer.com/ From 68a443c66f4dfce1327212b1a41acd9af74a

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Laslo Hunhold
On Thu, 6 May 2021 16:11:33 +0200 "Markus F.X.J. Oberhumer" wrote: Dear Markus, > this is my first post to this list, so I hope I got the email patch > right. > > GitHub repo is at > https://github.com/markus-oberhumer/suckless-st/compare/mild-const-correctness-improvements thanks for your inp

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Markus F.X.J. Oberhumer
Hi Laslo, On 2021-05-06 16:19, Laslo Hunhold wrote: > On Thu, 6 May 2021 16:11:33 +0200 > "Markus F.X.J. Oberhumer" wrote: > > Dear Markus, > >> this is my first post to this list, so I hope I got the email patch >> right. >> >> GitHub repo is at >> https://github.com/markus-oberhumer/suckless-

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Hiltjo Posthuma
On Thu, May 06, 2021 at 04:33:35PM +0200, Markus F.X.J. Oberhumer wrote: > Hi Laslo, > > On 2021-05-06 16:19, Laslo Hunhold wrote: > > On Thu, 6 May 2021 16:11:33 +0200 > > "Markus F.X.J. Oberhumer" wrote: > > > > Dear Markus, > > > >> this is my first post to this list, so I hope I got the ema

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Laslo Hunhold
On Thu, 6 May 2021 17:48:33 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > The patch looks fine. I'm not in favor of some of the const changes, > but I think it makes sense to make function parameters like for > xstrdup() const. > > I'll review and push it later. const-correctness saved me from q

[hackers] [st] Mild const-correctness improvements. || Markus F.X.J. Oberhumer

2021-05-06 Thread git
commit 4536f46cfff50c66a115755def0155d8e246b02f Author: Markus F.X.J. Oberhumer AuthorDate: Sun Mar 28 21:16:59 2021 +0200 Commit: Hiltjo Posthuma CommitDate: Thu May 6 18:21:10 2021 +0200 Mild const-correctness improvements. Only touch a few things, the main focus is to

[hackers] [sic] fix an out-of-bounds read if the input is "" || Hiltjo Posthuma

2021-05-06 Thread git
commit df4c0611366bf361fa263fbc57009cbe68456855 Author: Hiltjo Posthuma AuthorDate: Thu May 6 01:04:35 2021 +0200 Commit: Hiltjo Posthuma CommitDate: Thu May 6 01:04:35 2021 +0200 fix an out-of-bounds read if the input is "" Notified by Guilherme Janczak , thanks! diff --gi

[hackers] [sic] fix undefined behaviour of using isspace ctype function || Hiltjo Posthuma

2021-05-06 Thread git
commit d9bda20849c464eff0adb56414da1840abc6ef6a Author: Hiltjo Posthuma AuthorDate: Thu May 6 01:09:21 2021 +0200 Commit: Hiltjo Posthuma CommitDate: Thu May 6 01:09:21 2021 +0200 fix undefined behaviour of using isspace ctype function cast all ctype(3) functions argument to

[hackers] [sic] util: fix a shadowed variable name `srv` || Hiltjo Posthuma

2021-05-06 Thread git
commit b188c784329baf8479f30f06c61c12226d797115 Author: Hiltjo Posthuma AuthorDate: Thu May 6 01:14:21 2021 +0200 Commit: Hiltjo Posthuma CommitDate: Thu May 6 01:14:21 2021 +0200 util: fix a shadowed variable name `srv` diff --git a/util.c b/util.c index 0869cca..c2982fd 100644 ---

[hackers] [sic] util: dial: no need for a static struct hints || Hiltjo Posthuma

2021-05-06 Thread git
commit 81533f966ec31049c6159eac482bb821cb1e54ef Author: Hiltjo Posthuma AuthorDate: Thu May 6 01:16:13 2021 +0200 Commit: Hiltjo Posthuma CommitDate: Thu May 6 01:16:13 2021 +0200 util: dial: no need for a static struct hints diff --git a/util.c b/util.c index c2982fd..cb966d4 10064

[hackers] [sic] Makefile improvements || Hiltjo Posthuma

2021-05-06 Thread git
commit f2c5daa9fe8ee9da89b9596c2b316ba7f9bd64a7 Author: Hiltjo Posthuma AuthorDate: Thu May 6 01:39:46 2021 +0200 Commit: Hiltjo Posthuma CommitDate: Thu May 6 01:45:51 2021 +0200 Makefile improvements - Respect system/port flags by default. - Be verbose and do not hide

[hackers] [sic] README: fix a minor typo and make a small rewording || Hiltjo Posthuma

2021-05-06 Thread git
commit 68c1c4e5110ed6a30cd3da0ae0c2ab0753e02cbb Author: Hiltjo Posthuma AuthorDate: Thu May 6 01:42:38 2021 +0200 Commit: Hiltjo Posthuma CommitDate: Thu May 6 01:47:08 2021 +0200 README: fix a minor typo and make a small rewording diff --git a/README b/README index efeb5ac..a54921b

[hackers] [sic] util: trim() fix for UB on pointer arithmetic || Hiltjo Posthuma

2021-05-06 Thread git
commit 058547e707e961e0cb7f8af4877f1b92f4c6d888 Author: Hiltjo Posthuma AuthorDate: Thu May 6 12:18:21 2021 +0200 Commit: Hiltjo Posthuma CommitDate: Thu May 6 12:20:30 2021 +0200 util: trim() fix for UB on pointer arithmetic Follow-up fix on commit df4c0611366bf361fa263fbc5