[hackers] [st] [PATCH] Makefile: always output the build options, even when building with install

--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 470ac86407bb..6eb2d9d04852 100644 --- a/Makefile +++ b/Makefile @@ -40,7 +40,7 @@ dist: clean tar -cf - st-$(VERSION) | gzip > st-$(VERSION).tar.gz rm -rf st-$(VERSION)

Re: [hackers] [st][PATCH] Fix xresources bgcolour fgcolour and cscolour definitions

Hi Hari, I *highly* doubt that there is any interest in getting this into mainline. There is already a patch which adds this behaviour. -- Best Regards, Tom Schwindl

Re: [hackers] [dwm] [PATCH] add a comment to clarify a potential overflow of ltsymbol

person. So I think a comment, as you, yourself suggested, might be helpful. A simple "Hey, if you're exceeding 16 bytes we cannot guarantee for anything" would be enough (not in that tone, of course) for me. -- Best Regards, Tom Schwindl > -- > Kind regards, > Hiltjo

[hackers] [dwm] [PATCH] add a comment to clarify a potential overflow of ltsymbol

In case the strncpy() call is advised to copy >=16 characters, ltsymbol overflows. As dwm does not expect to have a ltsymbol bigger than 15 characters, there will be no length check[0]. Our target audience are programmers, they should be able to figure out how to extend the length by themselves.

Re: [hackers] [dwm] [PATCH] use correct conversion specifier for an unsigned integer

> > I think %d is fine and correct here too. > > -- > Kind regards, > Hiltjo Indeed. I was wondering about this since it looks inconsistent to me. But to be fair, in reality this will probably never be problem. -- Best Regards, Tom Schwindl

[hackers] [dwm] [PATCH] use correct conversion specifier for an unsigned integer

--- dwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwm.c b/dwm.c index 03baf42b3502..d832678ab5aa 100644 --- a/dwm.c +++ b/dwm.c @@ -1121,7 +1121,7 @@ monocle(Monitor *m) if (ISVISIBLE(c)) n++; if (n > 0) /* override

[hackers] [sent] [PATCH] remove unnecessary NULL checks and add `void` for an empty parameter list

--- I sent (hehe) this a long time ago, it might be of interest now that some work is done. --- sent.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/sent.c b/sent.c index 9534fcaf97b9..49853ee6c273 100644 --- a/sent.c +++ b/sent.c @@ -99,12

Re: [hackers] Re: [sbase][PATCH] dd: fix for ibs * count < obs

opos < obs && ifull + ipart < count) { > > > ret = read(ifd, buf + ipos, ibs); > > > if (ret == 0) { > > > eof = 1; > > > -- > > > 2.38.1 > > > Your previous message went through, at least for me. The archive is a bit buggy and sometimes misses some mails. As for your diff, sbase is pretty inactive and I don't know how often a maintainer checks the mailing list for patches. -- Best Regards, Tom Schwindl

Re: [hackers] [sites][PATCH] Adding the "movekeyboard" dwm(6.4) patch, which adds the ability to move floating windows on the x and y axis through a keybinding/keyboard instead of only the mouse.

bsite[1]. [1] https://dwm.suckless.org/patches/movekeyboard/ -- Best Regards, Tom Schwindl

Re: [hackers] [sites][PATCH] Adding the "movekeyboard" dwm(6.4) patch, which adds the ability to move floating windows on the x and y axis through a keybinding/keyboard instead of only the mouse.

Hi, this should be commited to the wiki. See https://suckless.org/wiki/ Additionally, you shouldn't put the whole commit message into the subject of your patch. -- Best Regards, Tom Schwindl

Re: [hackers] [dwm][patch] xkb indicator patch for 6.4

Hi, this should be commited to the wiki. See https://suckless.org/wiki/ -- Best Regards, Tom Schwindl

Re: [hackers] [libgrapheme] Add a check make-target as an alias for test || Laslo Hunhold

e3 100644 > --- a/Makefile > +++ b/Makefile > @@ -308,6 +308,8 @@ $(MAN7:=.7): > benchmark: $(BENCHMARK) > for m in $(BENCHMARK); do ./$$m; done > > +check: test > + > test: $(TEST) > for m in $(TEST); do ./$$m; done > This should probably be added to the PHONY target as a prerequisite. -- Best Regards, Tom Schwindl

Re: [hackers] [sbase][PATCH 1/2] libutil: Implement a simple yes/no prompt

ialized) since its a throw away variable. linep should be freed. I don't quite get why there is a variable argument list instead of just using a single argument which contains the prompt. I can't see the need for formatting in a y/n prompt. I also wouldn't use `nomsg' since it just polutes stderr. Ad

Re: [hackers] [lchat] Makefile: add dist target to create release tarballs || Jan Klemkow

fix lchat-$(VERSION)/ HEAD | gzip > > > lchat-$(VERSION).tar.gz > > this would add an implicit dependency on git, though. > git already is a dependency, given the following line. > + cp -r $$(git ls-tree --name-only HEAD) lchat-$(VERSION) -- Best Regards, Tom Schwindl

[hackers] [dmenu] [PATCH] dmenu: use die() to print the usage message

--- dmenu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dmenu.c b/dmenu.c index 571bc3558014..999f71fa91a1 100644 --- a/dmenu.c +++ b/dmenu.c @@ -710,9 +710,8 @@ setup(void) static void usage(void) { - fputs("usage: dmenu [-bfiv] [-l lines] [-p prompt] [-fn

Re: [hackers] [libgrapheme] Update to Unicode 15.0.0 || Laslo Hunhold

Hi Laslo, I think the README has to be updated, too. It still states that libgrapheme conforms to Unicode 14.0.0. -- Best Regards, Tom Schwindl

Re: [hackers] [PATCH] [st] FAQ: libXft now supports BGRA glyphs

Hi, On Thu Sep 15, 2022 at 3:45 PM CEST, NRK wrote: > On Thu, Sep 15, 2022 at 01:31:02PM +0000, Tom Schwindl wrote: > > -## BadLength X error in Xft when trying to render emoji > > - > > -Xft makes st crash when rendering color emojis with the following error: > >

[hackers] [PATCH] [st] FAQ: libXft now supports BGRA glyphs

https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS --- FAQ | 28 1 file changed, 28 deletions(-) diff --git a/FAQ b/FAQ index 969b195ebcff..e36b173361d5 100644 --- a/FAQ +++ b/FAQ @@ -220,31 +220,3 @@ diff --git a/x.c b/x.c

[hackers] [ii] [PATCH] ii: Remove unnecessary explicit zeroing of variables

--- ii.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/ii.c b/ii.c index 0856e8f010d3..520f75d1618a 100644 --- a/ii.c +++ b/ii.c @@ -32,7 +32,7 @@ size_t strlcpy(char *, const char *, size_t); #define IRC_MSG_MAX 512 /* guaranteed to be <= than

Re: [hackers] [ii][PATCH] use square brackets for optional -u parameter in man page

should also remove the angle brackets around the `-s' option and sync the names of the arguments with the ones used in the usage() function. Additionally, the `-u' option is missing in the usage message and a lot of unnecessary angle brackets are used, too. -- Best Regards, Tom Schwindl

Re: [hackers] [sbase] [PATCH] printf: Do not read past the end of the format string

ee times instead of the expected two and thus effectively "overflows". -- Best Regards, Tom Schwindl

[hackers] [sbase] [PATCH] printf: Do not read past the end of the format string

If a trailing `%' character occurs, we read past the end of the format string and thus introduce UB. Reproducible by executing the following: ./printf % This happens because the format string here actually consists of two characters, `%' _and_ the trailing nul-byte. The flag parsing loop matches

[hackers] [st] [PATCH] st: use `void' to indicate an empty parameter list

--- st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/st.c b/st.c index 6ba467d7cc90..62def59f17cb 100644 --- a/st.c +++ b/st.c @@ -939,7 +939,7 @@ ttyresize(int tw, int th) } void -ttyhangup() +ttyhangup(void) { /* Send SIGHUP to shell */ kill(pid,

Re: [hackers] [sbase] [PATCH] Use ar(1)'s s-flag instead of invoking ranlib(1)

that bloats up an otherwise simple archive-tool. > > Thanks for this very interesting discussion and sharing your > experience! > > With best regards > > Laslo It was indeed interesting. We should also undo the libzahl patch then. -- Best Regards, Tom Schwindl

[hackers] [libgrapheme] [PATCH] Remove dead file `src/util.c'

Since commit 072bb271868a3583da1f ("Introduce mostly branchless character break detection") removed the code from the file, it no longer serves a purpose. --- Makefile | 2 -- src/util.c | 8 2 files changed, 10 deletions(-) delete mode 100644 src/util.c diff --git a/Makefile

[hackers] [ii] [PATCH] ii: Add a die() function to replace fprintf(3) + exit(3) calls

--- ii.c | 92 +++- 1 file changed, 41 insertions(+), 51 deletions(-) diff --git a/ii.c b/ii.c index 2d485aa3e453..0c9ae74cb174 100644 --- a/ii.c +++ b/ii.c @@ -56,6 +56,7 @@ static int channel_reopen(Channel *); static void

[hackers] [libzahl] [PATCH] Use ar(1)'s s-flag instead of invoking ranlib(1)

ranlib(1) is legacy and not even part of POSIX anymore, ar(1) can do the same job with the s-flag (which is an XSI-extension, but whatever). --- Makefile | 3 +-- config.mk | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Makefile b/Makefile index bd6e47237c5f..b8852583fb93

[hackers] [sbase] [PATCH] Use ar(1)'s s-flag instead of invoking ranlib(1)

ranlib(1) is legacy and not even part of POSIX anymore, ar(1) can do the same job with the s-flag (which is an XSI-extension, but whatever). --- shamelessly stole Laslos commit message --- Makefile | 6 ++ config.mk | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git

[hackers] [lsw] [PATCH] Improve compliance with our coding style

--- lsw.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/lsw.c b/lsw.c index c7d5171e7383..497d6d262c1f 100644 --- a/lsw.c +++ b/lsw.c @@ -8,7 +8,7 @@ static Atom netwmname; static Display *dpy; -char * +static char * getname(Window win) {

Re: [hackers] [sent] [PATCH 3/3] Makefile: config.mk: Improve Makefile and config.mk

st a simple wrapper script with, roughly, the following content: exec /usr/bin/cc -std=c99 "$@" `-std` is already used here and we don't gain much by using the systems `c99`. But in the case in which `c99` isn't a script (which we probably should assume), your way is definitely the better one. Luckily, that's something the maintainer has to decide. Btw. does anyone know if he is still active on this list (or in general)? -- Best Regards, Tom Schwindl

Re: [hackers] [sent] [PATCH 3/3] Makefile: config.mk: Improve Makefile and config.mk

99. I'd keep the `-std` option and the CC assignment. We want to be C99 compliant regardless of which compiler the user decides to use. Additionally, CC is a configuration option in all suckless programs and to be consistent here seems reasonable, in my opinion. -- Best Regards, Tom Schwindl

Re: [hackers] [sent] [PATCH 3/3] Makefile: config.mk: Improve Makefile and config.mk

the maintainer has to decide. And just for the record: `-Wall` was already there, I just added the other `-W` options. -- Best Regards, Tom Schwindl

[hackers] [sent] [PATCH 2/3] treewide: Improve compliance with our coding style

- Add `void` as parameter for functions which do not take any Arguments - Use a block if the body of a loop consists of an `if` statement - A few minor changes such as moving a curley bracket --- drw.c | 3 ++- sent.c | 69 +- util.c | 3

[hackers] [sent] [PATCH 1/3] sent.c: Drop unnecessary NULL checks

Since no operation is performed when free(3) is used on NULL, remove the checks. --- sent.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sent.c b/sent.c index eb0ac970b1f5..3916cb0c4ad1 100644 --- a/sent.c +++ b/sent.c @@ -216,8 +216,7 @@ ffload(Slide *s)

[hackers] [sent] [PATCH 3/3] Makefile: config.mk: Improve Makefile and config.mk

Let the Makefile be a bit more verbose and remove unnecessary extensions and flags in config.mk. --- Makefile | 37 +++-- config.mk | 18 -- 2 files changed, 27 insertions(+), 28 deletions(-) diff --git a/Makefile b/Makefile index

Re: [hackers] [sent] [PATCH] treewide: Improve compliance with our coding style

On Sat, Jun 25, 2022 at 11:38:20PM +0600, NRK wrote: > On Sat, Jun 25, 2022 at 05:25:54PM +0000, Tom Schwindl wrote: > > -static void run(); > > -static void usage(); > > -static void xdraw(); > > -static void xhints(); > > -static void xinit(); > > -static

[hackers] [sent] [PATCH] treewide: Improve compliance with our coding style

- Add `void` as parameter for functions which do not take any Arguments - Use a block if the body of a loop consists of an `if` statement - A few changes such as moving a curley bracket --- diff --git a/drw.c b/drw.c index c1582e746cc5..84f87b972384 100644 --- a/drw.c +++ b/drw.c @@ -19,9 +19,10

[hackers] [lsw] [PATCH] Makefile: Add POSIX target

Since no extensions are used in the Makefile, add the .POSIX target. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index b37fa6412ee5..7d7e00dfb370 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,6 @@ # lsw - list window names # See LICENSE file for