Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Laslo Hunhold
On Thu, 6 May 2021 17:48:33 +0200 Hiltjo Posthuma wrote: Dear Hiltjo, > The patch looks fine. I'm not in favor of some of the const changes, > but I think it makes sense to make function parameters like for > xstrdup() const. > > I'll review and push it later. const-correctness saved me from

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Hiltjo Posthuma
On Thu, May 06, 2021 at 04:33:35PM +0200, Markus F.X.J. Oberhumer wrote: > Hi Laslo, > > On 2021-05-06 16:19, Laslo Hunhold wrote: > > On Thu, 6 May 2021 16:11:33 +0200 > > "Markus F.X.J. Oberhumer" wrote: > > > > Dear Markus, > > > >> this is my first post to this list, so I hope I got the

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Markus F.X.J. Oberhumer
Hi Laslo, On 2021-05-06 16:19, Laslo Hunhold wrote: > On Thu, 6 May 2021 16:11:33 +0200 > "Markus F.X.J. Oberhumer" wrote: > > Dear Markus, > >> this is my first post to this list, so I hope I got the email patch >> right. >> >> GitHub repo is at >>

Re: [hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Laslo Hunhold
On Thu, 6 May 2021 16:11:33 +0200 "Markus F.X.J. Oberhumer" wrote: Dear Markus, > this is my first post to this list, so I hope I got the email patch > right. > > GitHub repo is at > https://github.com/markus-oberhumer/suckless-st/compare/mild-const-correctness-improvements thanks for your

[hackers] [st][patch] Mild const-correctness improvements.

2021-05-06 Thread Markus F.X.J. Oberhumer
Hi, this is my first post to this list, so I hope I got the email patch right. GitHub repo is at https://github.com/markus-oberhumer/suckless-st/compare/mild-const-correctness-improvements Cheers, Markus -- Markus Oberhumer, , http://www.oberhumer.com/ From