[jira] Updated: (HADOOP-1377) Creation time and modification time for hadoop files and directories

2007-06-20 Thread dhruba borthakur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dhruba borthakur updated HADOOP-1377: - Attachment: (was: CreationTime5.patch) > Creation time and modification time for had

[jira] Updated: (HADOOP-1377) Creation time and modification time for hadoop files and directories

2007-06-20 Thread dhruba borthakur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dhruba borthakur updated HADOOP-1377: - Attachment: CreationTime6.patch Incorporated Doug's review comments. InMemoryFileSystem,

[jira] Assigned: (HADOOP-1486) ReplicationMonitor thread goes away

2007-06-20 Thread dhruba borthakur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dhruba borthakur reassigned HADOOP-1486: Assignee: dhruba borthakur > ReplicationMonitor thread goes away > --

[jira] Commented: (HADOOP-1292) dfs -copyToLocal should guarantee file is complete

2007-06-20 Thread dhruba borthakur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506774 ] dhruba borthakur commented on HADOOP-1292: -- Code changes look good. However, I would rather not introduce a

[jira] Commented: (HADOOP-1283) Eliminate internal UTF8 to String and vice versa conversions in the name-node.

2007-06-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506753 ] Hadoop QA commented on HADOOP-1283: --- +1 http://issues.apache.org/jira/secure/attachment/12360240/EliminateUTF8-2.

[jira] Created: (HADOOP-1512) TestTextInputFormat fails on Windows

2007-06-20 Thread Konstantin Shvachko (JIRA)
TestTextInputFormat fails on Windows Key: HADOOP-1512 URL: https://issues.apache.org/jira/browse/HADOOP-1512 Project: Hadoop Issue Type: Bug Affects Versions: 0.13.0 Environment: Windows

[jira] Updated: (HADOOP-1283) Eliminate internal UTF8 to String and vice versa conversions in the name-node.

2007-06-20 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Shvachko updated HADOOP-1283: Status: Patch Available (was: Open) > Eliminate internal UTF8 to String and vice

[jira] Updated: (HADOOP-1283) Eliminate internal UTF8 to String and vice versa conversions in the name-node.

2007-06-20 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Shvachko updated HADOOP-1283: Attachment: EliminateUTF8-2.patch I just updated the patch to reflect latest chang

[jira] Commented: (HADOOP-1375) a simple parser for hbase.

2007-06-20 Thread udanax (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506735 ] udanax commented on HADOOP-1375: Thank you for your constructive adivce. Stack Since I am new to this community,

Re: HBase Performance Q's

2007-06-20 Thread James Kennedy
Ok St.Ack, I've re-profiled with your recent updates. Overall the benchmark seems 4.1% faster averaged over several runs. I can't say i noticed a significant improvement in the readAndProcess()/ObjectWritable.write() methods. I'll definately add a vote to Hadoop-414. Definately i notice th

[jira] Resolved: (HADOOP-1491) After successful distcp, couple of checksum error files

2007-06-20 Thread dhruba borthakur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dhruba borthakur resolved HADOOP-1491. -- Resolution: Duplicate Duplicate of HADOOP-1396. > After successful distcp, couple of

[jira] Assigned: (HADOOP-1491) After successful distcp, couple of checksum error files

2007-06-20 Thread dhruba borthakur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dhruba borthakur reassigned HADOOP-1491: Assignee: dhruba borthakur > After successful distcp, couple of checksum error fil

[jira] Commented: (HADOOP-1509) Open HRegionServer/HClient for extension

2007-06-20 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506720 ] stack commented on HADOOP-1509: --- James: + Why make HClient.getConf public rather than protected? (You refer to 'serve

compression and disk-bound application

2007-06-20 Thread Bwolen Yang
For disk bound map/reduce applications (those did very little computation but mainly about collating large amount of relevant data and extract out a smaller summary for future computations), I was wondering about whether or not it make sense for mappers to work directly on compressed inputs. i.e

[jira] Resolved: (HADOOP-1147) remove all @author tags from source

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting resolved HADOOP-1147. -- Resolution: Fixed Fix Version/s: 0.14.0 I just committed this. > remove all @author ta

[jira] Created: (HADOOP-1511) hbase unit tests are slow

2007-06-20 Thread Doug Cutting (JIRA)
hbase unit tests are slow - Key: HADOOP-1511 URL: https://issues.apache.org/jira/browse/HADOOP-1511 Project: Hadoop Issue Type: Bug Components: contrib/hbase Reporter: Doug Cutting Pr

[jira] Updated: (HADOOP-1510) java.io.IOException: Attempt to roll edit log but edits.new exists

2007-06-20 Thread Michael Bieniosek (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bieniosek updated HADOOP-1510: -- Description: I updated to hadoop-0.13, deleted the dfs/ directory, formatted the namen

[jira] Resolved: (HADOOP-1510) java.io.IOException: Attempt to roll edit log but edits.new exists

2007-06-20 Thread Michael Bieniosek (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Bieniosek resolved HADOOP-1510. --- Resolution: Invalid Oops, that would be a rogue secondary namenode. > java.io.IOExc

[jira] Created: (HADOOP-1510) java.io.IOException: Attempt to roll edit log but edits.new exists

2007-06-20 Thread Michael Bieniosek (JIRA)
java.io.IOException: Attempt to roll edit log but edits.new exists -- Key: HADOOP-1510 URL: https://issues.apache.org/jira/browse/HADOOP-1510 Project: Hadoop Issue Type: Bug

[jira] Commented: (HADOOP-1375) a simple parser for hbase.

2007-06-20 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506705 ] stack commented on HADOOP-1375: --- Looking more at the patch. You need to remove the tabs and instead use spaces, two

[jira] Commented: (HADOOP-1375) a simple parser for hbase.

2007-06-20 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506702 ] stack commented on HADOOP-1375: --- Hey Jinsuk: I'd suggest you spend might spend more time testing before you upload ne

[jira] Updated: (HADOOP-1501) Block reports from all datanodes arrive at the namenode within a small band of time

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1501: - Resolution: Fixed Fix Version/s: 0.14.0 Status: Resolved (was: Patch Available

[jira] Updated: (HADOOP-1455) Allow any key-value pair on the command line of 'hadoop pipes' to be added to the JobConf

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1455: - Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this. Thank

[jira] Updated: (HADOOP-1489) Input file get truncated for text files with \r\n

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1489: - Resolution: Fixed Fix Version/s: 0.14.0 Status: Resolved (was: Patch Available

[jira] Updated: (HADOOP-1453) exists() not necessary before DFS.open

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1453: - Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this. Thank

[jira] Commented: (HADOOP-1486) ReplicationMonitor thread goes away

2007-06-20 Thread Hairong Kuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506680 ] Hairong Kuang commented on HADOOP-1486: --- > The ReplicationMonitor thread catches all types of exceptions, logs

[jira] Updated: (HADOOP-1440) JobClient should not sort input-splits

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1440: - Resolution: Fixed Assignee: Senthil Subramanian (was: Milind Bhandarkar) Status: R

[jira] Updated: (HADOOP-1292) dfs -copyToLocal should guarantee file is complete

2007-06-20 Thread Tsz Wo (Nicholas), SZE (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HADOOP-1292: --- Attachment: HADOOP-1292_20070620.patch Regarding to Dhruba's comments: 1. I

[jira] Updated: (HADOOP-1462) Better progress reporting from a Task

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1462: - Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this. Thank

[jira] Updated: (HADOOP-1292) dfs -copyToLocal should guarantee file is complete

2007-06-20 Thread Tsz Wo (Nicholas), SZE (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HADOOP-1292: --- Attachment: (was: HADOOP-1292_20070619b.patch) > dfs -copyToLocal should

[jira] Assigned: (HADOOP-1509) Open HRegionServer/HClient for extension

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting reassigned HADOOP-1509: Assignee: James Kennedy > Open HRegionServer/HClient for extension > -

[jira] Updated: (HADOOP-1509) Open HRegionServer/HClient for extension

2007-06-20 Thread James Kennedy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Kennedy updated HADOOP-1509: -- Attachment: openForExtension-v2.patch Followed procedure better this time. New patch includes

[jira] Updated: (HADOOP-1377) Creation time and modification time for hadoop files and directories

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1377: - Status: Open (was: Patch Available) 1. FsShell.java needs to import java.text.SimpleDateFormat.

[jira] Updated: (HADOOP-1504) terminate-hadoop-cluster may be overzealous

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1504: - Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this. Thank

[jira] Updated: (HADOOP-1023) better links to mailing list archives

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1023: - Resolution: Fixed Fix Version/s: 0.14.0 Status: Resolved (was: Patch Available

[jira] Updated: (HADOOP-1441) Splittability of input should be controllable by application

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1441: - Status: Open (was: Patch Available) One can already implement this with either: {code} class My

[jira] Updated: (HADOOP-1509) Open HRegionServer/HClient for extension

2007-06-20 Thread James Kennedy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Kennedy updated HADOOP-1509: -- Status: Open (was: Patch Available) Oops, submitted patch prematurely. > Open HRegionServer/

[jira] Updated: (HADOOP-1003) Proposal to batch commits to edits log.

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1003: - Resolution: Fixed Fix Version/s: 0.14.0 Status: Resolved (was: Patch Available

[jira] Updated: (HADOOP-1484) Kill jobs from web interface

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1484: - Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this. Thank

[jira] Updated: (HADOOP-1505) HADOOP-1093 adds INFO-level logging of stacktrace java.lang.Exception... ZlibFactory.getZlibCompressor(ZlibFactory.java:81)

2007-06-20 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom White updated HADOOP-1505: -- Resolution: Fixed Fix Version/s: 0.14.0 Assignee: stack Status: Resolved (w

[jira] Updated: (HADOOP-1475) local filecache disappears

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1475: - Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this. Thank

[jira] Commented: (HADOOP-1509) Open HRegionServer/HClient for extension

2007-06-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506636 ] Hadoop QA commented on HADOOP-1509: --- -1, could not apply patch. The patch command could not apply the latest atta

[jira] Updated: (HADOOP-1400) JobClient rpc times out getting job status

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1400: - Status: Open (was: Patch Available) We'll re-submit this after HADOOP-1473. > JobClient rpc ti

[jira] Updated: (HADOOP-71) The SequenceFileRecordReader uses the default FileSystem rather than the supplied one

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-71: --- Status: Open (was: Patch Available) This patch no longer applies to trunk, and I still think we need

[jira] Commented: (HADOOP-1501) Block reports from all datanodes arrive at the namenode within a small band of time

2007-06-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506628 ] Hadoop QA commented on HADOOP-1501: --- +1 http://issues.apache.org/jira/secure/attachment/12360084/randomBlockRepor

[jira] Updated: (HADOOP-1509) Open HRegionServer/HClient for extension

2007-06-20 Thread James Kennedy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Kennedy updated HADOOP-1509: -- Attachment: openForExtension.patch > Open HRegionServer/HClient for extension > --

[jira] Updated: (HADOOP-1509) Open HRegionServer/HClient for extension

2007-06-20 Thread James Kennedy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Kennedy updated HADOOP-1509: -- Fix Version/s: 0.14.0 Status: Patch Available (was: Open) Index: /opt/eclipse/san

[jira] Updated: (HADOOP-1509) Open HRegionServer/HClient for extension

2007-06-20 Thread James Kennedy (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Kennedy updated HADOOP-1509: -- Comment: was deleted > Open HRegionServer/HClient for extension >

Re: [jira] Commented: (HADOOP-1489) Input file get truncated for text files with \r\n

2007-06-20 Thread Doug Cutting
Michael Stack wrote: If your patch fails, set the issue status to 'Resume Progress', upload a patch with fix and then set the status to 'Submit Patch' again. Keep in mind, however, that the primary purpose of submitting patches is to get a committer to review and commit them, not to run Hudson

[jira] Created: (HADOOP-1509) Open HRegionServer/HClient for extension

2007-06-20 Thread James Kennedy (JIRA)
Open HRegionServer/HClient for extension Key: HADOOP-1509 URL: https://issues.apache.org/jira/browse/HADOOP-1509 Project: Hadoop Issue Type: Improvement Components: contrib/hbase Affects

[jira] Updated: (HADOOP-1508) ant Task for FsShell operations

2007-06-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated HADOOP-1508: - Assignee: Chris Douglas Status: Open (was: Patch Available) > ant Task for FsShell operat

[jira] Commented: (HADOOP-1506) distcp not preserving the replication factor and block size of source files

2007-06-20 Thread dhruba borthakur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506621 ] dhruba borthakur commented on HADOOP-1506: -- We could avoid using FileSystem.getReplication and FileSystem.g

[jira] Updated: (HADOOP-1501) Block reports from all datanodes arrive at the namenode within a small band of time

2007-06-20 Thread dhruba borthakur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dhruba borthakur updated HADOOP-1501: - Assignee: dhruba borthakur Status: Patch Available (was: Open) Thanks for the rev

Re: Opening HRegionServer/HMaster/HClient for extension

2007-06-20 Thread James Kennedy
Hi Michael, I'll create a Jira task and fix the patch spacing. I can't really talk too much about the HRegionServer/HClient extension i'm developing but I do think that there could be a general purpose need. For example, HBase let's you filter a scan by rowkey and column key. But what about

[jira] Commented: (HADOOP-1501) Block reports from all datanodes arrive at the namenode within a small band of time

2007-06-20 Thread Raghu Angadi (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506607 ] Raghu Angadi commented on HADOOP-1501: -- Does this mean we could get rid of {{blockReportIntervalBasis}} calcula

Re: Opening HRegionServer/HMaster/HClient for extension

2007-06-20 Thread Michael Stack
The patch looks like an improvement to me. Whats the rationale for needing to extend client/server? Do you think it of general applicability? I'd suggest making an issue and attaching a patch (file against hbase component and it looks like your tabs are not the hadoop two spaces convention

[jira] Commented: (HADOOP-1499) distcp creating extra directory when copying one file.

2007-06-20 Thread woyg (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506600 ] woyg commented on HADOOP-1499: -- In my opinion distcp should match *nix cp command as much as possible. So looks like th

Opening HRegionServer/HMaster/HClient for extension

2007-06-20 Thread James Kennedy
For what i'm doing I found it necessary to extend HRegionServer/HRegion/HClient for some custom functionality. Following good Java practice I see that the HBase code as been programmed defensively, keeping stuff private as much as possible. However, for extensibility it would be nice if the s

Hudson build is back to normal: Hadoop-Nightly #130

2007-06-20 Thread hudson
See http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/130/changes

[jira] Commented: (HADOOP-1292) dfs -copyToLocal should guarantee file is complete

2007-06-20 Thread dhruba borthakur (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506427 ] dhruba borthakur commented on HADOOP-1292: -- Looks good. A few comments: 1. I would rather not add a new me