Re: [[V2] 3/3] MEDIUM: add systemd service

2013-02-13 Thread Marc-Antoine Perennou
Hi, On 13 February 2013 08:11, Willy Tarreau w...@1wt.eu wrote: Hi Marc-Antoine, On Tue, Feb 12, 2013 at 10:53:54AM +0100, Marc-Antoine Perennou wrote: +systemd/haproxy.service: contrib/systemd/haproxy.service.in + mkdir -p systemd + sed -e 's:@SBINDIR@:'$(strip $(SBINDIR))':' $

[[V3] 3/3] MEDIUM: add systemd service

2013-02-13 Thread Marc-Antoine Perennou
Signed-off-by: Marc-Antoine Perennou marc-anto...@perennou.com --- .gitignore | 1 + contrib/systemd/Makefile | 8 contrib/systemd/haproxy.service.in | 11 +++ 3 files changed, 20 insertions(+) create mode 100644 contrib/systemd/Makefile

RE: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Lukas Tribus
Huh ? It is already present a few lines above : Correct, I was just confused about it because the other keywords like defer-accept or v4v6 are also present twice and tfo was missing below the comment: /* the versions with the NULL parse function*/. lukas@ubuntuvm:~/haproxy-ss-20130125/src$

Re: [PATCH 1/7] Correct logic in cut_crlf()

2013-02-13 Thread Simon Horman
On Tue, Feb 12, 2013 at 04:03:14AM +0100, Krzysztof Olędzki wrote: On 2013-02-12 02:45, Simon Horman wrote: This corrects what appears to be logic errors in cut_crlf(). I assume that the intention of this function is to truncate a string at the first cr or lf. However, currently lf are

Re: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Willy Tarreau
On Wed, Feb 13, 2013 at 09:40:31AM +0100, Lukas Tribus wrote: Looks like glibc only has support for TCP_FASTOPEN in the unreleased 2.18 version [1] and I'm using glibc 2.15 here. OK. Anyway I'm used not to rely on libcs found in the field because many users upgrade their kernels on supported

Re: [[V3] 3/3] MEDIUM: add systemd service

2013-02-13 Thread Willy Tarreau
Thanks Marc-Antoine, I've applied all your patches now. Willy

Re: [PATCH 0/7 v2] Agent Health Check

2013-02-13 Thread Willy Tarreau
Hi Simon, On Tue, Feb 12, 2013 at 10:45:47AM +0900, Simon Horman wrote: Hi, this series was previously sent as [PATCH 0/5] Dynamic Health Check. (...) OK these patches looked fine, I have applied them all. Thank you ! Willy

Re: [PATCH 0/7 v2] Agent Health Check

2013-02-13 Thread Simon Horman
On Wed, Feb 13, 2013 at 11:08:35AM +0100, Willy Tarreau wrote: Hi Simon, On Tue, Feb 12, 2013 at 10:45:47AM +0900, Simon Horman wrote: Hi, this series was previously sent as [PATCH 0/5] Dynamic Health Check. (...) OK these patches looked fine, I have applied them all. Great,

Re: [PATCH] Use PCRE JIT in acl

2013-02-13 Thread Willy Tarreau
Hi, sorry it was long, but I didn't have time to review it earlier. On Sun, Jan 13, 2013 at 03:00:42PM +0900, Hiroaki Nakamura wrote: Hi there. I saw the mail Re: PCRE = 8.20 JIT support in haproxy = 1.5.x? at 2011-12-27, and give it a try. This is a patch for using PCRE JIT in acl.

RE: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Lukas Tribus
Anyway I'm used not to rely on libcs found in the field because many users upgrade their kernels on supported distros. That's why there are so many defines in the makefile ! So do you think it would make sense to introduce a new build flag for TFO and define TCP_FASTOPEN? This would be

Re: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Willy Tarreau
On Wed, Feb 13, 2013 at 04:26:24PM +0100, Lukas Tribus wrote: Anyway I'm used not to rely on libcs found in the field because many users upgrade their kernels on supported distros. That's why there are so many defines in the makefile ! So do you think it would make sense to introduce a

RE: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Lukas Tribus
If you want I can send patches, but I will have to fix the mailer first. Yes, please do ! The attached patch fixes the doc/code comments and should reach you without being mangled. Lukas 0001-DOC-tfo-bump-required-kernel-to-linux-3.7.patch

Re: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Willy Tarreau
On Wed, Feb 13, 2013 at 11:42:27PM +0100, Lukas Tribus wrote: If you want I can send patches, but I will have to fix the mailer first. Yes, please do ! The attached patch fixes the doc/code comments and should reach you without being mangled. Done, thank you Lukas! Willy