Re: [PATCH] improving github experience, kindly ask people to reproduce bugs on latest haproxy

2019-09-23 Thread Willy Tarreau
Hi Lukas, On Tue, Sep 24, 2019 at 01:22:38AM +0200, Lukas Tribus wrote: > I realize I did not explain my point very well. I have to emphasize > that there is an important distinction between what we suggest in the > bug reporting template and what we actually *enforce*. Enforcements > happen

Re: [PATCH] improving github experience, kindly ask people to reproduce bugs on latest haproxy

2019-09-23 Thread Lukas Tribus
Hello Willy, On Mon, Sep 23, 2019 at 7:02 PM Willy Tarreau wrote: > > However it needs to be clear that the issue tracker in Github is not a > > support forum, and that filing a report will needs some ground work. > > It is also *always* a good idea to discuss an issue on the ML first, > >

Re: [PATCH] improving github experience, kindly ask people to reproduce bugs on latest haproxy

2019-09-23 Thread Илья Шипицин
пн, 23 сент. 2019 г. в 22:02, Willy Tarreau : > Hi guys, > > On Fri, Sep 20, 2019 at 03:47:17PM +0200, Lukas Tribus wrote: > > Hello Patrick, > > > > > > > I dunno, I've personally never been fond of it when bug reporters are > blindly asked to upgrade to the latest version. > > > > Everything

Re: [PATCH] BUG/MEDIUM: namespace: fix fd leak in master-worker mode

2019-09-23 Thread Willy Tarreau
Hi Krisztián, On Fri, Sep 20, 2019 at 02:48:19PM +, Krisztián Kovács (kkovacs) wrote: > When namespaces are used in the configuration, the respective namespace > handles > are opened during config parsing and stored in an ebtree for lookup later. > > Unfortunately, when the master process

Re: [PATCH] improving github experience, kindly ask people to reproduce bugs on latest haproxy

2019-09-23 Thread Willy Tarreau
Hi guys, On Fri, Sep 20, 2019 at 03:47:17PM +0200, Lukas Tribus wrote: > Hello Patrick, > > > > I dunno, I've personally never been fond of it when bug reporters are > > blindly asked to upgrade to the latest version. > > Everything you are saying is relevant for a support environment, like >

Re: [PATCH] BUG/MINOR: build: fix event ports (Solaris)

2019-09-23 Thread Willy Tarreau
Hi Manu, On Thu, Sep 19, 2019 at 04:10:02PM +0200, Emmanuel Hocdet wrote: > Please consider this patch. Thank you! Thinking that I was extremely careful when doing this one in the dark, I'm happy the only issue affecting it is that I forgot to rename the variable :-) Willy

Re: [PATCH] enabling slz, pcre2 builds in travis-ci

2019-09-23 Thread Willy Tarreau
On Thu, Sep 19, 2019 at 11:34:30PM +0500, ??? wrote: > please consider attached patch Merged, thank you Ilya. willy

Re: 1.9 external health checks fail suddenly

2019-09-23 Thread Willy Tarreau
Hi Veiko, On Mon, Sep 23, 2019 at 09:11:36AM +, Veiko Kukk wrote: > On 2019-08-28 11:13, Veiko Kukk wrote: > > Applied it to 1.9.10, after ~ 12h it ran into spinlock using 400% cpu > > (4 threads configured). Not sure if this is related to patch or is > > some new bug in 1.9.10. I've now

Re: 1.9 external health checks fail suddenly

2019-09-23 Thread Veiko Kukk
On 2019-08-28 11:13, Veiko Kukk wrote: Applied it to 1.9.10, after ~ 12h it ran into spinlock using 400% cpu (4 threads configured). Not sure if this is related to patch or is some new bug in 1.9.10. I've now replaced running instance with 1.9.10 without external check patch to see if this