Re: [RFC] Add weights to kubernetes-ingress

2020-03-19 Thread Moemen MHEDHBI
Hi David, On 18/03/2020 18:21, David Spitzer-Dulagan wrote: > > Hi, > > If this isn't the right place please let me know - after reading the > "contributing" page that was linked in the readme of > kubernetes-ingress I thought that this mailing list might be my best > bet to ask for your input. >

Re: [PATCH] CLEANUP: h2: Help static analyzers understand the list's end marker

2020-03-19 Thread Tim Düsterhus
Willy, Am 19.03.20 um 15:55 schrieb Willy Tarreau: > Actually I'm pretty sure that I did it this way precisely for performance > reasons: avoid repeatedly checking a pointer for half of the headers which > are pseudo headers (method, scheme, authority, path just for the request). > > It's perfect

[PATCH 1/2] BUG/MINOR: ssl: Do not free garbage pointers on memory allocation failure

2020-03-19 Thread Tim Duesterhus
In `ckch_inst_sni_ctx_to_sni_filters` use `calloc()` to allocate the filter array. When the function fails to allocate memory for a single entry the whole array will be `free()`d using free_sni_filters(). With the previous `malloc()` the pointers for entries after the failing allocation could possi

[PATCH 2/2] BUG/MINOR: ssl: Correctly add the 1 for the sentinel to the number of elements

2020-03-19 Thread Tim Duesterhus
William, I hope I correctly understood the purpose of that `+ 1` there. The issue was found using a static analyzer that complained that `fcount` could be zero, leading to a 0 byte allocation. If this fix is incorrect then the function must be adjusted to check for `fcount == 0` and do something s

Re: [PATCH] CLEANUP: h2: Help static analyzers understand the list's end marker

2020-03-19 Thread Willy Tarreau
Hi Tim, On Thu, Mar 19, 2020 at 03:15:24PM +0100, Tim Duesterhus wrote: > Willy, > > I know you dislike adjusting code to please static analyzers, but I'd argue > that using the new IST_NULL + isttest() combination is easier to understand > for humans as well. A simple .ptr == NULL check might a

[PATCH] CLEANUP: h2: Help static analyzers understand the list's end marker

2020-03-19 Thread Tim Duesterhus
Willy, I know you dislike adjusting code to please static analyzers, but I'd argue that using the new IST_NULL + isttest() combination is easier to understand for humans as well. A simple .ptr == NULL check might also be slightly faster compared to isteq() with an empty string? I have verified t

Re: More Traffic for haproxy.com

2020-03-19 Thread Robert Wesley
Hi haproxy.com Online Promotion has never been that critical as it’s now until you move ahead in a right direction. Every search engine now emphasis on user-experience, however going over your website what I can see optimization methods are quite ignorant. 1. Every search engines count *

Re: Segfault on 2.1.3

2020-03-19 Thread Christopher Faulet
Le 17/03/2020 à 16:41, Sean Reifschneider a écrit : The only place tcp-request appears in my config is in relation to rate-limiting, which we have set up to track but not enforce.  Here are the associated rules: frontend main     [...]     acl rate_whitelist src 10.0.0.1     acl rate_whiteli

[RFC] Add weights to kubernetes-ingress

2020-03-19 Thread David Spitzer-Dulagan
Hi, If this isn't the right place please let me know - after reading the "contributing" page that was linked in the readme of kubernetes-ingress I thought that this mailing list might be my best bet to ask for your input. I wanted to know if the following feature would be something you'd be

Re: [PATCH] fix errored ARM64 builds in travis-ci

2020-03-19 Thread Илья Шипицин
well, there are several topics on travis-ci forum related to "output on ARM64 got truncated in the mid of ..." Let us disable ARM64 travis-ci builds for few months. Martin, I'll play with hosted github runner in order to find a way how we can limit its builds to allowed only. ср, 18 мар. 2020 г.

[PATCH] temporarily disable travis-ci arm64 builds

2020-03-19 Thread Илья Шипицин
Hello, due to arm64 instability, let us disable arm64 builds until this is resolved. Cheers, Ilya Shipitcin From b39b8a6e4ebcae5a28f497170d4ae8e6b208023f Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 18 Mar 2020 23:37:12 +0500 Subject: [PATCH] CI: temporarily disable unstable travis a