Re: [PATCH] CI: cirrus: add alpine linux to the jobs

2021-06-14 Thread Илья Шипицин
That's why Travis badge in README.md makes sense On Mon, Jun 14, 2021, 5:16 PM Willy Tarreau wrote: > On Mon, Jun 14, 2021 at 02:33:20PM +0200, William Lallemand wrote: > > On Mon, Jun 14, 2021 at 12:01:11PM +0200, Tim Düsterhus wrote: > > > We only run Travis once weekly, because of the

Re: [PATCH 0/4] Use 'feature cmd' in regtests

2021-06-14 Thread Илья Шипицин
I believe William means conditions like "openssl is 1.1.0 or higher", but that's possible using grep пн, 14 июн. 2021 г. в 15:33, Tim Düsterhus : > William, > > On 6/14/21 12:12 PM, William Lallemand wrote: > >> > >> feature cmd "$HAPROXY_PROGRAM -vv |grep -vq BoringSSL" > >> > >> and then

Re: [PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

2021-06-13 Thread Илья Шипицин
Anyway, ACK from me. ulimit is less evil than sudo On Sun, Jun 13, 2021, 4:25 PM Tim Düsterhus wrote: > Ilya, > > On 6/13/21 3:18 PM, Илья Шипицин wrote: > > It was in my to do list as well. I recall I ran tests without increasing > > limits. > > > > Which test

Re: [PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

2021-06-13 Thread Илья Шипицин
It was in my to do list as well. I recall I ran tests without increasing limits. Which test requires 5 open files? Maybe the one currently disabled? Also, it does not like a good pattern to open so many files. If we really use as many files, shouldn't we revisit that area? On Sun, Jun 13,

[PATCH] typo fixes

2021-06-12 Thread Илья Шипицин
Hello, yet more typo and spelling fixes. Ilya From 3328f8814e7d1d5c1d708c3d5c6a472e645c9d71 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 12 Jun 2021 15:55:27 +0500 Subject: [PATCH] CLEANUP: assorted typo fixes in the code and comments This is 24th iteration of typo fixes ---

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

2021-06-12 Thread Илья Шипицин
final apline/musl patch attached пт, 11 июн. 2021 г. в 23:02, Илья Шипицин : > it works :) > > oops · chipitsine/haproxy@2ce9681 (github.com) > <https://github.com/chipitsine/haproxy/runs/2805388200> > > I'll polish it a bit and will send final patch tomorrow > &g

Re: [PATCH 0/4] Use 'feature cmd' in regtests

2021-06-11 Thread Илья Шипицин
haproxy/regression-testing.txt at master · haproxy/haproxy (github.com) <https://github.com/haproxy/haproxy/blob/master/doc/regression-testing.txt> can it be converted into md/rst ?? please please ? пт, 11 июн. 2021 г. в 23:19, Илья Шипицин : > there's reg-test documentation for

Re: [PATCH 0/4] Use 'feature cmd' in regtests

2021-06-11 Thread Илья Шипицин
there's reg-test documentation for beginners. should it be updated as well ? пт, 11 июн. 2021 г. в 22:56, Tim Duesterhus : > Hi! > > I hope I added all the active developers that touch the reg-tests to the > 'CC' > list :-) > > This series updates the regtests to make use of VTest's 'feature

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

2021-06-11 Thread Илья Шипицин
it works :) oops · chipitsine/haproxy@2ce9681 (github.com) <https://github.com/chipitsine/haproxy/runs/2805388200> I'll polish it a bit and will send final patch tomorrow пт, 11 июн. 2021 г. в 20:42, Илья Шипицин : > > > пт, 11 июн. 2021 г. в 20:34, William Lallemand : >

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

2021-06-11 Thread Илья Шипицин
пт, 11 июн. 2021 г. в 20:34, William Lallemand : > On Fri, Jun 11, 2021 at 08:14:49PM +0500, Илья Шипицин wrote: > > I've found ubuntu musl package, so we can just link to it in CI, for > > example (I'll try) > > > > > Well, that won't give you the same e

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

2021-06-11 Thread Илья Шипицин
пт, 11 июн. 2021 г. в 20:18, Willy Tarreau : > On Fri, Jun 11, 2021 at 08:14:49PM +0500, ??? wrote: > > @Willy Tarreau , do you think it is good idea to display libc > > variant in "haproxy -vv" ? > > If needed we can (for those that are detectable), but I'm not convinced > of the

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

2021-06-11 Thread Илья Шипицин
@Willy Tarreau , do you think it is good idea to display libc variant in "haproxy -vv" ? (not sure actually whether musl represent itself in recognizable way) I've found ubuntu musl package, so we can just link to it in CI, for example (I'll try) пт, 11 июн. 2021 г. в 20:03, Ил

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

2021-06-11 Thread Илья Шипицин
пт, 11 июн. 2021 г. в 19:43, William Lallemand : > On Fri, Jun 11, 2021 at 07:09:14PM +0500, Илья Шипицин wrote: > > I'm against expanding cirrus matrix. cirrus is overloaded already, I'm > > afraid they will not stay for long time. > > using custom images in github actio

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

2021-06-11 Thread Илья Шипицин
William, if you do not have a time, I can try to create github action based on your cirrus patch ... tomorrow ? пт, 11 июн. 2021 г. в 19:09, Илья Шипицин : > I'm against expanding cirrus matrix. cirrus is overloaded already, I'm > afraid they will not stay for long time. > using cust

Re: [PATCH] CI: cirrus: add alpine linux to the jobs

2021-06-11 Thread Илья Шипицин
I'm against expanding cirrus matrix. cirrus is overloaded already, I'm afraid they will not stay for long time. using custom images in github actions is straightforward, have a look centos 6 · chipitsine/haproxy@20fabcd (github.com)

Re: Speeding up opentracing build in CI ?

2021-06-10 Thread Илья Шипицин
I was mistaken. LibreSSL does not like parallel install libressl fails on `make -j4 install` · Issue #461 · libressl-portable/portable (github.com) anyway, if CI works, I'm ok with changes чт, 10 июн. 2021 г. в 20:49, William Lallemand

Re: Speeding up opentracing build in CI ?

2021-06-10 Thread Илья Шипицин
openssl does not support -j for make install I filed a bug on them, they told me "OK, just don't use it" On Thu, Jun 10, 2021, 8:52 AM Willy Tarreau wrote: > On Thu, Jun 10, 2021 at 07:19:37AM +0200, Willy Tarreau wrote: > > On Thu, Jun 10, 2021 at 10:15:46AM +0500, ??? wrote: > > >

Re: Speeding up opentracing build in CI ?

2021-06-09 Thread Илья Шипицин
OT takes about 30 sec (it is built with almost everything disabled). the biggest time eater is openssl-3.0.0 hopefully, OT will speed up to 10 sec by using parallel builds чт, 10 июн. 2021 г. в 10:05, Willy Tarreau : > On Thu, Jun 10, 2021 at 07:55:17AM +0300, ??? wrote: > > First one

Re: Speeding up opentracing build in CI ?

2021-06-09 Thread Илья Шипицин
First one is supposed to be cached one day together with "opt" folder. However, we can indeed use parallel builds until cache is enabled for github actions On Thu, Jun 10, 2021, 7:49 AM Willy Tarreau wrote: > Tim, Ilya, > > while testing Miroslav's fix, I found the opentracing build to be

Re: enaling cache in github actions

2021-06-08 Thread Илья Шипицин
16:59, Tim Düsterhus : > Ilya, > > On 5/15/21 5:30 PM, Илья Шипицин wrote: > > I've found that we do not cache "download-cache" and "opt" folders, > > thus we build BoringSSL on every build (no cache). > > > > I tried to enable cache > > >

Re: [PATCH] CI: Make matrix.py executable and add shebang

2021-06-08 Thread Илья Шипицин
ack from me. вт, 8 июн. 2021 г. в 18:17, Tim Duesterhus : > It's a script, allow executing this as a script without needing to invoke > `python3` manually. > --- > .github/matrix.py | 2 ++ > 1 file changed, 2 insertions(+) > mode change 100644 => 100755 .github/matrix.py > > diff --git

Re: [PATCH] CI: enable openssl-3.0.0 builds

2021-06-07 Thread Илья Шипицин
lliam Lallemand wrote: > > > > On Mon, Jun 07, 2021 at 04:02:00PM +0500, Илья Шипицин wrote: > > > >> sorry, I do not have much spare time to implement that in short time > > > >> perspective. > > > >> I think of 2-3 month timeframe. > > &

Re: [PATCH] CI: enable openssl-3.0.0 builds

2021-06-07 Thread Илья Шипицин
пн, 7 июн. 2021 г. в 16:31, William Lallemand : > On Mon, Jun 07, 2021 at 04:02:00PM +0500, Илья Шипицин wrote: > > sorry, I do not have much spare time to implement that in short time > > perspective. > > I think of 2-3 month timeframe. > > > > Isn't it possibl

Re: [PATCH] CI: enable openssl-3.0.0 builds

2021-06-04 Thread Илья Шипицин
here are two patches: - deprecated warnings suppressed - openssl-3.0.0 enabled ср, 2 июн. 2021 г. в 21:51, Tim Düsterhus : > Dinko, > > On 6/2/21 1:34 PM, Dinko Korunic wrote: > > Yes, GItHub Actions has support for flagging some of the jobs in matrix > as experimental (which will permit job to

Re: Modify POST data (with lua)?

2021-06-02 Thread Илья Шипицин
ср, 2 июн. 2021 г. в 18:00, Elias Abacioglu < elias.abacio...@deltaprojects.com>: > > Hi Tim > > On Wed, Jun 2, 2021 at 12:38 PM Tim Düsterhus wrote: > >> Elias, >> >> On 6/2/21 12:16 PM, Elias Abacioglu wrote: >> > I'm planning on placing an API behind HAProxy and want a way to modify >> the >>

Re: [PATCH] CI: enable openssl-3.0.0 builds

2021-06-02 Thread Илья Шипицин
ср, 2 июн. 2021 г. в 16:27, Tim Düsterhus : > Ilya, > > On 6/2/21 12:58 PM, Илья Шипицин wrote: > > as openssl-3.0.0 is getting close to release, let us add it to build > matrix. > > > > I dislike that this is going to report all commits in red, until the > build

[PATCH] CI: enable openssl-3.0.0 builds

2021-06-02 Thread Илья Шипицин
Hello, as openssl-3.0.0 is getting close to release, let us add it to build matrix. thanks, Ilya From 1651766c81e141c1a077499e151e6c619289883a Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 2 Jun 2021 10:42:09 + Subject: [PATCH] CI: github actions: add OpenSSL-3.0.0 builds

Re: how to write to a file safely in haproxy

2021-05-26 Thread Илья Шипицин
Not clear what recommendation did you read. you might consider dataplane api for config management: haproxytech/dataplaneapi: HAProxy Data Plane API (github.com) On Wed, May 26, 2021, 4:32 PM reshma r wrote: > Hello all, > Periodically I need to

Re: [PATCH] CI: enable OpenTracing feature

2021-05-18 Thread Илья Шипицин
Miroslav, can you please keep an eye on patch from OpenTracing build failures using clang · Issue #1242 · haproxy/haproxy (github.com) ? вт, 18 мая 2021 г. в 21:38, Willy Tarreau : > On Tue, May 18, 2021 at 01:32:56PM +0200, Tim Düsterhus wrote:

[PATCH] CI: enable OpenTracing feature

2021-05-18 Thread Илья Шипицин
Hello, this enables OpenTracing for CI builds. thanks. Ilya From 9ca15c0d95b1c4fa5dc040116f9ec006712095f1 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Tue, 18 May 2021 09:46:43 + Subject: [PATCH] CI: github actions: add OpenTracing builds let us add OpenTracing module to "all

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-18 Thread Илья Шипицин
вт, 18 мая 2021 г. в 13:54, Willy Tarreau : > On Sat, May 15, 2021 at 05:53:57PM +0200, Tim Düsterhus wrote: > > Willy, > > Ilya, > > > > On 5/15/21 8:58 AM, ??? wrote: > > > I attached a patch that uses "curl". on a distance it seems to be > faster > > > for 50% > > > > > > > This one

Re: unexpected asan behaviour

2021-05-18 Thread Илья Шипицин
Maybe sudo drops env variables On Tue, May 18, 2021, 12:29 PM Tim Düsterhus wrote: > Ilya, > > On 5/17/21 3:57 PM, Илья Шипицин wrote: > > FYI, this is not what it supposed to be > > > > BUILD/MINOR: ssl: Fix compilation with SSL enabled · > > haproxy/haprox

unexpected asan behaviour

2021-05-17 Thread Илья Шипицин
Tim, FYI, this is not what it supposed to be BUILD/MINOR: ssl: Fix compilation with SSL enabled · haproxy/haproxy@d75b99e (github.com) according to global ASAN_OPTIONS it was supposed to go to separate log. but something went wrong :) it is

enaling cache in github actions

2021-05-15 Thread Илья Шипицин
I've found that we do not cache "download-cache" and "opt" folders, thus we build BoringSSL on every build (no cache). I tried to enable cache https://github.com/chipitsine/haproxy/blob/master/.github/workflows/vtest.yml#L46-L53 github does not like such caching keys: Error: Key Validation

Re: DNS service discovery and consistent hashing

2021-05-15 Thread Илья Шипицин
maybe using dataplane api https://github.com/haproxytech/dataplaneapi will give you required flexibility пт, 14 мая 2021 г. в 01:58, Andrew Rodland : > At Vimeo we have a custom tool since 2015 that monitors the membership of > clusters of servers, templates out a config with servers assigned

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-15 Thread Илья Шипицин
сб, 15 мая 2021 г. в 01:14, Илья Шипицин : > > > сб, 15 мая 2021 г. в 00:56, Nicolas CARPi : > >> > I compared several times, git clone is faster >> In my hands curl is the fastest option compared to git clone. >> > > ok, I'll make more comparison tomorrow

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-14 Thread Илья Шипицин
сб, 15 мая 2021 г. в 00:56, Nicolas CARPi : > > I compared several times, git clone is faster > In my hands curl is the fastest option compared to git clone. > ok, I'll make more comparison tomorrow > > Wouldn't "git clone --depth 1" be a good option to consider here? It > avoids getting the

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-14 Thread Илья Шипицин
сб, 15 мая 2021 г. в 00:20, Tim Düsterhus : > Ilya, > > On 5/14/21 9:02 PM, Илья Шипицин wrote: > > let us unify VTest installation magic. > > I disagree with using 'git clone' here, cloning the repository with full > history is wasteful. Please use the tarball approach f

[PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-14 Thread Илья Шипицин
Hello, let us unify VTest installation magic. Ilya From 9f85fe25ad9ee6bf753311a44a5089a6ee2096c9 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 14 May 2021 23:59:35 +0500 Subject: [PATCH] CI: introduce scripts/build-vtest.sh for installing VTest we install VTest for all CI systems,

Re: adding Coverity badge to some visible place

2021-05-14 Thread Илья Шипицин
some tools (e.g. Coverity, Travis-CI) are not attached to commits directly. travis runs once a week, badge would be nice as well пт, 14 мая 2021 г. в 20:45, Daniel Corbett : > Hello Ilya, > > > From: Илья Шипицин > > Sent: Friday, May 14, 2021 11:10 AM > > To: HAPr

adding Coverity badge to some visible place

2021-05-14 Thread Илья Шипицин
Hello, I would like to improve code quality visibility. what if we convert README --> README.md and put Coverity badge there ? Ilya

Re: [PATCH] BUILD/MINOR: opentracing: fixed compilation with filter, enabled

2021-05-12 Thread Илья Шипицин
I did not mean to postpone Miroslav's patch :) On Wed, May 12, 2021, 10:39 AM Willy Tarreau wrote: > Hi Ilya, > > On Tue, May 11, 2021 at 10:59:46PM +0500, ??? wrote: > > I tried opentracing ci, I estimate 1-2 weeks to stabilize. Can we delay > 2.4 > > after that? > > If you mean

Re: [PATCH] BUILD/MINOR: opentracing: fixed compilation with filter, enabled

2021-05-11 Thread Илья Шипицин
I tried opentracing ci, I estimate 1-2 weeks to stabilize. Can we delay 2.4 after that? On Tue, May 11, 2021, 10:37 PM Miroslav Zagorac wrote: > Hello, > > The inclusion of header files proxy.h and tools.h was added to the > addons/ot/include/include.h file. Without this HAProxy cannot be >

Re: [PATCH] CI: Build VTest with clang

2021-05-10 Thread Илья Шипицин
There are vtest build in cirrus and travis as well. What if we move vtest building into "scripts/build-vtest.sh" ? On Tue, May 11, 2021, 1:54 AM Tim Duesterhus wrote: > Willy, > Ilya, > > not tested, but it should be simple enough to not mess it up. > > Best regards > Tim Düsterhus > > Apply

[PATCH] spell check fixes

2021-05-10 Thread Илья Шипицин
Hello, yet another spell check improvements. Ilya From 58ea7d81c586a609aa7bdea44d0c33a7de500fda Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Mon, 10 May 2021 12:50:00 +0500 Subject: [PATCH 2/2] CLEANUP: assorted typo fixes in the code and comments This is 23rd iteration of typo fixes

[PATCH] enable QUIC for CI builds when appropriate

2021-05-09 Thread Илья Шипицин
Hello, USE_QUIC=1 added for BoringSSL builds. thanks, Ilya From 2a79e92bdac01d926e7f85583f455db17f1515bb Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sun, 9 May 2021 21:27:28 +0500 Subject: [PATCH] CI: Github Actions: enable USE_QUIC=1 for BoringSSL builds if haproxy is built against

Re: [PATCH] MINOR: opentracing: register config file and line number on log servers

2021-05-08 Thread Илья Шипицин
7939eaa8d3310378d419d90c5#diff-b525f86b1f4925509959f857496dff18a9c4ed34fcc7f49357c5a6d00fb64d17R91 Tim, do you know how to add it using ${{ contains(matrix.FLAGS, 'USE_OT=1') }} condition ? чт, 8 апр. 2021 г. в 14:44, Илья Шипицин : > > > чт, 8 апр. 2021 г. в 14:25, Willy Tarreau : > &

[PATCH] CI: switch to the latest stable LibreSSL-3.3.3

2021-05-04 Thread Илья Шипицин
Hello, LibreSSL-3.3.3 just released. patch attached. thanks, Ilya From bddc3bb1f9726b1bee964a66e77575f054faae2b Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 5 May 2021 09:01:03 +0500 Subject: [PATCH] CI: Github Actions: switch to LibreSSL-3.3.3 stable LibreSSL-3.3.3 released, let

[PATCH] typo fixes

2021-04-24 Thread Илья Шипицин
hello, one more typo fixing. Ilya From 95a5f29e573ef02bc31c74d426f2db8fbdc1f57d Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 24 Apr 2021 13:25:42 +0500 Subject: [PATCH] CLEANUP: assorted typo fixes in the code and comments This is 22nd iteration of typo fixes ---

[PATCH] CI: travis-ci: enable graviton2 builds

2021-04-15 Thread Илья Шипицин
Hello, as described in travis-ci docs: https://blog.travis-ci.com/2020-09-11-arm-on-aws it is next generation armv8 available on AWS. cheers, Ilya From 4365c936396a5c7c4f710ed8267b06a73fd5bbcc Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 15 Apr 2021 19:16:09 +0500 Subject: [PATCH]

[PATCH] fix cirrus-ci builds by installing "pcre" package

2021-04-14 Thread Илья Шипицин
Hello, something changed in freebsd packaging. we now need to install pcre directly. Ilya From 406a5b8cfee330cc74c18f0eca1811195e7eff6d Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 14 Apr 2021 21:47:34 +0500 Subject: [PATCH] CI: cirrus: install "pcre" package it turned out that our

Re: [ANNOUNCE] haproxy-2.4-dev16

2021-04-12 Thread Илья Шипицин
Dear Team, can we address at least #1112, #1119 before 2.4 is released ? пт, 9 апр. 2021 г. в 20:52, Willy Tarreau : > Hi, > > HAProxy 2.4-dev16 was released on 2021/04/09. It added 37 new commits > after version 2.4-dev15. > > This one is particularly calm, I even hesitated between making it

Re: [PATCH] MINOR: opentracing: register config file and line number on log servers

2021-04-08 Thread Илья Шипицин
чт, 8 апр. 2021 г. в 14:25, Willy Tarreau : > On Wed, Apr 07, 2021 at 05:26:24PM +0500, ??? wrote: > > we run "all features anebled" gcc and clang builds, for example > > BUG/MINOR: tools: fix parsing "us" unit for timers · > > haproxy/haproxy@a683805 (github.com) > > < >

Re: [PATCH] MINOR: opentracing: register config file and line number on log servers

2021-04-07 Thread Илья Шипицин
On Wed, Apr 7, 2021, 2:16 PM Miroslav Zagorac wrote: > On 04/07/2021 12:13 PM, Илья Шипицин wrote: > > do you consider adding opentracing to "github actions" CI ? > > > > Hello Илья, > > I don't know how to add it because I never used it. The filter uses &

Re: [PATCH] MINOR: opentracing: register config file and line number on log servers

2021-04-07 Thread Илья Шипицин
do you consider adding opentracing to "github actions" CI ? ср, 7 апр. 2021 г. в 14:35, Miroslav Zagorac : > Hello, > > due to the modified function declaration, the opentracing filter can no > longer be compiled. > > In commit 9533a7038 new parameters have been added to the declaration > of

Re: zlib vs slz (perfoarmance)

2021-03-30 Thread Илья Шипицин
вт, 30 мар. 2021 г. в 17:44, Willy Tarreau : > On Tue, Mar 30, 2021 at 02:25:14PM +0500, ??? wrote: > > I would wait for feedback from some other high load projects. From my > > observation it is significant benefit. > > Originally slz was written for use in haproxy to solve the huge

Re: zlib vs slz (perfoarmance)

2021-03-30 Thread Илья Шипицин
I would wait for feedback from some other high load projects. From my observation it is significant benefit. On Tue, Mar 30, 2021, 12:18 PM Dinko Korunic wrote: > On 30.03.2021., at 08:17, Илья Шипицин wrote: > > > > I would really like to know whether zlib was cho

Re: zlib vs slz (perfoarmance)

2021-03-30 Thread Илья Шипицин
I would really like to know whether zlib was chosen for purpose or by chance. And yes, some marketing campaign makes sense On Tue, Mar 30, 2021, 10:35 AM Dinko Korunic wrote: > > > On 29.03.2021., at 23:06, Lukas Tribus wrote: > > > > […] > > > Like I said last year, this needs a marketing

Re: zlib vs slz (perfoarmance)

2021-03-29 Thread Илья Шипицин
пн, 29 мар. 2021 г. в 19:35, Lukas Tribus : > Hi Ilya, > > > On Mon, 29 Mar 2021 at 15:34, Илья Шипицин wrote: > > > > Dear list, > > > > on browser load (html + js + css) I observe 80% of cpu spent on gzip. > > also, I observe that zlib is probabl

zlib vs slz (perfoarmance)

2021-03-29 Thread Илья Шипицин
Dear list, on browser load (html + js + css) I observe 80% of cpu spent on gzip. also, I observe that zlib is probably one of the slowest implementation my personal benchmark correlate with https://github.com/inikep/lzbench if so, should'n we switch to slz by default ? or am I missing something

[PATCH] BUILD: ssl: use EVP_CIPH_GCM_MODE macro instead of HA_OPENSSL_VERSION

2021-03-26 Thread Илья Шипицин
Hello, yet another patch that removes few HA_OPENSSL_VERSION usage. Ilya From cda2194398d8c7a4b0ca07ab2ed47c290c92b64f Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 26 Mar 2021 23:35:31 +0500 Subject: [PATCH] BUILD: ssl: use EVP_CIPH_GCM_MODE macro instead of HA_OPENSSL_VERSION

Re: [PATCH] fine guard for ssl random extraction functions

2021-03-26 Thread Илья Шипицин
Ping :) On Thu, Mar 25, 2021, 12:52 AM Илья Шипицин wrote: > Hello, > > yet another patch that removes several occurrences of HA_OPENSSL_VERSION > also, fetches enabled for BoringSSL and LibreSSL-2.7.0 and higher > > Ilya >

[PATCH] fine guard for ssl random extraction functions

2021-03-24 Thread Илья Шипицин
Hello, yet another patch that removes several occurrences of HA_OPENSSL_VERSION also, fetches enabled for BoringSSL and LibreSSL-2.7.0 and higher Ilya From dcdfb25d51e44bf84175514a4a6b786b9c15e20e Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 25 Mar 2021 00:41:41 +0500 Subject:

Re: [PATCH] BUILD: ssl: use feature guard instead of openssl version for ecdh functions

2021-03-24 Thread Илья Шипицин
ping вс, 21 мар. 2021 г. в 13:02, Илья Шипицин : > Hello, > > yet another patch that reduces number of HA_OPENSSL_VERSION use > > Ilya > > >

Re: [PATCH] cleanup unused definitions

2021-03-24 Thread Илья Шипицин
ping сб, 20 мар. 2021 г. в 22:43, Илья Шипицин : > while refactoring HA_OPENSSL_VERSION usage, > I've found unused definitions. nice. > > > Ilya >

[PATCH] BUILD: ssl: use feature guard instead of openssl version for ecdh functions

2021-03-21 Thread Илья Шипицин
Hello, yet another patch that reduces number of HA_OPENSSL_VERSION use Ilya From 6a33427cf8dce1fbde37f4ad2056c2012d8968e4 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sun, 21 Mar 2021 12:50:47 +0500 Subject: [PATCH] BUILD: ssl: guard ecdh functions with SSL_CTX_set_tmp_ecdh macro let

[PATCH] cleanup unused definitions

2021-03-20 Thread Илья Шипицин
while refactoring HA_OPENSSL_VERSION usage, I've found unused definitions. nice. Ilya From c5ba9de13cb7d5eda4781731bb4bfb68c823114c Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 20 Mar 2021 22:30:59 +0500 Subject: [PATCH] CLEANUP: remove unused definitions not need since

Re: [PATCH] cleanup #1162 coverity "finding"

2021-03-20 Thread Илья Шипицин
OK, I will mark as false positive On Sat, Mar 20, 2021, 1:42 PM Willy Tarreau wrote: > Hi Ilya, > > On Fri, Mar 19, 2021 at 11:19:14PM +0500, ??? wrote: > > Hello, > > > > pure cleanup, should fix #1162 > > > > Ilya > > > From 7915f3ed189e0db371699fa8c8eb74a69584ed27 Mon Sep 17

Re: [PATCH] spelling fixes

2021-03-20 Thread Илья Шипицин
I'll see whether capitalised word inside sentence might be ignored. It is OK to check in the beginning On Sat, Mar 20, 2021, 1:32 PM Willy Tarreau wrote: > Merged, thanks Ilya. Poor Dragan, caught by the spell checker :-) > > Do you think the spell checker could be tuned to ignore capitalized >

[PATCH] cleanup #1162 coverity "finding"

2021-03-19 Thread Илья Шипицин
Hello, pure cleanup, should fix #1162 Ilya From 7915f3ed189e0db371699fa8c8eb74a69584ed27 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 19 Mar 2021 23:06:36 +0500 Subject: [PATCH] CLEANUP: move "tmp_ssl" definition and usage only when it is required if we do not have

[PATCH] update libressl to 3.2.5, enable tls session resumption in reg-tests

2021-03-19 Thread Илья Шипицин
Hello, let us update libressl to 3.2.5 and revert previously disabled tls session resumption in reg-test Ilya From 6453e067c877db1ac98f92220dccebab572eaaf1 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 19 Mar 2021 22:29:16 +0500 Subject: [PATCH 1/2] CI: github actions: update

[PATCH] spelling fixes

2021-03-19 Thread Илья Шипицин
Hello, yet another spelling fix. Ilya From 19b36c9c9b227d918a44dcc830ea197da145cd32 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 19 Mar 2021 22:15:12 +0500 Subject: [PATCH 1/2] CI: codespell: whitelist "Dragan Dosen" let us tell codespell that "Dosen" is legitimate spelling ---

is it possible to rotate TLS keys in scheduled way ?

2021-03-19 Thread Илья Шипицин
Hello, can we have the following ? 1) TLS tickets are persistent, i.e. they survive reload 2) we can specify ttl of tickets Ilya

[PATCH] typo fix

2021-03-12 Thread Илья Шипицин
Hello, yet another spelling fix Ilya From e5d2a87726678664ddbc6fae27b2bb9e7ffb3e03 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 12 Mar 2021 21:53:34 +0500 Subject: [PATCH] CLEANUP: assorted typo fixes in the code and comments This is 20th iteration of typo fixes ---

curious regarding SO_INCOMING_CPU

2021-03-04 Thread Илья Шипицин
Hello, did anybody investigated benefits of SO_INCOMING_CPU ? (just curious) Ilya

[PATCH] fix some typo

2021-03-04 Thread Илья Шипицин
Hello, another round of typo cleanup Ilya From a63c4b2373fd7fff2a02e57c79e2e2c85513ae00 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 4 Mar 2021 23:26:15 +0500 Subject: [PATCH] CLEANUP: assorted typo fixes in the code and comments This is 19th iteration of typo fixes ---

Re: [PATCH] spell check fixes, spell rules exclusion

2021-02-26 Thread Илья Шипицин
ping :) сб, 20 февр. 2021 г. в 00:25, Илья Шипицин : > Hello, > > couple of spell check fixes. > > Ilya >

Aggregated "stats" in multithreaded env?

2021-02-20 Thread Илья Шипицин
Hello, What would be best practice to collect aggregated stats? Ilya

[PATCH] spell check fixes, spell rules exclusion

2021-02-19 Thread Илья Шипицин
Hello, couple of spell check fixes. Ilya From b7c727d7dd358aa0e3191ce302d7489617909603 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 20 Feb 2021 00:18:00 +0500 Subject: [PATCH 1/2] CI: codespell: skip Makefile for spell check checking Makefile is noisy, we do not benefit from it ---

[PATCH] BUILD: SSL: introduce fine guard for openssl specific "RAND_keep_random_devices_open"

2021-02-19 Thread Илья Шипицин
Hello, another "get rid of HA_OPENSSL_VERSION" cleanup. Ilya From 51b86c8b776b3462546a4037bf3a5022ccf6b709 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 19 Feb 2021 23:42:53 +0500 Subject: [PATCH] BUILD: SSL: introduce fine guard for RAND_keep_random_devices_open

Re: [PATCH] CI: switch to stable LibreSSL release

2021-02-19 Thread Илья Шипицин
пт, 19 февр. 2021 г. в 22:08, Willy Tarreau : > On Fri, Feb 19, 2021 at 12:22:00PM +0500, ??? wrote: > > I attached a patch that switches to LibreSSL-3.2.X > > Thanks Ilya, now applied! > > > (in the future, I'll have a look whether it is good idea to try libressl > > master branch or

[PATCH] CI: switch to stable LibreSSL release

2021-02-18 Thread Илья Шипицин
I attached a patch that switches to LibreSSL-3.2.X (in the future, I'll have a look whether it is good idea to try libressl master branch or not) Ilya From c5dc6ff148214b314673c6ee1f83cb973ee4b1db Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 19 Feb 2021 12:09:31 +0500 Subject:

Re: [PATCH] introduce guard for SCTL openssl specific functions

2021-02-18 Thread Илья Шипицин
ping :) On Sat, Feb 13, 2021, 11:48 AM Илья Шипицин wrote: > I changed macro name, new patch attached > > сб, 13 февр. 2021 г. в 03:41, William Lallemand : > >> On Sat, Feb 13, 2021 at 12:21:56AM +0500, Илья Шипицин wrote: >> > Hello, >> > >>

Re: Discussion around a first set of config preprocessing functions

2021-02-16 Thread Илья Шипицин
Hello, I'm happy using dpapi to query/change values. Actually any external template engine is ok. not sure that having that level of complication inside worth efforts spent on it. as a side question, would it be as easy as it is now to use dpapi on top of "if/else" config ? вт, 16 февр. 2021 г.

Re: [PATCH] introduce guard for SCTL openssl specific functions

2021-02-12 Thread Илья Шипицин
I changed macro name, new patch attached сб, 13 февр. 2021 г. в 03:41, William Lallemand : > On Sat, Feb 13, 2021 at 12:21:56AM +0500, Илья Шипицин wrote: > > Hello, > > > > let as switch to feature macro instead of HA_OPENSSL_VERSION. > > > > Ilya > &g

[PATCH] introduce guard for SCTL openssl specific functions

2021-02-12 Thread Илья Шипицин
Hello, let as switch to feature macro instead of HA_OPENSSL_VERSION. Ilya From ddae23ca3503f29416cb04dc5689282be67df087 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 13 Feb 2021 00:16:58 +0500 Subject: [PATCH] BUILD: ssl: introduce fine guard for OpenSSL specific SCTL functions

[PATCH] fix freebsd ci, update freebsd image

2021-02-11 Thread Илья Шипицин
Hello, attached patch fix freebsd builds. Ilya From 6b2c848cfa563f5b0c8cd34f3fa5ce99847d91a3 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 11 Feb 2021 23:32:30 +0500 Subject: [PATCH] CI: cirrus: update FreeBSD image to 12.2 we already tried to run FreeBSD-stable. it is pain, so we

[PATCH] cleanup: remove unused variable assignment

2021-02-10 Thread Илья Шипицин
Hello, this is pure cleanup. should fix #1048 Ilya From 350c37117369607928ddb232cf8f86b1c218bd47 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 10 Feb 2021 13:03:30 +0500 Subject: [PATCH] CLEANUP: remove unused variable assigned found by Coverity this is pure cleanup, no need to

Re: TCP mode and ultra short lived connection

2021-02-08 Thread Илья Шипицин
it clear: the problem is the data > received from these fast clients never reaches backends. But it should be > delivered in order to be saved. > > Maybe there is some way to delay acknowledging of the data received until > some backend is selected and connected to session? > > >

Re: TCP mode and ultra short lived connection

2021-02-08 Thread Илья Шипицин
I think it is "4. Client disconnects (FIN, FIN-ACK)" if client would send RST instead of FIN, port would have been released immediately. https://stackoverflow.com/questions/13049828/fin-vs-rst-in-tcp-connections RST is much better for short living connections. пн, 8 февр. 2021 г. в 22:17,

Re: [PATCH] BUILD: ssl: guard SSL_CTX_set_msg_callback with SSL_CTRL_SET_MSG_CALLBACK macro

2021-02-08 Thread Илья Шипицин
usually I do such a stupid mistakes on friday. I wonder about next friday :( new patch attached. Ilya пн, 8 февр. 2021 г. в 17:08, William Lallemand : > On Mon, Feb 08, 2021 at 05:03:43PM +0500, Илья Шипицин wrote: > > I've added commit message. > > > >

Re: [PATCH] BUILD: ssl: guard SSL_CTX_set_msg_callback with SSL_CTRL_SET_MSG_CALLBACK macro

2021-02-08 Thread Илья Шипицин
I've added commit message. Ilya сб, 23 янв. 2021 г. в 21:46, William Lallemand : > Hello, > > On Sat, Jan 23, 2021 at 02:06:41AM +0500, Илья Шипицин wrote: > > Hello, > > > > another ssl guard patch > > > > Ilya > > > From f39f9f69e29570fa4

[PATCH] typo fixes

2021-02-06 Thread Илья Шипицин
Hello, another cleanup. Ilya From c9fd28093d04050a9fddef84a7fd99686831aaf4 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 6 Feb 2021 22:29:08 +0500 Subject: [PATCH] CLEANUP: assorted typo fixes in the code and comments This is 17th iteration of typo fixes ---

Re: [PATCH} improve ssl guarding

2021-02-06 Thread Илья Шипицин
you are right. I've fixed it. сб, 23 янв. 2021 г. в 21:41, William Lallemand : > On Sat, Jan 23, 2021 at 04:50:08PM +0500, Илья Шипицин wrote: > > Hello, > > > > yet another guard improving patch (forgot to fix last time) > > >

Re: (possibly off topic) how to handle Chrome on SSL mass hosting ?

2021-02-03 Thread Илья Шипицин
вт, 1 дек. 2020 г. в 00:37, Tim Düsterhus : > Ilya, > > Am 30.11.20 um 20:21 schrieb Илья Шипицин: > > I guess here are people running similar high density SSL hosting, do you > > have some approaches to please Chrome ? I would be happy if I can tell > him > >

Re: SSL session resumption

2021-02-03 Thread Илья Шипицин
TLS1.2 uses tls tickets, when TLS1.0 uses ssl sessions. you have disabled tls tickets in config. is there a chance that you upgraded from tls1.0 to tls1.2 ? (it should be clearly seen in wireshark) people usually disable tls tickets (and ssl sessions) for security considerations, in such case

Re: SSL session resumption

2021-02-03 Thread Илья Шипицин
Can you provide wireshark capture? It is very useful On Wed, Feb 3, 2021, 5:39 PM Johan Andersson wrote: > To whom it may concern > > > > We have recently upgraded out HAProxy version from 2.1.3 to 2.2.4. > > After the upgrade we got customer complaints that the data usage of their > devices

Re: [PATCH 2/2] CI: Fix DEBUG_STRICT definition for Coverity

2021-01-29 Thread Илья Шипицин
14 issues "eliminated" by BUG_ON visibility. [image: Screenshot from 2021-01-29 13-08-49.png] пт, 29 янв. 2021 г. в 01:42, Илья Шипицин : > > > пт, 29 янв. 2021 г. в 00:39, Willy Tarreau : > >> On Fri, Jan 29, 2021 at 12:37:55AM +0500, ??? wrote: >

Re: [PATCH 2/2] CI: Fix DEBUG_STRICT definition for Coverity

2021-01-28 Thread Илья Шипицин
пт, 29 янв. 2021 г. в 00:39, Willy Tarreau : > On Fri, Jan 29, 2021 at 12:37:55AM +0500, ??? wrote: > > ??, 29 ???. 2021 ?. ? 00:05, Willy Tarreau : > > > > > On Thu, Jan 28, 2021 at 07:11:15PM +0100, Tim Düsterhus wrote: > > > > During dinner I had an idea how to fix this without

Re: [PATCH 2/2] CI: Fix DEBUG_STRICT definition for Coverity

2021-01-28 Thread Илья Шипицин
пт, 29 янв. 2021 г. в 00:05, Willy Tarreau : > On Thu, Jan 28, 2021 at 07:11:15PM +0100, Tim Düsterhus wrote: > > During dinner I had an idea how to fix this without introducing much > > additional complexity, I simply modify the Makefile in the Coverity > > workflow before starting the Coverity

<    1   2   3   4   5   6   7   8   9   10   >