Re: [PATCH v2] BUG/MEDIUM: systemd-wrapper: don't leak zombie processes

2013-04-01 Thread Marc-Antoine Perennou
On 1 April 2013 23:49, Willy Tarreau wrote: > Great. I'm planning a dev18 release for tomorrow afternoon, tell me > if you want me to wait a bit more. > > Thanks, > Willy > It will be ready before the afternoon so that you can get it in dev18! Thanks

Re: [PATCH v2] BUG/MEDIUM: systemd-wrapper: don't leak zombie processes

2013-04-01 Thread Willy Tarreau
On Mon, Apr 01, 2013 at 11:38:00PM +0200, Marc-Antoine Perennou wrote: > Hi, > > After checking out the man page of waitpid, wait would indeed be sufficient > here. > I didn't actually know about waitpid(-1) > > I'll resubmit an updated patch tomorrow! Great. I'm planning a dev18 release for tom

Re: [PATCH v2] BUG/MEDIUM: systemd-wrapper: don't leak zombie processes

2013-04-01 Thread Marc-Antoine Perennou
Hi, After checking out the man page of waitpid, wait would indeed be sufficient here. I didn't actually know about waitpid(-1) I'll resubmit an updated patch tomorrow! Thanks On 1 April 2013 23:32, Willy Tarreau wrote: > Hi Marc-Antoine, > > On Thu, Mar 14, 2013 at 02:50:56PM +0100, Marc-An

Re: [PATCH v2] BUG/MEDIUM: systemd-wrapper: don't leak zombie processes

2013-04-01 Thread Willy Tarreau
Hi Marc-Antoine, On Thu, Mar 14, 2013 at 02:50:56PM +0100, Marc-Antoine Perennou wrote: > Formerly, if A was replaced by B, and then B by C before > A finished exiting, we didn't wait for B to finish so it > ended up as a zombie process. > Fix this by queuing all process we spawn for waitpid. I'm

[PATCH v2] BUG/MEDIUM: systemd-wrapper: don't leak zombie processes

2013-03-14 Thread Marc-Antoine Perennou
Formerly, if A was replaced by B, and then B by C before A finished exiting, we didn't wait for B to finish so it ended up as a zombie process. Fix this by queuing all process we spawn for waitpid. Signed-off-by: Marc-Antoine Perennou --- src/haproxy-systemd-wrapper.c | 45 ++