Re: [PATCH v6 00/22] Agent Check Enhancements and External Check

2013-10-31 Thread Simon Horman
On Thu, Oct 31, 2013 at 10:26:06AM +0100, Willy Tarreau wrote: > Hi Malcolm, > > On Thu, Oct 31, 2013 at 09:02:04AM +, Malcolm Turnbull wrote: > > Willy / Simon, > > > > We haven't implemented it in the Loadbalancer.org appliance yet so we > > are happy for lb-agent-chk to be replaced. > > E

Re: [PATCH v6 00/22] Agent Check Enhancements and External Check

2013-10-31 Thread Willy Tarreau
Hi Malcolm, On Thu, Oct 31, 2013 at 09:02:04AM +, Malcolm Turnbull wrote: > Willy / Simon, > > We haven't implemented it in the Loadbalancer.org appliance yet so we > are happy for lb-agent-chk to be replaced. Excellent, thanks for letting us know! So Simon, now you can do as you prefer, wha

Re: [PATCH v6 00/22] Agent Check Enhancements and External Check

2013-10-31 Thread Malcolm Turnbull
Willy / Simon, We haven't implemented it in the Loadbalancer.org appliance yet so we are happy for lb-agent-chk to be replaced. We are very Keane to add the new agent and SSL support as soon as possible. It would be great if it got into Dev20 no pressure Simon :-). On 31 October 2013 08:55

Re: [PATCH v6 00/22] Agent Check Enhancements and External Check

2013-10-31 Thread Willy Tarreau
On Thu, Oct 31, 2013 at 09:37:01AM +0100, Baptiste wrote: > Well, no Exceliance customers use this feature yet, but some of them > asked for it (or something similar). > It would make HAProxy and the ALOHA more valuable. I think you misunderstood us Baptiste. Right now there is already lb-agent-ch

Re: [PATCH v6 00/22] Agent Check Enhancements and External Check

2013-10-31 Thread Baptiste
Well, no Exceliance customers use this feature yet, but some of them asked for it (or something similar). It would make HAProxy and the ALOHA more valuable. Baptiste On Thu, Oct 31, 2013 at 9:24 AM, Willy Tarreau wrote: > Hi Simon, > > On Thu, Oct 31, 2013 at 05:02:22PM +0900, Simon Horman wrot

Re: [PATCH v6 00/22] Agent Check Enhancements and External Check

2013-10-31 Thread Willy Tarreau
Hi Simon, On Thu, Oct 31, 2013 at 05:02:22PM +0900, Simon Horman wrote: > Hi Willy, > > sorry for not responding earlier. no problem, I know from your other patches I see on other lists that you're busy on several projects :-) > I will likely have more questions regarding your review > but at t

Re: [PATCH v6 00/22] Agent Check Enhancements and External Check

2013-10-31 Thread Simon Horman
Hi Willy, sorry for not responding earlier. I will likely have more questions regarding your review but at this point one in particular comes to mind: are you still interested in removing lb-agent-chk? If so I think it is a reasonable idea as it should avoid complexity both in this series and in

Re: [PATCH v6 00/22] Agent Check Enhancements and External Check

2013-09-06 Thread Willy Tarreau
Hi Simon, I'm finally done with the review. That was quite long (spread over two weeks), and obviously less than what it might have taken you to do this work. Next time if you can send smaller chunks it might help a lot ! Due to the difficulty to assign enough continuous time on it, I used "git n

[PATCH v6 00/22] Agent Check Enhancements and External Check

2013-08-22 Thread Simon Horman
Hi, this series comprises of several components I have combined them because they depend on each other. It should be possible to review the components in order without particular regard for subsequent components. That is, it should be possible to review small subsets of this series. A. Patches