Re: truncated request in log lines

2017-06-02 Thread Willy Tarreau
On Thu, May 18, 2017 at 08:58:41AM +0200, Stéphane Cottin wrote: > commit 7fb383cbfb42e58dc7764425bc5b1c3c11a111dc > Author: Stephane Cottin > Date: Thu May 18 08:41:06 2017 +0200 > > MINOR: Add logurilen tunable. (...) Now merged, thank you Stéphane. Willy

Re: truncated request in log lines

2017-05-18 Thread Willy Tarreau
On Thu, May 18, 2017 at 08:58:41AM +0200, Stéphane Cottin wrote: > > Nice, that was fast :-) > > Nobody have time, I just take care of things as they flow :) you're right! > Sorry, I didn't read the CONTRIBUTING, RTFM me. no pb. > Hope this one is better. Definitely. The most suitable form

Re: truncated request in log lines

2017-05-18 Thread Stéphane Cottin
On 18 May 2017, at 6:36, Willy Tarreau wrote: > Hi Stéphane, > > On Thu, May 18, 2017 at 02:31:07AM +0200, Stéphane Cottin wrote: >> patch attached. > > Nice, that was fast :-) Nobody have time, I just take care of things as they flow :) > > The patch looks pretty good. Just two things : > -

Re: truncated request in log lines

2017-05-17 Thread Willy Tarreau
Hi Stéphane, On Thu, May 18, 2017 at 02:31:07AM +0200, Stéphane Cottin wrote: > patch attached. Nice, that was fast :-) The patch looks pretty good. Just two things : - please provide the commit message with your patch ; please have a look at CONTRIBUTING, we have a few rules on the

Re: truncated request in log lines

2017-05-17 Thread Stéphane Cottin
Hi Willy, On 17 May 2017, at 20:54, Willy Tarreau wrote: Hi Stéphane, On Wed, May 17, 2017 at 02:03:26AM +0200, Stéphane Cottin wrote: Thanks, this is the right answer, recompile with DEFINE=-DREQURI_LEN=4096 fixes this issue. that's what I was going to say :-) This limit should be

Re: truncated request in log lines

2017-05-17 Thread Willy Tarreau
Hi Stéphane, On Wed, May 17, 2017 at 02:03:26AM +0200, Stéphane Cottin wrote: > Thanks, this is the right answer, recompile with DEFINE=-DREQURI_LEN=4096 > fixes this issue. that's what I was going to say :-) > This limit should be raised at runtime according to the log "len" option, if > you

Re: truncated request in log lines

2017-05-16 Thread Stéphane Cottin
Thanks, this is the right answer, recompile with DEFINE=-DREQURI_LEN=4096 fixes this issue. This limit should be raised at runtime according to the log "len" option, if you want long log lines, you want them complete :) Thanks again. Stéphane On 16 May 2017, at 19:29, J. Kendzorra wrote:

Re: truncated request in log lines

2017-05-16 Thread J. Kendzorra
On 16.05.2017 19:23, J. Kendzorra wrote: > On 16.05.2017 15:58, Stéphane Cottin wrote: >> Only the content of "GET /?test=my_very_long_request_truncated" is >> truncated to 1024 characters, not the whole line. >> The end quote is still present, it does not seems related to syslog >> daemon

Re: truncated request in log lines

2017-05-16 Thread J. Kendzorra
On 16.05.2017 15:58, Stéphane Cottin wrote: > Only the content of "GET /?test=my_very_long_request_truncated" is > truncated to 1024 characters, not the whole line. > The end quote is still present, it does not seems related to syslog > daemon limitations. I think you're looking for this thread:

Re: truncated request in log lines

2017-05-16 Thread Stéphane Cottin
Hi mark, Thanks for this link, but I guess this is not related to this issue. Let's use an example. A log line with method+request+protocol < 1024 characters and a very long captured header is ok : 172.17.0.1:38318 [16/May/2017:08:00:31.266] abcde fghij 0/0/106/139/268 200 9 - -

Re: truncated request in log lines

2017-05-16 Thread Daniel Schneller
This is a limitation of the syslog protocol, IIRC. -- Daniel Schneller Principal Cloud Engineer CenterDevice GmbH | Hochstraße 11 | 42697 Solingen tel: +49 1754155711| Deutschland daniel.schnel...@centerdevice.de |

truncated request in log lines

2017-05-16 Thread Stéphane Cottin
Hi, Version: haproxy 1.7.2 I'm logging to a unix socket, allowing long lines. log /dev/log len 8192 local0 [...] option dontlognull option log-separate-errors option httplog I'm also capturing the referer header. capture request header Referer len 4096 When using large strings