Since the ImageConsumer accepts Hashtable?,? my thought is that the
the GifDecoder should declare the field based on what it actually
uses. If the other decoders only use String keys and String values,
then I would suggest we change the field declaration to match.
Yes, it sounds reasonable.
On
Hi,
Rev. 465514 introduced a lot of invalid modifications to the
GifDecoder, PngDecoder and JpegDecoder. There were a number of fields
modified or initialized from the native code only, but they were
redeclared as final, so the decoders doesn't work properly any more.
This revision has the
Where are the tests for these decoders? How did you determine that
they no longer worked?
I'll remove the final modifiers.
-Nathan
On 10/24/06, Oleg Khaschansky [EMAIL PROTECTED] wrote:
Hi,
Rev. 465514 introduced a lot of invalid modifications to the
GifDecoder, PngDecoder and JpegDecoder.
I removed the final modifiers; this only affected PngDecoder,
GifDecoder and JpegDecoder. I missed the comments in the fields of
JpegDecoder, that was my mistake.
There were only 3-4 other fields that were finalized. Your email
mentioned a lot of invalid modifications; what are the other issues,
Where are the tests for these decoders? How did you determine that
they no longer worked?
Unfortunately, these classes are not covered with the unit tests.
I was running a simple test application that did something like this:
Toolkit.getDefaultToolkit().getImage(image.jpg);
and if failed
Nathan, could you, please tell why you changed the field properties in
these classes to
HashtableObject,Object in two of them and to
HashtableString,String in one of them (GifDecoder)?
Look at the declaration in the ImageConsumer class:
void setProperties(Hashtable?,? props)
It'd be better to
It'd be better to have Hashtable?,? as a type in all 3 classes and
HashtableObject,Object as an initial value for this field.
I mean that it is not an error but it seems to me semantically more meaningful
On 10/24/06, Oleg Khaschansky [EMAIL PROTECTED] wrote:
Nathan, could you, please tell
On 24 October 2006 at 18:25, Oleg Khaschansky [EMAIL PROTECTED] wrote:
Where are the tests for these decoders? How did you determine that
they no longer worked?
Unfortunately, these classes are not covered with the unit tests.
I was running a simple test application that did something
Unit tests for the decoders are up there in [1]
[1] https://issues.apache.org/jira/browse/HARMONY-1954
On 10/24/06, Oleg Khaschansky [EMAIL PROTECTED] wrote:
That's the start of a unit test, are you going to finish it? ;-)
Well, I'll look into this. We need to put a couple of images for this
Oleg Khaschansky wrote:
That's the start of a unit test, are you going to finish it? ;-)
Well, I'll look into this. We need to put a couple of images for this
kind of test somewhere...
How about a picture of you? :)
But not a lot compared to the number of cleanup changes Nathan has been
On 10/24/06, Oleg Khaschansky [EMAIL PROTECTED] wrote:
Nathan, could you, please tell why you changed the field properties in
these classes to
HashtableObject,Object in two of them and to
HashtableString,String in one of them (GifDecoder)?
Look at the declaration in the ImageConsumer class:
11 matches
Mail list logo
