Re: [classlib] Trying to catch patternset errors earlier

2006-10-05 Thread Mark Hindess
Ok. There haven't been any shouts against it so. I'm going to split the .java files that contain two classes and then dump the patternsets. Regards, Mark. On 3 October 2006 at 11:27, Oliver Deakin [EMAIL PROTECTED] wrote: Mark Hindess wrote: On 28 September 2006 at 14:58, Alexey Petrenko

Re: [classlib] Trying to catch patternset errors earlier

2006-10-05 Thread Geir Magnusson Jr.
Before you do that... you would be putting similar information in the build.xml file? Or am I misunderstanding something? having it in the patternset does make it easy to find stuff :) geir Mark Hindess wrote: Ok. There haven't been any shouts against it so. I'm going to split the .java

Re: [classlib] Trying to catch patternset errors earlier

2006-10-05 Thread Geir Magnusson Jr.
Mark Hindess wrote: On 5 October 2006 at 10:05, Geir Magnusson Jr. [EMAIL PROTECTED] wrote: Before you do that... you would be putting similar information in the build.xml file? Or am I misunderstanding something? having it in the patternset does make it easy to find stuff :) I'll be

Re: [classlib] Trying to catch patternset errors earlier

2006-10-03 Thread Oliver Deakin
Mark Hindess wrote: On 28 September 2006 at 14:58, Alexey Petrenko [EMAIL PROTECTED] wrote: 2006/9/28, Mark Hindess [EMAIL PROTECTED]: On 28 September 2006 at 14:30, Alexey Petrenko [EMAIL PROTECTED] om wrote: I think that it will be better to add another target to build

Re: [classlib] Trying to catch patternset errors earlier

2006-10-01 Thread Mark Hindess
On 28 September 2006 at 14:58, Alexey Petrenko [EMAIL PROTECTED] wrote: 2006/9/28, Mark Hindess [EMAIL PROTECTED]: On 28 September 2006 at 14:30, Alexey Petrenko [EMAIL PROTECTED] om wrote: I think that it will be better to add another target to build for this check. Because of two

[classlib] Trying to catch patternset errors earlier

2006-09-28 Thread Mark Hindess
Yesterday, while looking at something unrelated, I noticed that some of the patternsets that are used to select the jars for the classlib modules were not up to date with the result that some classes would be missing from the resulting jars[0]. While it makes me slightly uneasy having a clean

Re: [classlib] Trying to catch patternset errors earlier

2006-09-28 Thread Tim Ellison
Sounds reasonable. The alternative is to not make clean fail, just print the warning and tidy up the remainder. That may be too easy to ignore though. Regards, Tim Mark Hindess wrote: Yesterday, while looking at something unrelated, I noticed that some of the patternsets that are used to

Re: [classlib] Trying to catch patternset errors earlier

2006-09-28 Thread Mark Hindess
On 28 September 2006 at 11:07, Tim Ellison [EMAIL PROTECTED] wrote: Sounds reasonable. The alternative is to not make clean fail, just print the warning and tidy up the remainder. That may be too easy to ignore though. Yes. I considered that and had the same concern. Even if I wrote the

Re: [classlib] Trying to catch patternset errors earlier

2006-09-28 Thread Alexey Petrenko
I think that it will be better to add another target to build for this check. Because of two reasons: 1. It is unclear that clean is also checks something 2. If it will fail and leave some files in build dirs how should I clean the repository? 2006/9/28, Mark Hindess [EMAIL PROTECTED]: On 28

Re: [classlib] Trying to catch patternset errors earlier

2006-09-28 Thread Alexey Petrenko
2006/9/28, Mark Hindess [EMAIL PROTECTED]: On 28 September 2006 at 14:30, Alexey Petrenko [EMAIL PROTECTED] wrote: I think that it will be better to add another target to build for this check. Because of two reasons: 1. It is unclear that clean is also checks something This simple check can

Re: [classlib] Trying to catch patternset errors earlier

2006-09-28 Thread Geir Magnusson Jr.
On Sep 28, 2006, at 6:19 AM, Mark Hindess wrote: On 28 September 2006 at 11:07, Tim Ellison [EMAIL PROTECTED] wrote: Sounds reasonable. The alternative is to not make clean fail, just print the warning and tidy up the remainder. That may be too easy to ignore though. Yes. I considered