Re: [drlvm][icl] Fix for the gc_gen compilation problem with Intel Compiler, windows

2006-11-07 Thread Salikh Zakirov
Alexey Petrenko wrote: > Salikh could you please attach your patch to the HARMONY-1897 > specified by Alexei? done

Re: [drlvm][icl] Fix for the gc_gen compilation problem with Intel Compiler, windows

2006-11-04 Thread Xiao-Feng Li
I'd suggest to commit this patch since I have to admit that to define a type as parenthesis may not be a good code style. Thanks, xiaofeng On 11/5/06, Geir Magnusson Jr. <[EMAIL PROTECTED]> wrote: How about fixing the intel compiler? :) I suppose there's no harm, and if so, we'll find out...

Re: [drlvm][icl] Fix for the gc_gen compilation problem with Intel Compiler, windows

2006-11-04 Thread Geir Magnusson Jr.
How about fixing the intel compiler? :) I suppose there's no harm, and if so, we'll find out... Alexei Fedotov wrote: +1 for committing A declaration VmThreadHandle h; is converts to (void*) h; Intel compiler doesn't understand type names in brackets. This is a fix for http://issues.apache.or

Re: [drlvm][icl] Fix for the gc_gen compilation problem with Intel Compiler, windows

2006-11-04 Thread Alexey Petrenko
IMHO having corresponding JIRA is always good :) Salikh could you please attach your patch to the HARMONY-1897 specified by Alexei? SY, Alexey 2006/11/4, Alexei Fedotov <[EMAIL PROTECTED]>: +1 for committing A declaration VmThreadHandle h; is converts to (void*) h; Intel compiler doesn't unde

Re: [drlvm][icl] Fix for the gc_gen compilation problem with Intel Compiler, windows

2006-11-04 Thread Alexei Fedotov
+1 for committing A declaration VmThreadHandle h; is converts to (void*) h; Intel compiler doesn't understand type names in brackets. This is a fix for http://issues.apache.org/jira/browse/HARMONY-1897 icl build on Windows failed Thanks, Salikh. A good catch! On 11/3/06, Salikh Zakirov <[EMAIL

[drlvm][icl] Fix for the gc_gen compilation problem with Intel Compiler, windows

2006-11-03 Thread Salikh Zakirov
Hi, the following trivial patch fixes the gc_gen compilation problem with Intel Compiler under Windows: --- vm/gc_gen/src/common/gc_platform.h +++ vm/gc_gen/src/common/gc_platform.h @@ -29,7 +29,7 @@ #include #define USEC_PER_SEC INT64_C(100) -#define VmThreadHandle (void*) +#define VmT